MCP-826: Use RabbitMQ for all consumers if AMQP is set in deployment config

- Fix static tests;

Author: adifucan

app/code/Magento/MessageQueue/Setup/ConfigOptionsList.php

@@ -62,7 +62,7 @@ public function getOptions()
                 self::INPUT_KEY_QUEUE_DEFAULT_CONNECTION,
                 TextConfigOption::FRONTEND_WIZARD_TEXT,
                 self::CONFIG_PATH_QUEUE_DEFAULT_CONNECTION,
-                'Default queue connection. Can be db, amqp or a custom one.',
+                'Message queues default connection. Can be db, amqp or a custom one.',
                 self::DEFAULT_QUEUE_CONNECTION
             ),
         ];

lib/internal/Magento/Framework/Amqp/Bulk/Exchange.php

@@ -57,7 +57,6 @@ public function __construct(
 
     /**
      * @inheritdoc
-     * @SuppressWarnings(PHPMD)
      */
     public function enqueue($topic, array $envelopes)
     {
@@ -77,10 +76,12 @@ public function enqueue($topic, array $envelopes)
         $exchange = $publisher->getConnection()->getExchange();
 
         foreach ($envelopes as $envelope) {
+            // @codingStandardsIgnoreStart
             $msg = new AMQPMessage(
                 $envelope->getBody(),
                 array_merge(['delivery_mode' => 2], $envelope->getProperties())
             );
+            // @codingStandardsIgnoreEnd
             $channel->batch_basic_publish($msg, $exchange, $topic);
         }
         $channel->publish_batch();

lib/internal/Magento/Framework/MessageQueue/Config/Reader/Xml/Converter/TopicConfig.php

@@ -180,7 +180,9 @@ private function processWildcard($topics)
             foreach (array_keys($topicDefinitions) as $topicName) {
                 if (preg_match($pattern, $topicName)) {
                     if (isset($topics[$topicName])) {
+                        // @codingStandardsIgnoreStart
                         $topics[$topicName] = array_merge($topics[$topicName], $topics[$wildcardKey]);
+                        // @codingStandardsIgnoreEnd
                     } else {
                         $topics[$topicName] = $topics[$wildcardKey];
                     }

lib/internal/Magento/Framework/MessageQueue/Topology/Config/Xml/Converter.php

@@ -86,12 +86,14 @@ public function convert($source)
                 }
             }
 
+            // @codingStandardsIgnoreStart
             if (isset($result[$name . '--' . $connection]['bindings']) && count($bindings) > 0) {
                 $bindings = array_merge($result[$name . '--' . $connection]['bindings'], $bindings);
             }
             if (isset($result[$name . '--' . $connection]['arguments']) && count($exchangeArguments) > 0) {
                 $exchangeArguments = array_merge($result[$name . '--' . $connection]['arguments'], $exchangeArguments);
             }
+            // @codingStandardsIgnoreEnd
 
             $autoDelete = $this->getAttributeValue($exchange, 'autoDelete', false);
             $result[$name . '--' . $connection] = [