Merge remote-tracking branch 'origin/MC-39722' into 2.4-develop-sidecar-pr12

Author: ysapiga

dev/tests/integration/testsuite/Magento/Catalog/Model/Indexer/Product/Flat/Action/FullTest.php

@@ -3,40 +3,52 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Catalog\Model\Indexer\Product\Flat\Action;
 
 use Magento\Catalog\Api\Data\ProductInterface;
+use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Catalog\Block\Product\ListProduct;
 use Magento\Catalog\Model\CategoryFactory;
 use Magento\Catalog\Model\Indexer\Product\Flat\Processor;
 use Magento\Catalog\Model\Indexer\Product\Flat\State;
 use Magento\Catalog\Model\ResourceModel\Product\CollectionFactory as ProductCollectionFactory;
+use Magento\Catalog\Model\ResourceModel\Product\Flat as FlatResource;
 use Magento\CatalogSearch\Model\Indexer\Fulltext;
+use Magento\Eav\Api\AttributeOptionManagementInterface;
 use Magento\Framework\Indexer\IndexerRegistry;
+use Magento\Framework\ObjectManagerInterface;
 use Magento\Store\Model\StoreManagerInterface;
 use Magento\TestFramework\Helper\Bootstrap;
-use Magento\TestFramework\ObjectManager;
+use Magento\TestFramework\Indexer\TestCase;
 
 /**
  * Full reindex Test
  */
-class FullTest extends \Magento\TestFramework\Indexer\TestCase
+class FullTest extends TestCase
 {
-    /**
-     * @var State
-     */
-    protected $_state;
+    /** @var State */
+    private $state;
 
-    /**
-     * @var Processor
-     */
-    protected $_processor;
+    /** @var Processor */
+    private $processor;
 
-    /**
-     * @var ObjectManager
-     */
+    /** @var ObjectManagerInterface */
     private $objectManager;
 
+    /** @var FlatResource */
+    private $flatResource;
+
+    /** @var AttributeOptionManagementInterface */
+    private $optionManagement;
+
+    /** @var ProductRepositoryInterface */
+    private $productRepository;
+
+    /** @var Full */
+    private $action;
+
     /**
      * @inheritdoc
      */
@@ -58,21 +70,29 @@ public static function setUpBeforeClass(): void
      */
     protected function setUp(): void
     {
+        parent::setUp();
+
         $this->objectManager = Bootstrap::getObjectManager();
-        $this->_state = $this->objectManager->get(State::class);
-        $this->_processor = $this->objectManager->get(Processor::class);
+        $this->state = $this->objectManager->get(State::class);
+        $this->processor = $this->objectManager->get(Processor::class);
+        $this->flatResource = $this->objectManager->get(FlatResource::class);
+        $this->optionManagement = $this->objectManager->get(AttributeOptionManagementInterface::class);
+        $this->productRepository = $this->objectManager->get(ProductRepositoryInterface::class);
+        $this->action = $this->objectManager->get(Full::class);
     }
 
     /**
      * @magentoDbIsolation disabled
      * @magentoAppIsolation enabled
      * @magentoConfigFixture current_store catalog/frontend/flat_catalog_product 1
      * @magentoDataFixture Magento/Catalog/_files/product_simple.php
+     *
+     * @return void
      */
-    public function testReindexAll()
+    public function testReindexAll(): void
     {
-        $this->assertTrue($this->_state->isFlatEnabled());
-        $this->_processor->reindexAll();
+        $this->assertTrue($this->state->isFlatEnabled());
+        $this->processor->reindexAll();
 
         $categoryFactory = $this->objectManager->get(CategoryFactory::class);
         $listProduct = $this->objectManager->get(ListProduct::class);
@@ -98,11 +118,13 @@ public function testReindexAll()
      * @magentoDataFixture Magento/Catalog/_files/product_simple_multistore.php
      * @magentoConfigFixture current_store catalog/frontend/flat_catalog_product 1
      * @magentoConfigFixture fixturestore_store catalog/frontend/flat_catalog_product 1
+     *
+     * @return void
      */
-    public function testReindexAllMultipleStores()
+    public function testReindexAllMultipleStores(): void
     {
-        $this->assertTrue($this->_state->isFlatEnabled());
-        $this->_processor->reindexAll();
+        $this->assertTrue($this->state->isFlatEnabled());
+        $this->processor->reindexAll();
 
         /** @var ProductCollectionFactory $productCollectionFactory */
         $productCollectionFactory = $this->objectManager->create(ProductCollectionFactory::class);
@@ -116,24 +138,76 @@ public function testReindexAllMultipleStores()
             $store->getId() => 'StoreTitle',
         ];
 
-        foreach ($expectedData as $storeId => $productName) {
-            $storeManager->setCurrentStore($storeId);
-            $productCollection = $productCollectionFactory->create();
-
-            $this->assertTrue(
-                $productCollection->isEnabledFlat(),
-                'Flat should be enabled for product collection.'
-            );
+        try {
+            foreach ($expectedData as $storeId => $productName) {
+                $storeManager->setCurrentStore($storeId);
+                $productCollection = $productCollectionFactory->create();
+
+                $this->assertTrue(
+                    $productCollection->isEnabledFlat(),
+                    'Flat should be enabled for product collection.'
+                );
+
+                $productCollection->addIdFilter(1)->addAttributeToSelect(ProductInterface::NAME);
+
+                $this->assertEquals(
+                    $productName,
+                    $productCollection->getFirstItem()->getName(),
+                    'Wrong product name specified per store.'
+                );
+            }
+        } finally {
+            $storeManager->setCurrentStore($currentStore);
+        }
+    }
 
-            $productCollection->addIdFilter(1)->addAttributeToSelect(ProductInterface::NAME);
+    /**
+     * @magentoDbIsolation disabled
+     *
+     * @magentoConfigFixture current_store catalog/frontend/flat_catalog_product 1
+     * @magentoDataFixture Magento/Catalog/_files/dropdown_attribute.php
+     * @magentoDataFixture Magento/Catalog/_files/second_product_simple.php
+     *
+     * @return void
+     */
+    public function testCheckDropdownAttributeInFlat(): void
+    {
+        $attributeCode = 'dropdown_attribute';
+        $options = $this->optionManagement->getItems($this->flatResource->getTypeId(), $attributeCode);
+        $attributeValue = $options[1]->getValue();
+        $this->updateProduct('simple2', $attributeCode, $attributeValue);
+        $this->action->execute();
+        $this->assertFlatColumnValue($attributeCode, $attributeValue);
+    }
 
-            $this->assertEquals(
-                $productName,
-                $productCollection->getFirstItem()->getName(),
-                'Wrong product name specified per store.'
-            );
-        }
+    /**
+     * Assert if column exist and column value in flat table
+     *
+     * @param string $attributeCode
+     * @param string $value
+     * @return void
+     */
+    private function assertFlatColumnValue(string $attributeCode, string $value): void
+    {
+        $connect = $this->flatResource->getConnection();
+        $tableName = $this->flatResource->getFlatTableName();
+        $this->assertTrue($connect->tableColumnExists($tableName, $attributeCode));
+        $select = $connect->select()->from($tableName, $attributeCode);
+        $this->assertEquals($value, $connect->fetchOne($select));
+    }
 
-        $storeManager->setCurrentStore($currentStore);
+    /**
+     * Update product
+     *
+     * @param string $sku
+     * @param string $attributeCode
+     * @param string $value
+     * @return void
+     */
+    private function updateProduct(string $sku, string $attributeCode, string $value): void
+    {
+        $product = $this->productRepository->get($sku);
+        $product->setData($attributeCode, $value);
+        $this->productRepository->save($product);
     }
 }