ACP2E-1348: Catalog price rule is applied only to the first product from the conditions with list of SKUs

Author: dhorytskyi

app/code/Magento/Rule/Model/Condition/Product/AbstractProduct.php

@@ -516,7 +516,7 @@ public function loadArray($arr)
             ) ? $this->_localeFormat->getNumber(
                 $arr['is_value_parsed']
             ) : false;
-        } elseif (!empty($arr['operator']) && $arr['operator'] == '()') {
+        } elseif (!empty($arr['operator']) && in_array($arr['operator'], ['()', '!()', true])) {
             if (isset($arr['value'])) {
                 $arr['value'] = preg_replace('/\s*,\s*/', ',', $arr['value']);
             }

dev/tests/integration/testsuite/Magento/CatalogRule/Model/ResourceModel/Product/ConditionsToCollectionApplierTest.php

@@ -433,6 +433,22 @@ private function conditionProvider()
                     'simple-product-13',
                 ]
             ],
+
+            // test filter by multiple sku and "is not one of" condition
+            'variation 23' => [
+                'condition' => $this->getConditionsForVariation23(),
+                'expected-sku' => [
+                    'simple-product-3',
+                    'simple-product-4',
+                    'simple-product-6',
+                    'simple-product-7',
+                    'simple-product-8',
+                    'simple-product-9',
+                    'simple-product-11',
+                    'simple-product-12',
+                    'simple-product-13',
+                ]
+            ],
         ];
     }
 
@@ -1058,6 +1074,25 @@ private function getConditionsForVariation22()
         return $this->getCombineConditionFromArray($conditions);
     }
 
+    private function getConditionsForVariation23()
+    {
+        $conditions = [
+            'type' => \Magento\CatalogRule\Model\Rule\Condition\Combine::class,
+            'aggregator' => 'all',
+            'value' => 1,
+            'conditions' => [
+                [
+                    'type' => \Magento\CatalogRule\Model\Rule\Condition\Product::class,
+                    'operator' => '!()',
+                    'value' => 'simple-product-1, simple-product-2, simple-product-5, simple-product-10',
+                    'attribute' => 'sku'
+                ]
+            ]
+        ];
+
+        return $this->getCombineConditionFromArray($conditions);
+    }
+
     private function getCombineConditionFromArray(array $data)
     {
         $combinedCondition = $this->combinedConditionFactory->create();