LYNX-441 (#260)

Author: eliseacornejo

app/code/Magento/Customer/Model/AccountManagement.php

@@ -847,9 +847,14 @@ public function getConfirmationStatus($customerId)
      */
     public function createAccount(CustomerInterface $customer, $password = null, $redirectUrl = '')
     {
+        $customerEmail = $customer->getEmail();
+        if ($customerEmail === null) {
+            throw new LocalizedException(
+                __("The email address is required to create a customer account.")
+            );
+        }
         if ($password !== null) {
             $this->checkPasswordStrength($password);
-            $customerEmail = $customer->getEmail();
             try {
                 $this->credentialsValidator->checkPasswordDifferentFromEmail($customerEmail, $password);
             } catch (InputException $e) {

app/code/Magento/Customer/Test/Fixture/CustomerAttributeDefaultData.php

@@ -16,6 +16,7 @@ class CustomerAttributeDefaultData
         'default_frontend_label' => 'Attribute%uniqid%',
         'frontend_labels' => [],
         'frontend_input' => 'text',
+        'frontend_label' => null,
         'backend_type' => 'varchar',
         'is_required' => false,
         'is_user_defined' => true,

app/code/Magento/Customer/Test/Unit/Model/AccountManagementApiTest.php

@@ -5,10 +5,8 @@
  */
 declare(strict_types=1);
 
-
 namespace Magento\Customer\Test\Unit\Model;
 
-
 use Magento\Customer\Api\AddressRepositoryInterface;
 use Magento\Customer\Api\CustomerMetadataInterface;
 use Magento\Customer\Api\CustomerRepositoryInterface;
@@ -59,7 +57,6 @@
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
 
-
 /**
  * Test for validating anonymous request for synchronous operations containing group id.
  *
@@ -73,223 +70,186 @@ class AccountManagementApiTest extends TestCase
      */
     private $accountManagementMock;
 
-
     /**
      * @var AccountManagementApi
      */
     private $accountManagement;
 
-
     /**
      * @var ObjectManagerHelper
      */
     private $objectManagerHelper;
 
-
     /**
      * @var CustomerFactory|MockObject
      */
     private $customerFactory;
 
-
     /**
      * @var ManagerInterface|MockObject
      */
     private $manager;
 
-
     /**
      * @var StoreManagerInterface|MockObject
      */
     private $storeManager;
 
-
     /**
      * @var Random|MockObject
      */
     private $random;
 
-
     /**
      * @var Validator|MockObject
      */
     private $validator;
 
-
     /**
      * @var ValidationResultsInterfaceFactory|MockObject
      */
     private $validationResultsInterfaceFactory;
 
-
     /**
      * @var AddressRepositoryInterface|MockObject
      */
     private $addressRepository;
 
-
     /**
      * @var CustomerMetadataInterface|MockObject
      */
     private $customerMetadata;
 
-
     /**
      * @var CustomerRegistry|MockObject
      */
     private $customerRegistry;
 
-
     /**
      * @var LoggerInterface|MockObject
      */
     private $logger;
 
-
     /**
      * @var EncryptorInterface|MockObject
      */
     private $encryptor;
 
-
     /**
      * @var Share|MockObject
      */
     private $share;
 
-
     /**
      * @var StringUtils|MockObject
      */
     private $string;
 
-
     /**
      * @var CustomerRepositoryInterface|MockObject
      */
     private $customerRepository;
 
-
     /**
      * @var ScopeConfigInterface|MockObject
      */
     private $scopeConfig;
 
-
     /**
      * @var TransportBuilder|MockObject
      */
     private $transportBuilder;
 
-
     /**
      * @var DataObjectProcessor|MockObject
      */
     private $dataObjectProcessor;
 
-
     /**
      * @var Registry|MockObject
      */
     private $registry;
 
-
     /**
      * @var View|MockObject
      */
     private $customerViewHelper;
 
-
     /**
      * @var \Magento\Framework\Stdlib\DateTime|MockObject
      */
     private $dateTime;
 
-
     /**
      * @var \Magento\Customer\Model\Customer|MockObject
      */
     private $customer;
 
-
     /**
      * @var DataObjectFactory|MockObject
      */
     private $objectFactory;
 
-
     /**
      * @var ExtensibleDataObjectConverter|MockObject
      */
     private $extensibleDataObjectConverter;
 
-
     /**
      * @var DateTimeFactory|MockObject
      */
     private $dateTimeFactory;
 
-
     /**
      * @var AccountConfirmation|MockObject
      */
     private $accountConfirmation;
 
-
     /**
      * @var MockObject|SessionManagerInterface
      */
     private $sessionManager;
 
-
     /**
      * @var  MockObject|CollectionFactory
      */
     private $visitorCollectionFactory;
 
-
     /**
      * @var MockObject|SaveHandlerInterface
      */
     private $saveHandler;
 
-
     /**
      * @var MockObject|AddressRegistry
      */
     private $addressRegistryMock;
 
-
     /**
      * @var MockObject|SearchCriteriaBuilder
      */
     private $searchCriteriaBuilderMock;
 
-
     /**
      * @var AllowedCountries|MockObject
      */
     private $allowedCountriesReader;
 
-
     /**
      * @var Authorization|MockObject
      */
     private $authorizationMock;
 
-
     /**
      * @var CustomerSecure|MockObject
      */
     private $customerSecure;
 
-
     /**
      * @var StoreInterface|MockObject
      */
     private $storeMock;
 
-
     /**
      * @inheritDoc
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
@@ -308,7 +268,6 @@ protected function setUp(): void
         $this->customerMetadata = $this->getMockForAbstractClass(CustomerMetadataInterface::class);
         $this->customerRegistry = $this->createMock(CustomerRegistry::class);
 
-
         $this->logger = $this->getMockForAbstractClass(LoggerInterface::class);
         $this->encryptor = $this->getMockForAbstractClass(EncryptorInterface::class);
         $this->share = $this->createMock(Share::class);
@@ -338,7 +297,6 @@ protected function setUp(): void
         $this->accountConfirmation = $this->createMock(AccountConfirmation::class);
         $this->searchCriteriaBuilderMock = $this->createMock(SearchCriteriaBuilder::class);
 
-
         $this->visitorCollectionFactory = $this->getMockBuilder(CollectionFactory::class)
             ->disableOriginalConstructor()
             ->onlyMethods(['create'])
@@ -449,14 +407,12 @@ protected function setUp(): void
         );
         $this->accountManagementMock = $this->createMock(AccountManagement::class);
 
-
         $this->storeMock = $this->getMockBuilder(
             StoreInterface::class
         )->disableOriginalConstructor()
             ->getMock();
     }
 
-
     /**
      * Verify that only authorized request will be able to change groupId
      *
@@ -486,7 +442,6 @@ public function testBeforeCreateAccount(
             ->with('Magento_Customer::manage')
             ->willReturn($isAllowed);
 
-
         $customer =  $this->getMockBuilder(CustomerInterface::class)
             ->addMethods(['setData'])
             ->getMockForAbstractClass();
@@ -495,13 +450,12 @@ public function testBeforeCreateAccount(
         $customer->method('getWebsiteId')->willReturn(2);
         $customer->method('getStoreId')->willReturn(1);
         $customer->method('setData')->willReturn(1);
-
+        $customer->method('getEmail')->willReturn('email@email.com');
 
         $this->customerRepository->method('get')->willReturn($customer);
         $this->customerRepository->method('getById')->with($customerId)->willReturn($customer);
         $this->customerRepository->method('save')->willReturn($customer);
 
-
         if (!$willThrowException) {
             $this->accountManagementMock->method('createAccountWithPasswordHash')->willReturn($customer);
             $this->storeMock->expects($this->any())->method('getId')->willReturnOnConsecutiveCalls(2, 1);
@@ -523,7 +477,6 @@ public function testBeforeCreateAccount(
         $this->accountManagement->createAccount($customer);
     }
 
-
     /**
      * @return array
      */

app/code/Magento/Customer/Test/Unit/Model/AccountManagementTest.php

@@ -998,6 +998,9 @@ public function testCreateAccountWithPasswordInputException(
         $customer = $this->getMockBuilder(Customer::class)
             ->disableOriginalConstructor()
             ->getMock();
+        $customer->expects($this->atLeastOnce())
+            ->method('getEmail')
+            ->willReturn('email@email.com');
         $this->accountManagement->createAccount($customer, $password);
     }
 
@@ -1021,6 +1024,9 @@ public function testCreateAccountInputExceptionExtraLongPassword(): void
         $customer = $this->getMockBuilder(Customer::class)
             ->disableOriginalConstructor()
             ->getMock();
+        $customer->expects($this->atLeastOnce())
+            ->method('getEmail')
+            ->willReturn('email@email.com');
         $this->accountManagement->createAccount($customer, $password);
     }