MCP-806: Prevent opcache invalidation on every request

- Move test from web api to integration because of error on CI builds that domain is not in the list of downloadable domains in env.php

Author: adifucan

dev/tests/api-functional/testsuite/Magento/Downloadable/Api/SampleRepositoryTest.php

@@ -173,31 +173,6 @@ public function testCreateUploadsProvidedFileContent()
         $this->assertNull($sample->getSampleUrl());
     }
 
-    /**
-     * @magentoApiDataFixture Magento/Downloadable/_files/product_downloadable.php
-     */
-    public function testCreateSavesProvidedUrls()
-    {
-        $requestData = [
-            'isGlobalScopeContent' => false,
-            'sku' => 'downloadable-product',
-            'sample' => [
-                'title' => 'Sample with URL resource',
-                'sort_order' => 1,
-                'sample_url' => 'http://www.sample.example.com/',
-                'sample_type' => 'url',
-            ],
-        ];
-
-        $newSampleId = $this->_webApiCall($this->createServiceInfo, $requestData);
-        $sample = $this->getTargetSample($this->getTargetProduct(), $newSampleId);
-        $this->assertNotNull($sample);
-        $this->assertEquals($requestData['sample']['title'], $sample->getTitle());
-        $this->assertEquals($requestData['sample']['sort_order'], $sample->getSortOrder());
-        $this->assertEquals($requestData['sample']['sample_type'], $sample->getSampleType());
-        $this->assertEquals($requestData['sample']['sample_url'], $sample->getSampleUrl());
-    }
-
     /**
      * @magentoApiDataFixture Magento/Downloadable/_files/product_downloadable.php
      */

dev/tests/integration/testsuite/Magento/Downloadable/Model/SampleRepositoryTest.php

@@ -34,13 +34,9 @@ protected function setUp(): void
     }
 
     /**
-     * Originally this test belonged to \Magento\Downloadable\Api\SampleRepositoryTest
-     * but it was moved to integration tests
-     * because of error on CI builds that sample URL's domain is not in the list of downloadable_domains in env.php
-     *
      * @magentoDataFixture Magento/Downloadable/_files/product_downloadable.php
      */
-    public function testCreateSavesTitleInStoreViewScope(): void
+    public function testCreateSavesProvidedUrls()
     {
         /** @var ProductRepositoryInterface $productRepository */
         $productRepository = $this->objectManager->create(ProductRepositoryInterface::class);
@@ -51,7 +47,7 @@ public function testCreateSavesTitleInStoreViewScope(): void
         $samples = $this->model->getSamples($product);
         $this->assertEmpty($samples->getData());
         $downloadableSampleData = [
-            'title' => 'Store View Title',
+            'title' => 'Sample with URL resource',
             'sort_order' => 1,
             'sample_url' => 'http://www.sample.example.com/',
             'sample_type' => 'url',
@@ -70,13 +66,54 @@ public function testCreateSavesTitleInStoreViewScope(): void
         $product->setExtensionAttributes($extension);
         $productRepository->save($product);
 
-        $expectedSample = [
+        $samples = $this->getTargetProduct(false)->getExtensionAttributes()->getDownloadableProductSamples();
+        $sample = reset($samples);
+
+        $this->assertNotEmpty($sample->getData());
+        $this->assertCount(1, $samples);
+
+        /** @var \Magento\Downloadable\Model\Sample $sample */
+        $sampleData = $sample->getData();
+        /** @var \Magento\User\Api\Data\UserInterface $testAttribute */
+        foreach ($downloadableSampleData as $key => $value) {
+            $this->assertArrayHasKey($key, $sampleData);
+            $this->assertEquals($value, $sampleData[$key]);
+        }
+    }
+
+    /**
+     * @magentoDataFixture Magento/Downloadable/_files/product_downloadable.php
+     */
+    public function testCreateSavesTitleInStoreViewScope(): void
+    {
+        /** @var ProductRepositoryInterface $productRepository */
+        $productRepository = $this->objectManager->create(ProductRepositoryInterface::class);
+        $product = $this->getTargetProduct(false);
+
+        $links = $this->model->getLinks($product);
+        $this->assertNotEmpty($links);
+        $samples = $this->model->getSamples($product);
+        $this->assertEmpty($samples->getData());
+        $downloadableSampleData = [
             'title' => 'Store View Title',
             'sort_order' => 1,
             'sample_url' => 'http://www.sample.example.com/',
-            'sample_type' => 'url',
+            'sample_type' => 'url'
         ];
 
+        $sampleFactory = $this->objectManager->create(SampleInterfaceFactory::class);
+        $extension = $product->getExtensionAttributes();
+        $sample = $sampleFactory->create(['data' => $downloadableSampleData]);
+        $sample->setStoreId($product->getStoreId());
+        $sample->setSampleType($downloadableSampleData['sample_type']);
+        $sample->setSampleUrl($downloadableSampleData['sample_url']);
+        if (!$sample->getSortOrder()) {
+            $sample->setSortOrder(1);
+        }
+        $extension->setDownloadableProductSamples([$sample]);
+        $product->setExtensionAttributes($extension);
+        $productRepository->save($product);
+
         $samples = $this->getTargetProduct(false)->getExtensionAttributes()->getDownloadableProductSamples();
         $sample = reset($samples);
 
@@ -86,7 +123,7 @@ public function testCreateSavesTitleInStoreViewScope(): void
         /** @var \Magento\Downloadable\Model\Sample $sample */
         $sampleData = $sample->getData();
         /** @var \Magento\User\Api\Data\UserInterface $testAttribute */
-        foreach ($expectedSample as $key => $value) {
+        foreach ($downloadableSampleData as $key => $value) {
             $this->assertArrayHasKey($key, $sampleData);
             $this->assertEquals($value, $sampleData[$key]);
         }