ACPT-1135: GraphQl scenarios fixes for Application server

 -- pr stabilization

Author: andimov

app/code/Magento/CatalogInventory/Model/Configuration.php

@@ -13,9 +13,6 @@
 use Magento\Store\Model\ScopeInterface;
 use Magento\Store\Model\StoreManagerInterface;
 
-/**
- * Class Configuration
- */
 class Configuration implements StockConfigurationInterface, ResetAfterRequestInterface
 {
     /**

app/code/Magento/CatalogSearch/Model/ResourceModel/Fulltext/Collection.php

@@ -249,7 +249,8 @@ private function getSearch()
     /**
      * Test search.
      *
-     * @deprecated 100.1.0 @see __construct
+     * @deprecated 100.1.0
+     * @see __construct
      * @param \Magento\Search\Api\SearchInterface $object
      * @return void
      * @since 100.1.0
@@ -276,7 +277,8 @@ private function getSearchCriteriaBuilder()
     /**
      * Set search criteria builder.
      *
-     * @deprecated 100.1.0 @see __construct
+     * @deprecated 100.1.0
+     * @see __construct
      * @param \Magento\Framework\Api\Search\SearchCriteriaBuilder $object
      * @return void
      * @since 100.1.0
@@ -302,7 +304,8 @@ private function getFilterBuilder()
     /**
      * Set filter builder.
      *
-     * @deprecated 100.1.0 @see __construct
+     * @deprecated 100.1.0
+     * @see __construct
      * @param \Magento\Framework\Api\FilterBuilder $object
      * @return void
      * @since 100.1.0

app/code/Magento/Eav/Model/ResourceModel/Attribute/Collection.php

@@ -10,6 +10,7 @@
 /**
  * EAV additional attribute resource collection (Using Forms)
  *
+ * phpcs:disable Magento2.Classes.AbstractApi.AbstractApi
  * @api
  * @since 100.0.2
  */
@@ -67,7 +68,7 @@ public function __construct(
     /**
      * @inheritDoc
      */
-    public function _resetState(): void
+    public function _resetState(): void //phpcs:ignore Magento2.CodeAnalysis.EmptyBlock.DetectedFunction
     {
         /* Note: because Eav attribute loading takes significant performance,
         we are not resetting it like other collections. */

app/code/Magento/Eav/Model/ResourceModel/Form/Attribute/Collection.php

@@ -203,6 +203,7 @@ public function setSortOrder($direction = self::SORT_ORDER_ASC)
      */
     protected function _beforeLoad()
     {
+        $store = $this->getStore();
         $select = $this->getSelect();
         $connection = $this->getConnection();
         $entityType = $this->getEntityType();
@@ -264,7 +265,6 @@ protected function _beforeLoad()
                 }
             }
 
-            $store = $this->getStore();
             $joinWebsiteExpression = $connection->quoteInto(
                 'sa.attribute_id = main_table.attribute_id AND sa.website_id = ?',
                 (int)$store->getWebsiteId()

app/code/Magento/Newsletter/Model/ResourceModel/Subscriber/Collection.php

@@ -32,7 +32,7 @@ class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\Ab
     protected $_storeTable;
 
     /**
-     * Queue joined flag
+     * Flag for joined queue
      *
      * @var boolean
      */

app/code/Magento/Store/Model/StoreManager.php

@@ -335,6 +335,6 @@ public function __debugInfo()
      */
     public function _resetState(): void
     {
-        $this->reinitStores();
+        $this->currentStoreId = null;
     }
 }

dev/tests/integration/framework/Magento/TestFramework/Event/Transaction.php

@@ -87,6 +87,7 @@ protected function _processTransactionRequests($eventName, \PHPUnit\Framework\Te
      *
      * @param \PHPUnit\Framework\TestCase $test
      * @SuppressWarnings(PHPMD.UnusedLocalVariable)
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     protected function _startTransaction(\PHPUnit\Framework\TestCase $test)
     {