AC-8017 system settings improvement

sreenia806 · sreenia806 · commit cff1b9cb3f21 · 2023-07-03T16:36:50.000+05:30
diff --git a/dev/tests/integration/testsuite/Magento/EncryptionKey/Setup/Patch/Data/SodiumChachaPatchTest.php b/dev/tests/integration/testsuite/Magento/EncryptionKey/Setup/Patch/Data/SodiumChachaPatchTest.php
@@ -15,7 +15,7 @@
 
 class SodiumChachaPatchTest extends \PHPUnit\Framework\TestCase
 {
-    const PATH_KEY = 'crypt/key';
+    private const PATH_KEY = 'crypt/key';
 
     /**
      * @var ObjectManagerInterface
diff --git a/lib/internal/Magento/Framework/Math/Random.php b/lib/internal/Magento/Framework/Math/Random.php
@@ -92,7 +92,7 @@ public function getUniqueHash($prefix = '')
      * @return string
      * @throws Exception
      */
-    public function getRandomBytes($length)
+    public function getRandomBytes(int $length) : string
     {
         return base64_encode(random_bytes($length));
     }

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`class SodiumChachaPatchTest extends \PHPUnit\Framework\TestCase`
`17`	`17`	`{`
`18`		`- const PATH_KEY = 'crypt/key';`
	`18`	`+ private const PATH_KEY = 'crypt/key';`
`19`	`19`
`20`	`20`	`/**`
`21`	`21`	`* @var ObjectManagerInterface`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public function getUniqueHash($prefix = '')`
`92`	`92`	`* @return string`
`93`	`93`	`* @throws Exception`
`94`	`94`	`*/`
`95`		`- public function getRandomBytes($length)`
	`95`	`+ public function getRandomBytes(int $length) : string`
`96`	`96`	`{`
`97`	`97`	`return base64_encode(random_bytes($length));`
`98`	`98`	`}`