Fixed Static Tests

Author: anzin

app/code/Magento/Catalog/Helper/Product/View.php

@@ -26,29 +26,21 @@ class View extends \Magento\Framework\App\Helper\AbstractHelper
     protected $messageGroups;
 
     /**
-     * Core registry
-     *
      * @var \Magento\Framework\Registry
      */
     protected $_coreRegistry = null;
 
     /**
-     * Catalog product
-     *
      * @var \Magento\Catalog\Helper\Product
      */
     protected $_catalogProduct = null;
 
     /**
-     * Catalog design
-     *
      * @var \Magento\Catalog\Model\Design
      */
     protected $_catalogDesign;
 
     /**
-     * Catalog session
-     *
      * @var \Magento\Catalog\Model\Session
      */
     protected $_catalogSession;

app/code/Magento/ReleaseNotification/Model/Condition/CanViewNotification.php

@@ -14,6 +14,7 @@
 /**
  * Dynamic validator for UI release notification, manage UI component visibility.
  * Return true if the logged in user has not seen the notification.
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  */
 class CanViewNotification implements VisibilityConditionInterface
 {
@@ -72,8 +73,6 @@ public function __construct(
     }
 
     /**
-     * Validate if notification popup can be shown and set the notification flag
-     *
      * @inheritdoc
      */
     public function isVisible(array $arguments)

app/code/Magento/Sales/Helper/Guest.php

@@ -20,8 +20,6 @@
 class Guest extends \Magento\Framework\App\Helper\AbstractHelper
 {
     /**
-     * Core registry
-     *
      * @var \Magento\Framework\Registry
      */
     protected $coreRegistry;

lib/internal/Magento/Framework/DB/Helper/AbstractHelper.php

@@ -1,12 +1,13 @@
 <?php
 /**
- * Abstract DB helper class
- *
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
 namespace Magento\Framework\DB\Helper;
 
+/**
+ * Abstract DB helper class.
+ */
 abstract class AbstractHelper
 {
     /**
@@ -100,6 +101,7 @@ public function escapeLikeValue($value, $options = [])
 
     /**
      * Escapes, quotes and adds escape symbol to LIKE expression.
+     *
      * For options and escaping see escapeLikeValue().
      *
      * @param string $value
@@ -112,6 +114,7 @@ abstract public function addLikeEscape($value, $options = []);
 
     /**
      * Returns case insensitive LIKE construction.
+     *
      * For options and escaping see escapeLikeValue().
      *
      * @param string $field

lib/internal/Magento/Framework/Filter/StripTags.php

@@ -27,7 +27,7 @@ class StripTags implements \Zend_Filter_Interface
 
     /**
      * @param \Magento\Framework\Escaper $escaper
-     * @param null $allowableTags
+     * @param string|null $allowableTags
      * @param bool $escape
      */
     public function __construct(\Magento\Framework\Escaper $escaper, $allowableTags = null, $escape = false)
@@ -45,7 +45,7 @@ public function __construct(\Magento\Framework\Escaper $escaper, $allowableTags
      */
     public function filter($value)
     {
-        $result = is_string($value) ? strip_tags($value, $this->allowableTags) : '';
+        $result = $value !== null ? strip_tags($value, $this->allowableTags) : '';
 
         return $this->escape ? $this->escaper->escapeHtml($result, $this->allowableTags) : $result;
     }

lib/internal/Magento/Framework/Image/Adapter/Gd2.php

@@ -17,8 +17,6 @@
 class Gd2 extends AbstractAdapter
 {
     /**
-     * Required extensions
-     *
      * @var array
      */
     protected $_requiredExtensions = ["gd"];
@@ -270,6 +268,7 @@ private function _getCallback($callbackType, $fileType = null, $unsupportedText
      * @return void
      * @throws \InvalidArgumentException
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     private function _fillBackgroundColor(&$imageResourceTo)
     {
@@ -476,6 +475,7 @@ public function watermark($imagePath, $positionX = 0, $positionY = 0, $opacity =
      * @return false|resource
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     private function createWatermarkBasedOnPosition(
         $watermark,