ENGCOM-7216: magento/magento2#: GraphQl. Remove a redundant logic in “SetShippingMethodsOnCart” mutation resolver #27349

magento-engcom-team · magento-engcom-team · commit c81648df6db8 · 2020-06-22T14:51:27.000-05:00
- Merge Pull Request #27349 from atwixfirster/magento2:graphql-SetShippingMethodsOnCart-remove-redundant-logic - Merged commits: 1. baa17d7 2. e5721c1 3. bc5cd19 4. 6ad7552 5. 58e7441 6. 1f5efdf
diff --git a/app/code/Magento/QuoteGraphQl/Model/Cart/SetShippingMethodsOnCart.php b/app/code/Magento/QuoteGraphQl/Model/Cart/SetShippingMethodsOnCart.php
@@ -42,12 +42,12 @@ public function execute(ContextInterface $context, CartInterface $cart, array $s
         }
         $shippingMethodInput = current($shippingMethodsInput);
 
-        if (!isset($shippingMethodInput['carrier_code']) || empty($shippingMethodInput['carrier_code'])) {
+        if (empty($shippingMethodInput['carrier_code'])) {
             throw new GraphQlInputException(__('Required parameter "carrier_code" is missing.'));
         }
         $carrierCode = $shippingMethodInput['carrier_code'];
 
-        if (!isset($shippingMethodInput['method_code']) || empty($shippingMethodInput['method_code'])) {
+        if (empty($shippingMethodInput['method_code'])) {
             throw new GraphQlInputException(__('Required parameter "method_code" is missing.'));
         }
         $methodCode = $shippingMethodInput['method_code'];

Original file line number	Diff line number	Diff line change
`@@ -42,12 +42,12 @@ public function execute(ContextInterface $context, CartInterface $cart, array $s`
`42`	`42`	`}`
`43`	`43`	`$shippingMethodInput = current($shippingMethodsInput);`
`44`	`44`
`45`		`- if (!isset($shippingMethodInput['carrier_code']) \|\| empty($shippingMethodInput['carrier_code'])) {`
	`45`	`+ if (empty($shippingMethodInput['carrier_code'])) {`
`46`	`46`	`throw new GraphQlInputException(__('Required parameter "carrier_code" is missing.'));`
`47`	`47`	`}`
`48`	`48`	`$carrierCode = $shippingMethodInput['carrier_code'];`
`49`	`49`
`50`		`- if (!isset($shippingMethodInput['method_code']) \|\| empty($shippingMethodInput['method_code'])) {`
	`50`	`+ if (empty($shippingMethodInput['method_code'])) {`
`51`	`51`	`throw new GraphQlInputException(__('Required parameter "method_code" is missing.'));`
`52`	`52`	`}`
`53`	`53`	`$methodCode = $shippingMethodInput['method_code'];`