ACP2E-1001: Customer Zip Code input validation rule not working

- Fixing build failures.

Author: Mohan Ahuja

app/code/Magento/Customer/Model/Metadata/Form/Postcode.php

@@ -6,9 +6,7 @@
 namespace Magento\Customer\Model\Metadata\Form;
 
 use Magento\Customer\Api\Data\AttributeMetadataInterface;
-use Magento\Customer\Model\Metadata\ElementFactory;
 use Magento\Directory\Helper\Data as DirectoryHelper;
-use Magento\Framework\Api\ArrayObjectSearch;
 use Magento\Framework\Stdlib\StringUtils;
 use Magento\Framework\Locale\ResolverInterface;
 use Psr\Log\LoggerInterface as PsrLogger;
@@ -17,12 +15,12 @@
 /**
  * Customer Address Postal/Zip Code Attribute Data Model
  */
-class Postcode extends AbstractData
+class Postcode extends Text
 {
     /**
      * @var DirectoryHelper
      */
-    protected $directoryHelper;
+    protected DirectoryHelper $directoryHelper;
 
     /**
      * @var StringUtils
@@ -52,7 +50,7 @@ public function __construct(
         StringUtils $stringHelper = null
     ) {
         $this->directoryHelper = $directoryHelper;
-        if (is_null($stringHelper)) {
+        if ($stringHelper === null) {
             $stringHelper = \Magento\Framework\App\ObjectManager::getInstance()->get(StringUtils::class);
         }
         $this->_string = $stringHelper;
@@ -63,7 +61,8 @@ public function __construct(
             $localeResolver,
             $value,
             $entityTypeCode,
-            $isAjax
+            $isAjax,
+            $stringHelper
         );
     }
 
@@ -102,74 +101,4 @@ public function validateValue($value)
         }
         return $errors;
     }
-
-    /**
-     * @inheritdoc
-     */
-    public function extractValue(\Magento\Framework\App\RequestInterface $request)
-    {
-        return $this->_applyInputFilter($this->_getRequestValue($request));
-    }
-
-    /**
-     * @inheritdoc
-     */
-    public function compactValue($value)
-    {
-        return $value;
-    }
-
-    /**
-     * @inheritdoc
-     */
-    public function restoreValue($value)
-    {
-        return $this->compactValue($value);
-    }
-
-    /**
-     * @inheritdoc
-     */
-    public function outputValue($format = ElementFactory::OUTPUT_FORMAT_TEXT)
-    {
-        return $this->_applyOutputFilter($this->_value);
-    }
-
-    /**
-     * Length validation
-     *
-     * @param mixed $value
-     * @param AttributeMetadataInterface $attribute
-     * @param array $errors
-     * @return array
-     */
-    private function validateLength($value, AttributeMetadataInterface $attribute, array $errors): array
-    {
-        // validate length
-        $label = __($attribute->getStoreLabel());
-
-        $length = $value ? $this->_string->strlen(trim($value)) : 0;
-
-        $validateRules = $attribute->getValidationRules();
-
-        if (!empty(ArrayObjectSearch::getArrayElementByName($validateRules, 'input_validation'))) {
-            $minTextLength = ArrayObjectSearch::getArrayElementByName(
-                $validateRules,
-                'min_text_length'
-            );
-            if ($minTextLength !== null && $length < $minTextLength) {
-                $errors[] = __('"%1" length must be equal or greater than %2 characters.', $label, $minTextLength);
-            }
-
-            $maxTextLength = ArrayObjectSearch::getArrayElementByName(
-                $validateRules,
-                'max_text_length'
-            );
-            if ($maxTextLength !== null && $length > $maxTextLength) {
-                $errors[] = __('"%1" length must be equal or less than %2 characters.', $label, $maxTextLength);
-            }
-        }
-
-        return $errors;
-    }
 }

app/code/Magento/Customer/Model/Metadata/Form/Text.php

@@ -119,7 +119,7 @@ public function outputValue($format = \Magento\Customer\Model\Metadata\ElementFa
      * @param array $errors
      * @return array
      */
-    private function validateLength($value, AttributeMetadataInterface $attribute, array $errors): array
+    protected function validateLength($value, AttributeMetadataInterface $attribute, array $errors): array
     {
         // validate length
         $label = __($attribute->getStoreLabel());

app/code/Magento/Customer/Test/Unit/Model/Metadata/Form/PostcodeTest.php

@@ -58,7 +58,7 @@ protected function getClass($value)
     public function testValidateValue($value, $expected, $countryId, $isOptional)
     {
         $storeLabel = 'Zip/Postal Code';
-        $this->attributeMetadataMock->expects($this->once())
+        $this->attributeMetadataMock->expects($this->exactly(2))
             ->method('getStoreLabel')
             ->willReturn($storeLabel);