Skip to content

Commit c64c467

Browse files
sandesh-assandesh-as
committed
AC-15461: Migration New Relic from REST v2 to NerdGraph (GraphQL)
1 parent f2a4917 commit c64c467

File tree

5 files changed

+28
-28
lines changed

5 files changed

+28
-28
lines changed

‎app/code/Magento/NewRelicReporting/Console/Command/DeployMarker.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ protected function configure()
6565
'Deploy Message / Description'
6666
)
6767
->addArgument(
68-
'change_log',
68+
'changelog',
6969
InputArgument::OPTIONAL,
7070
'Change Log?'
7171
)
@@ -112,7 +112,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
112112
try {
113113
$result = $this->deploymentsFactory->create()->setDeployment(
114114
$input->getArgument('message'),
115-
$input->getArgument('change_log') ?: false,
115+
$input->getArgument('changelog') ?: false,
116116
$this->serviceShellUser->get($input->getArgument('user')) ?: false,
117117
$input->getArgument('revision'),
118118
$input->getOption('commit'),
@@ -174,8 +174,8 @@ private function displayDeploymentDetails(OutputInterface $output, array $deploy
174174
) : 'N/A']
175175
];
176176

177-
if (!empty($deployment['change_log'])) {
178-
$rows[] = ['Change log', $deployment['change_log']];
177+
if (!empty($deployment['changelog'])) {
178+
$rows[] = ['Change log', $deployment['changelog']];
179179
}
180180
if (!empty($deployment['commit'])) {
181181
$rows[] = ['Commit', $deployment['commit']];

‎app/code/Magento/NewRelicReporting/Model/NerdGraph/DeploymentTracker.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ private function processDeploymentResponse(
277277
'entityGuid' => $deploymentData['entityGuid'],
278278
'version' => $deployedVersion,
279279
'description' => $description,
280-
'change_log' => $change,
280+
'changelog' => $change,
281281
'user' => $user,
282282
'commit' => $commit,
283283
'deepLink' => $deepLink,

‎app/code/Magento/NewRelicReporting/Test/Unit/Console/Command/DeployMarkerTest.php‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ public function testConfigure()
103103
$this->assertTrue($definition->getArgument('message')->isRequired());
104104

105105
// Check optional arguments
106-
$this->assertTrue($definition->hasArgument('change_log'));
107-
$this->assertFalse($definition->getArgument('change_log')->isRequired());
106+
$this->assertTrue($definition->hasArgument('changelog'));
107+
$this->assertFalse($definition->getArgument('changelog')->isRequired());
108108

109109
$this->assertTrue($definition->hasArgument('user'));
110110
$this->assertFalse($definition->getArgument('user')->isRequired());
@@ -137,7 +137,7 @@ public function testExecuteSuccessWithStringResult()
137137

138138
$this->mockArguments([
139139
['message', $message],
140-
['change_log', null],
140+
['changelog', null],
141141
['user', $user],
142142
['revision', $revision]
143143
], [
@@ -181,7 +181,7 @@ public function testExecuteSuccessWithArrayResultNerdGraphStyle()
181181
'description' => $message,
182182
'user' => $user,
183183
'timestamp' => 1234567890000, // Feb 13, 2009 23:31:30 UTC
184-
'change_log' => 'New features',
184+
'changelog' => 'New features',
185185
'commit' => $commit,
186186
'deepLink' => $deepLink,
187187
'groupId' => $groupId
@@ -194,7 +194,7 @@ public function testExecuteSuccessWithArrayResultNerdGraphStyle()
194194

195195
$this->mockArguments([
196196
['message', $message],
197-
['change_log', 'New features'],
197+
['changelog', 'New features'],
198198
['user', $user],
199199
['revision', $revision]
200200
], [
@@ -240,7 +240,7 @@ public function testExecuteSuccessWithMinimalParameters()
240240

241241
$this->mockArguments([
242242
['message', $message],
243-
['change_log', null],
243+
['changelog', null],
244244
['user', null],
245245
['revision', null]
246246
], [
@@ -278,7 +278,7 @@ public function testExecuteFailureWithFalseReturn()
278278

279279
$this->mockArguments([
280280
['message', $message],
281-
['change_log', null],
281+
['changelog', null],
282282
['user', null],
283283
['revision', null]
284284
], [
@@ -312,7 +312,7 @@ public function testExecuteWithLocalizedException()
312312

313313
$this->mockArguments([
314314
['message', $message],
315-
['change_log', null],
315+
['changelog', null],
316316
['user', null],
317317
['revision', null]
318318
], [
@@ -352,7 +352,7 @@ public function testExecuteWithGenericException()
352352

353353
$this->mockArguments([
354354
['message', $message],
355-
['change_log', null],
355+
['changelog', null],
356356
['user', null],
357357
['revision', null]
358358
], [
@@ -399,7 +399,7 @@ public function testExecuteSuccessWithPartialDeploymentDataV2RestStyle()
399399

400400
$this->mockArguments([
401401
['message', $message],
402-
['change_log', null],
402+
['changelog', null],
403403
['user', null],
404404
['revision', 'v1.0.0']
405405
], [
@@ -431,7 +431,7 @@ public function testExecuteSuccessWithPartialDeploymentDataV2RestStyle()
431431
$this->assertMatchesRegularExpression('/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $outputContent);
432432

433433
// Should show N/A for missing optional fields
434-
$excludedFields = ['Change log', 'Commit', 'Deep Link', 'Group ID'];
434+
$excludedFields = ['Changelog', 'Commit', 'Deep Link', 'Group ID'];
435435
foreach ($excludedFields as $field) {
436436
$this->assertStringNotContainsString($field, $outputContent);
437437
}
@@ -452,7 +452,7 @@ public function testExecuteSuccessWithCompleteDeploymentDataNerdGraphStyle()
452452
'description' => $message,
453453
'user' => 'complete-user',
454454
'timestamp' => 1640995200000, // 2022-01-01 00:00:00 UTC
455-
'change_log' => 'Added new features',
455+
'changelog' => 'Added new features',
456456
'commit' => 'abc123def456',
457457
'deepLink' => 'https://github.com/test/releases/v2.0.0',
458458
'groupId' => 'production'
@@ -465,7 +465,7 @@ public function testExecuteSuccessWithCompleteDeploymentDataNerdGraphStyle()
465465

466466
$this->mockArguments([
467467
['message', $message],
468-
['change_log', 'Added new features'],
468+
['changelog', 'Added new features'],
469469
['user', 'complete-user'],
470470
['revision', 'v2.0.0']
471471
], [
@@ -539,7 +539,7 @@ public function testExecuteSuccessWithNullTimestamp()
539539

540540
$this->mockArguments([
541541
['message', $message],
542-
['change_log', null],
542+
['changelog', null],
543543
['user', null],
544544
['revision', 'v1.0.0']
545545
], [
@@ -587,7 +587,7 @@ public function testCommandArgumentValidation()
587587
$this->assertEquals('Deploy Message / Description', $messageArg->getDescription());
588588

589589
// Verify optional arguments exist
590-
$this->assertTrue($definition->hasArgument('change_log'));
590+
$this->assertTrue($definition->hasArgument('changelog'));
591591
$this->assertTrue($definition->hasArgument('user'));
592592
$this->assertTrue($definition->hasArgument('revision'));
593593

@@ -611,7 +611,7 @@ public function testExecuteWithEmptyMessage()
611611

612612
$this->mockArguments([
613613
['message', $message],
614-
['change_log', null],
614+
['changelog', null],
615615
['user', null],
616616
['revision', null]
617617
], [
@@ -655,7 +655,7 @@ public function testExecuteWithDisabledNewRelic()
655655

656656
$this->mockArguments([
657657
['message', $message],
658-
['change_log', null],
658+
['changelog', null],
659659
['user', null],
660660
['revision', null]
661661
], [

‎app/code/Magento/NewRelicReporting/Test/Unit/Model/NerdGraph/DeploymentTrackerTest.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public function testCreateDeploymentSuccess()
8686
'version' => $version,
8787
'description' => $description,
8888
'user' => $user,
89-
'change_log' => $change,
89+
'changelog' => $change,
9090
'commit' => $commit,
9191
'deepLink' => $deepLink,
9292
'groupId' => $groupId
@@ -140,7 +140,7 @@ public function testCreateDeploymentSuccess()
140140
$this->assertEquals($entityGuid, $result['entityGuid']);
141141
$this->assertEquals($version, $result['version']);
142142
$this->assertEquals($description, $result['description']);
143-
$this->assertEquals($change, $result['change_log']);
143+
$this->assertEquals($change, $result['changelog']);
144144
$this->assertEquals($user, $result['user']);
145145
$this->assertEquals($commit, $result['commit']);
146146
$this->assertEquals($deepLink, $result['deepLink']);
@@ -180,7 +180,7 @@ public function testCreateDeploymentWithMinimalParameters()
180180
return isset($variables['deployment']) &&
181181
$variables['deployment']['entityGuid'] === $entityGuid &&
182182
$variables['deployment']['description'] === $description &&
183-
!isset($variables['deployment']['change_log']) &&
183+
!isset($variables['deployment']['changelog']) &&
184184
!isset($variables['deployment']['user']);
185185
})
186186
)
@@ -542,7 +542,7 @@ public function testCreateDeploymentWithLongParameters()
542542
'entityGuid' => $entityGuid,
543543
'timestamp' => 1234567890000,
544544
'description' => $description,
545-
'change_log' => $change,
545+
'changelog' => $change,
546546
'user' => $user
547547
]
548548
]

‎dev/tests/integration/testsuite/Magento/NewRelicReporting/Console/Command/DeployMarkerCommandTest.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ public function testCommandConfiguration()
149149
$this->assertTrue($messageArg->isRequired());
150150

151151
// Verify optional arguments
152-
$this->assertTrue($definition->hasArgument('change_log'));
152+
$this->assertTrue($definition->hasArgument('changelog'));
153153
$this->assertTrue($definition->hasArgument('user'));
154154
$this->assertTrue($definition->hasArgument('revision'));
155155

@@ -174,7 +174,7 @@ public function testCommandWithAllParametersNerdGraph()
174174

175175
$exitCode = $this->commandTester->execute([
176176
'message' => 'Full deployment test',
177-
'change_log' => 'Added new features',
177+
'changelog' => 'Added new features',
178178
'user' => 'deploy-user',
179179
'revision' => 'v2.0.0',
180180
'--commit' => 'abc123',

0 commit comments

Comments
 (0)