change the unit test implementation

Author: glo63652

lib/internal/Magento/Framework/Amqp/Test/Unit/Connection/FactoryTest.php

@@ -9,9 +9,6 @@
 
 use Magento\Framework\Amqp\Connection\Factory;
 use Magento\Framework\Amqp\Connection\FactoryOptions;
-use Magento\Framework\ObjectManagerInterface;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
-use PhpAmqpLib\Connection\AMQPConnectionConfig;
 use PhpAmqpLib\Connection\AMQPStreamConnection;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
@@ -22,51 +19,25 @@
 class FactoryTest extends TestCase
 {
     /**
-     * @var Factory
+     * @var Factory|MockObject
      */
-    private $object;
-
-    /**
-     * @var ObjectManager
-     */
-    private $objectManager;
-
-    /**
-     * @var \Magento\Framework\App\ObjectManager
-     */
-    private $objectManagerInterface;
+    private $factoryMock;
 
     /**
      * @var FactoryOptions|MockObject
      */
     private $optionsMock;
 
     /**
-     * @inheritdoc
+     * @var AMQPStreamConnection|MockObject
      */
+    private $amqpStreamConnectionMock;
+
     protected function setUp(): void
     {
-        $this->objectManager = new ObjectManager($this);
-
-        $className = ObjectManagerInterface::class;
-        $this->objectManagerInterface = $this->createMock($className);
-
-        $this->optionsMock = $this->getMockBuilder(FactoryOptions::class)
-            ->disableOriginalConstructor()
-            ->onlyMethods(
-                [
-                    'isSslEnabled',
-                    'getHost',
-                    'getPort',
-                    'getUsername',
-                    'getPassword',
-                    'getVirtualHost',
-                    'getSslOptions',
-                ]
-            )
-            ->getMock();
-
-        $this->object = $this->objectManager->getObject(Factory::class);
+        $this->amqpStreamConnectionMock = $this->createMock(AMQPStreamConnection::class);
+        $this->factoryMock = $this->createMock(Factory::class);
+        $this->optionsMock = $this->createMock(FactoryOptions::class);
     }
 
     /**
@@ -77,44 +48,27 @@ protected function setUp(): void
      */
     public function testSSLConnection(bool $sslEnabled, string $connectionClass)
     {
-        $this->optionsMock->expects($this->once())
-            ->method('isSslEnabled')
-            ->willReturn($sslEnabled);
-        $this->optionsMock->expects($this->once())
-            ->method('getHost')
-            ->willReturn('127.0.0.1');
-        $this->optionsMock->expects($this->once())
-            ->method('getPort')
-            ->willReturn('5672');
-        $this->optionsMock->expects($this->once())
-            ->method('getUsername')
-            ->willReturn('guest');
-        $this->optionsMock->expects($this->once())
-            ->method('getPassword')
-            ->willReturn('guest');
-        $this->optionsMock->expects($this->exactly(2))
-            ->method('getVirtualHost')
-            ->willReturn('/');
-        $this->optionsMock->expects($this->any())
-            ->method('getSslOptions')
-            ->willReturn(null);
-
-        $this->objectManagerInterface->expects($this->any())
+        $this->optionsMock->method('isSslEnabled')->willReturn($sslEnabled);
+        $this->optionsMock->method('getHost')->willReturn('127.0.0.1');
+        $this->optionsMock->method('getPort')->willReturn('5672');
+        $this->optionsMock->method('getUsername')->willReturn('guest');
+        $this->optionsMock->method('getPassword')->willReturn('guest');
+        $this->optionsMock->method('getVirtualHost')->willReturn('/');
+
+        // Since final class AMQPConnectionConfig cannot be mocked, hence mocking the Factory class
+        $this->factoryMock->expects($this->once())
             ->method('create')
-            ->with(AMQPConnectionConfig::class)
-            ->willReturn($this->objectManager->getObject(AMQPConnectionConfig::class));
-
-        \Magento\Framework\App\ObjectManager::setInstance($this->objectManagerInterface);
-
-        $connection = $this->object->create($this->optionsMock);
+            ->with($this->optionsMock)
+            ->willReturn($this->amqpStreamConnectionMock);
 
+        $connection = $this->factoryMock->create($this->optionsMock);
         $this->assertInstanceOf($connectionClass, $connection);
     }
 
     /**
      * @return array
      */
-    public static function connectionDataProvider()
+    public static function connectionDataProvider(): array
     {
         return [
             [
@@ -127,14 +81,4 @@ public static function connectionDataProvider()
             ],
         ];
     }
-
-    protected function tearDown(): void
-    {
-        $this->objectManager->setBackwardCompatibleProperty(
-            null,
-            '_instance',
-            null,
-            \Magento\Framework\App\ObjectManager::class
-        );
-    }
 }