ACP2E-1709: error during declarative schema whitelsit generation

Author: pradeep1819

app/code/Magento/Developer/Model/Setup/Declaration/Schema/WhitelistGenerator.php

@@ -17,7 +17,6 @@
 use Magento\Framework\Setup\Declaration\Schema\Declaration\TableElement\ElementNameResolver;
 use Magento\Framework\Setup\Declaration\Schema\Diff\Diff;
 use Magento\Framework\Setup\Declaration\Schema\Dto\Schema;
-use Magento\Framework\Setup\Declaration\Schema\Dto\Table;
 use Magento\Framework\Setup\Declaration\Schema\SchemaConfig;
 use Magento\Framework\Setup\JsonPersistor;
 
@@ -137,7 +136,9 @@ private function persistModule(Schema $schema, string $moduleName)
             . Diff::GENERATED_WHITELIST_FILE_NAME;
 
         //We need to load whitelist file and update it with new revision of code.
+        // phpcs:disable Magento2.Functions.DiscouragedFunction
         if (file_exists($whiteListFileName)) {
+            // phpcs:disable Magento2.Functions.DiscouragedFunction
             $content = json_decode(file_get_contents($whiteListFileName), true);
         }
 
@@ -193,19 +194,16 @@ private function getElementsWithAutogeneratedName(Schema $schema, string $tableN
         $elementType = 'index';
         if (!empty($tableData[$elementType])) {
             foreach ($tableData[$elementType] as $tableElementData) {
-                if (!isset($tableElementData['column'])) {
-                    continue;
-                }
                 $indexName = $this->elementNameResolver->getFullIndexName(
                     $table,
-                    $tableElementData['column'],
+                    $tableElementData['column'] ?? [],
                     $tableElementData['indexType'] ?? null
                 );
                 $declaredStructure[$elementType][$indexName] = true;
             }
         }
 
-        $constraintName = $this->getConstraintName($schema, $table, $tableData);
+        $constraintName = $this->getConstraintName($schema, $tableName, $tableData);
         if ($constraintName) {
             $declaredStructure += $constraintName;
         }
@@ -214,22 +212,22 @@ private function getElementsWithAutogeneratedName(Schema $schema, string $tableN
     }
 
     /**
+     * Provide autogenerated names of the table constraint.
+     *
      * @param Schema $schema
-     * @param Table $table
+     * @param string $tableName
      * @param array $tableData
      * @return array
      */
-    private function getConstraintName(Schema $schema, Table $table, array $tableData): array
+    private function getConstraintName(Schema $schema, string $tableName, array $tableData): array
     {
         $declaredStructure = [];
+        $table = $schema->getTableByName($tableName);
 
         $elementType = 'constraint';
         if (!empty($tableData[$elementType])) {
             foreach ($tableData[$elementType] as $tableElementData) {
-                if (!isset($tableElementData['referenceTable'])) {
-                    continue;
-                }
-                if ($tableElementData['type'] === 'foreign') {
+                if ($tableElementData['type'] === 'foreign' && isset($tableElementData['referenceTable'])) {
                     $referenceTable = $schema->getTableByName($tableElementData['referenceTable']);
                     $column = $table->getColumnByName($tableElementData['column']);
                     $referenceColumn = $referenceTable->getColumnByName($tableElementData['referenceColumn']);
@@ -241,12 +239,9 @@ private function getConstraintName(Schema $schema, Table $table, array $tableDat
                             $referenceColumn
                         ) : null;
                 } else {
-                    if (!isset($tableElementData['column'])) {
-                        continue;
-                    }
                     $constraintName = $this->elementNameResolver->getFullIndexName(
                         $table,
-                        $tableElementData['column'],
+                        $tableElementData['column'] ?? [],
                         $tableElementData['type']
                     );
                 }