Skip to content

Commit c14b15a

Browse files
shashikant.kumarshashikant.kumar
shashikant.kumar
authored and
shashikant.kumar
committed
AC-4948:- worked on review comment
1 parent 7d2ba43 commit c14b15a

File tree

4 files changed

+15
-82
lines changed

4 files changed

+15
-82
lines changed

‎app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminOpenCreateNewWidgetsOfCMSStaticBlockActionGroup.xml‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,22 +29,22 @@
2929
<waitForPageLoad stepKey="waitForAddLayoutTabToLoad"/>
3030
<selectOption selector="{{CmsNewWidgetUpdateLayoutSection.DisplayOn}}" userInput="{{WidgetDisplayOn}}" stepKey="selectDisplay"/>
3131
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskDisappear3" />
32-
<selectOption selector="//input[@id='specific_anchor_categories_0']" userInput="Specific Categories" stepKey="selectSpecificCategoryRadioButton"/>
33-
<click selector="//*[@id='anchor_categories_ids_0']/p/a[1]/img" stepKey="clickCategoryChooserButton"/>
32+
<selectOption selector="{{CmsNewWidgetUpdateLayoutSection.SpecificCategories}}" userInput="Specific Categories" stepKey="selectSpecificCategoryRadioButton"/>
33+
<click selector="{{CmsNewWidgetUpdateLayoutSection.CategoryChooserButton}}" stepKey="clickCategoryChooserButton"/>
3434
<waitForPageLoad stepKey="waitForRootCategoryToLoad"/>
35-
<click selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" stepKey="clickRootCat"/>
35+
<click selector="{{CmsNewWidgetUpdateLayoutSection.RootCat}}" stepKey="clickRootCat"/>
3636
<waitForPageLoad stepKey="waitForRootCategoryToExpand"/>
37-
<click selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" stepKey="clickFirstSubCat"/>
37+
<click selector="{{CmsNewWidgetUpdateLayoutSection.FirstSubCat}}" stepKey="clickFirstSubCat"/>
3838
<waitForPageLoad stepKey="waitForFirstSubCatToExpand"/>
39-
<click selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" stepKey="expandSecondSubCat"/>
39+
<click selector="{{CmsNewWidgetUpdateLayoutSection.SecondSubCat}}" stepKey="expandSecondSubCat"/>
4040
<waitForPageLoad stepKey="waitForSecondSubCatToExpand"/>
41-
<click selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" stepKey="expandThirdFirstSubCat"/>
41+
<click selector="{{CmsNewWidgetUpdateLayoutSection.ThirdSubCat}}" stepKey="expandThirdFirstSubCat"/>
4242
<waitForPageLoad stepKey="waitForThirdSubCatToExpand"/>
43-
<click selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" stepKey="expandFourthSubCat"/>
43+
<click selector="{{CmsNewWidgetUpdateLayoutSection.FourthSubCat}}" stepKey="expandFourthSubCat"/>
4444
<waitForPageLoad stepKey="waitForFourthSubCatToExpand"/>
45-
<click selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" stepKey="expandFifthSubCat"/>
45+
<click selector="{{CmsNewWidgetUpdateLayoutSection.FifthSubCat}}" stepKey="expandFifthSubCat"/>
4646
<waitForPageLoad stepKey="waitForFifthSubCatToExpand"/>
47-
<grabMultiple selector="//*[@class='x-tree-ec-icon x-tree-elbow-end-minus' or @class='x-tree-ec-icon x-tree-elbow-end']" stepKey="countNestedCategory"/>
47+
<grabMultiple selector="{{CmsNewWidgetUpdateLayoutSection.CountAllNestedCat}}" stepKey="countNestedCategory"/>
4848
<assertCount stepKey="check">
4949
<expectedResult type="int">7</expectedResult>
5050
<actualResult type="variable">countNestedCategory</actualResult>

‎app/code/Magento/Catalog/Test/Mftf/Test/AdminValidateAllNestedCategoryInWidget.xml‎

Lines changed: 0 additions & 61 deletions
This file was deleted.

‎app/code/Magento/Catalog/Test/Mftf/Test/AdminValidateAllNestedCategoryInWidgetTest.xml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,6 @@
5555
<argument name="WidgetType" value="CMS Static Block"/>
5656
<argument name="WidgetTheme" value="Magento Luma"/>
5757
<argument name="WidgetDisplayOn" value="Anchor Categories"/>
58-
<argument name="RootCat" value="Default Category"/>
59-
<argument name="FirstSubCat" value="$createDefaultCategory.name$"/>
60-
<argument name="SecondSubCat" value="$createTwoLevelNestedCategories.name$"/>
61-
<argument name="ThirdSubCat" value="$createThreeLevelNestedCategories.name$"/>
62-
<argument name="FourthSubCat" value="$createFourLevelNestedCategories.name$"/>
63-
<argument name="FifthSubCat" value="$createFiveLevelNestedCategories.name$"/>
6458
</actionGroup>
6559
</test>
6660
</tests>

‎app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection/CmsNewWidgetUpdateLayoutSection.xml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414
<element name="Template" type="button" selector="#all_pages_0 > table > tbody > tr > td:nth-child(2) > div > div > select"/>
1515
<element name="SpecificCategories" type="button" selector="//input[@id='specific_anchor_categories_0']"/>
1616
<element name="CategoryChooserButton" type="button" selector="//*[@id='anchor_categories_ids_0']/p/a[1]/img"/>
17-
<element name="RootCat" type="button" selector="//a/span[contains(text(),'{{var}}')]/../..//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" parameterized="true"/>
18-
<element name="FirstSubCat" type="button" selector="//a/span[contains(text(),'{{var1}}')]/../..//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" parameterized="true"/>
19-
<element name="SecondSubCat" type="button" selector="//a/span[contains(text(),'{{var2}}')]/../..//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" parameterized="true"/>
20-
<element name="ThirdSubCat" type="button" selector="//a/span[contains(text(),'{{var3}}')]/../..//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" parameterized="true"/>
21-
<element name="FourthSubCat" type="button" selector="//a/span[contains(text(),'{{var4}}')]/../..//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" parameterized="true"/>
22-
<element name="FifthSubCat" type="button" selector="//a/span[contains(text(),'{{var5}}')]/../..//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" parameterized="true"/>
17+
<element name="RootCat" type="button" selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']"/>
18+
<element name="FirstSubCat" type="button" selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']"/>
19+
<element name="SecondSubCat" type="button" selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']"/>
20+
<element name="ThirdSubCat" type="button" selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']"/>
21+
<element name="FourthSubCat" type="button" selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']"/>
22+
<element name="FifthSubCat" type="button" selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']"/>
2323
<element name="CountAllNestedCat" type="button" selector="//*[@class='x-tree-ec-icon x-tree-elbow-end-minus' or @class='x-tree-ec-icon x-tree-elbow-end']"/>
2424
</section>
2525
</sections>

0 commit comments

Comments
 (0)