ACP2E-2037: allow diacritics validation only for email address

Author: alzota

app/code/Magento/Customer/etc/di.xml

@@ -588,7 +588,7 @@
     </type>
     <type name="Magento\Eav\Model\Attribute\Data\Text">
         <arguments>
-            <argument name="encodeAttributesByTypesList" xsi:type="array">
+            <argument name="allowDiacriticsForAttributes" xsi:type="array">
                 <item name="customer" xsi:type="array">
                     <item name="email" xsi:type="string">email</item>
                 </item>

app/code/Magento/Eav/Model/Attribute/Data/Text.php

@@ -27,26 +27,26 @@ class Text extends \Magento\Eav\Model\Attribute\Data\AbstractData
     /**
      * @var array
      */
-    private $encodeAttributesByTypesList;
+    private $allowDiacriticsForAttributes;
 
     /**
      * @param TimezoneInterface $localeDate
      * @param LoggerInterface $logger
      * @param ResolverInterface $localeResolver
      * @param StringUtils $stringHelper
-     * @param array $encodeAttributesByTypesList
+     * @param array $allowDiacriticsForAttributes
      * @codeCoverageIgnore
      */
     public function __construct(
         \Magento\Framework\Stdlib\DateTime\TimezoneInterface $localeDate,
         \Psr\Log\LoggerInterface $logger,
         \Magento\Framework\Locale\ResolverInterface $localeResolver,
         \Magento\Framework\Stdlib\StringUtils $stringHelper,
-        array $encodeAttributesByTypesList = []
+        array $allowDiacriticsForAttributes = []
     ) {
         parent::__construct($localeDate, $logger, $localeResolver);
         $this->_string = $stringHelper;
-        $this->encodeAttributesByTypesList = $encodeAttributesByTypesList;
+        $this->allowDiacriticsForAttributes = $allowDiacriticsForAttributes;
     }
 
     /**
@@ -91,7 +91,11 @@ public function validateValue($value)
             return $errors;
         }
 
-        if (in_array($attribute->getAttributeCode(), $this->encodeAttributesByTypesList[$attribute->getEntityType()->getEntityTypeCode()])) {
+        if (isset($this->allowDiacriticsForAttributes[$this->getAttribute()->getEntityType()->getEntityTypeCode()])
+            && in_array(
+                $this->getAttribute()->getAttributeCode(),
+                $this->allowDiacriticsForAttributes[$this->getAttribute()->getEntityType()->getEntityTypeCode()]
+            )) {
             // if string with diacritics encode it.
             $value = $this->encodeDiacritics($value);
         }