ACP2E-3189: additional unit test

Author: alzota

app/code/Magento/Sales/Test/Unit/Model/ResourceModel/Report/BestsellersTest.php

@@ -21,6 +21,8 @@
 use Magento\Sales\Model\ResourceModel\Report\Bestsellers;
 use Magento\Store\Api\Data\StoreInterface;
 use Magento\Store\Model\StoreManagerInterface;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\MockObject\Exception;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Psr\Log\LoggerInterface;
@@ -95,6 +97,24 @@ class BestsellersTest extends TestCase
      */
     protected string $connectionName = 'connection_name';
 
+    /**
+     * Data provider for testAggregateWithMultipleOrderDatesAndNoDates
+     *
+     * @return array
+     */
+    public static function datesDataProvider(): array
+    {
+        $randomDates = [];
+        for ($i = 0; $i < 10000; $i++) {
+            $randomDates[] = date('Y-m-d', rand(0, time()));
+        }
+        return [
+            'from-to interval' => [new \DateTime('yesterday'), new \DateTime(), $randomDates],
+            'from interval' => [new \DateTime('yesterday'), null, $randomDates],
+            'from interval no dates' => [new \DateTime('yesterday'), null, []]
+        ];
+    }
+
     /**
      * @inheritDoc
      */
@@ -307,16 +327,18 @@ public function testAggregatePerStoreCalculationNoInterval(): void
     }
 
     /**
+     * @param \DateTime|null $from
+     * @param \DateTime|null $to
+     * @param array $randomDates
      * @return void
-     * @throws \Exception
+     * @throws Exception
      */
-    public function testAggregateWithMultipleOrderDates(): void
-    {
-        $from = new \DateTime('yesterday');
-        $to = null;
-        for ($i = 0; $i < 10000; $i++) {
-            $randomDates[] = date('Y-m-d', rand(0, time()));
-        }
+    #[DataProvider('datesDataProvider')]
+    public function testAggregateWithMultipleOrderDatesAndNoDates(
+        ?\DateTime $from,
+        ?\DateTime $to,
+        array $randomDates
+    ): void {
         $periodExpr = 'DATE(DATE_ADD(`source_table`.`created_at`, INTERVAL -25200 SECOND))';
         $select = $this->getMockBuilder(Select::class)
             ->disableOriginalConstructor()
@@ -336,7 +358,11 @@ public function testAggregateWithMultipleOrderDates(): void
         $connection->expects($this->any())->method('select')->willReturn($select);
         $query = $this->createMock(\Zend_Db_Statement_Interface::class);
         $query->expects($this->once())->method('fetchAll')->willReturn($randomDates);
-        $connection->expects($this->exactly(4))->method('query')->willReturn($query);
+        $calls = 3;
+        if ($from && $to) {
+            $calls = 4;
+        }
+        $connection->expects($this->exactly($calls))->method('query')->willReturn($query);
         $resource = $this->createMock(ResourceConnection::class);
         $resource->expects($this->any())
             ->method('getConnection')