#34505: fixes after CR

Author: karyna-t

lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php

@@ -264,8 +264,8 @@ public function scopeTimeStamp($scope = null)
      */
     public function isScopeDateInInterval($scope, $dateFrom = null, $dateTo = null)
     {
-        $dateFrom = $dateFrom ?: '';
-        $dateTo = $dateTo ?: '';
+        $dateFrom = $dateFrom ?? '';
+        $dateTo = $dateTo ?? '';
         if (!$scope instanceof ScopeInterface) {
             $scope = $this->_scopeResolver->getScope($scope);
         }
@@ -284,6 +284,9 @@ public function isScopeDateInInterval($scope, $dateFrom = null, $dateTo = null)
 
     /**
      * @inheritdoc
+     *
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function formatDateTime(
         $date,
@@ -307,9 +310,9 @@ public function formatDateTime(
         }
 
         $formatter = $this->dateFormatterFactory->create(
-            (string) ($locale ?: $this->_localeResolver->getLocale()),
-            (int) $dateType,
-            (int) $timeType,
+            (string) $locale ?: $this->_localeResolver->getLocale(),
+            (int) $dateType ?: \IntlDateFormatter::SHORT,
+            (int) $timeType ?: \IntlDateFormatter::SHORT,
             null,
             false
         );

lib/internal/Magento/Framework/Url.php

@@ -925,9 +925,7 @@ private function createUrl($routePath = null, array $routeParams = null)
             unset($routeParams['_query']);
         }
 
-        if (isset($routeParams['_nosid'])) {
-            unset($routeParams['_nosid']);
-        }
+        unset($routeParams['_nosid']);
         $url = $this->getRouteUrl($routePath, $routeParams);
 
         /**