ACP2E-1992: Configurable on sale products not visible in products carousel

- configurable products are now visible even if their children aren't

Author: aplapana

app/code/Magento/ConfigurableProduct/Plugin/CatalogWidget/Block/Product/ProductsListPlugin.php

@@ -8,6 +8,7 @@
 
 namespace Magento\ConfigurableProduct\Plugin\CatalogWidget\Block\Product;
 
+use Magento\Catalog\Model\Product;
 use Magento\Catalog\Model\Product\Visibility;
 use Magento\Catalog\Model\ResourceModel\Product\Collection;
 use Magento\Catalog\Model\ResourceModel\Product\CollectionFactory;
@@ -68,7 +69,8 @@ public function __construct(
     public function afterCreateCollection(ProductsList $subject, Collection $result): Collection
     {
         $notVisibleCollection = $subject->getBaseCollection();
-        $searchProducts = array_merge($result->getAllIds(), $notVisibleCollection->getAllIds());
+        $currentIds = $result->getAllIds();
+        $searchProducts = array_merge($currentIds, $notVisibleCollection->getAllIds());
 
         if (!empty($searchProducts)) {
             $linkField = $this->metadataPool->getMetadata(\Magento\Catalog\Api\Data\ProductInterface::class)
@@ -90,8 +92,11 @@ public function afterCreateCollection(ProductsList $subject, Collection $result)
             $configurableProductCollection->setVisibility($this->catalogProductVisibility->getVisibleInCatalogIds());
             $configurableProductCollection->addIdFilter($productIds);
 
+            /** @var Product $item */
             foreach ($configurableProductCollection->getItems() as $item) {
-                $result->addItem($item);
+                if (false === in_array($item->getId(), $currentIds)) {
+                    $result->addItem($item);
+                }
             }
         }