🔃 [Magento Community Engineering] Community Contributions - 2.4-develop

Accepted Community Pull Requests:
 - #27237: #26749: Saving CMS Page Title from REST web API makes content empty (by @engcom-Charlie)
 - #27215: Cleanup ObjectManager usage - Magento_Translation (by @Bartlomiejsz)
 - #27191: 26827 Added improvements to product attribute repository (save method) (by @sergiy-v)
 - #27125: #27124: Update wishlist image logic to match logic on wishlist page (by @mtbottens)
 - #23191: Refactor addlinks to own class take 3 (follows #21658) (by @amenk)
 - #25734: Experius 2.3 patch catalog flat (by @lewisvoncken)
 - #27273: MFTF: Test isolation, consistent naming (backwards-compatible) (by @lbajsarowicz)
 - #26015: Remove media gallery assets metadata when a directory removed (by @rogyar)


Fixed GitHub Issues:
 - #26827: 500 when creating new product after adding attribute via API and assigning to attribute set via UI (reported by @vincentteyssier) has been fixed in #27191 by @sergiy-v in 2.4-develop branch
   Related commits:
     1. acfc589
     2. fcf734f

 - #27124: Share Wishlist Email: Image Logic Issue (reported by @mtbottens) has been fixed in #27125 by @mtbottens in 2.4-develop branch
   Related commits:
     1. 854761d
     2. 12ae6e5
     3. 76e61ae
     4. 428605d
     5. b2d0793

Author: magento-engcom-team

app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Eraser.php

@@ -99,15 +99,15 @@ public function removeDisabledProducts(array &$ids, $storeId)
             ['status_global_attr' => $statusAttribute->getBackendTable()],
             ' status_global_attr.attribute_id = ' . (int)$statusAttribute->getAttributeId()
             . ' AND status_global_attr.store_id = ' . Store::DEFAULT_STORE_ID
-            . ' AND status_global_attr.' . $statusAttribute->getEntityIdField() . '='
+            . ' AND status_global_attr.' .  $metadata->getLinkField() . '='
             . 'product_table.' . $metadata->getLinkField(),
             []
         );
         $select->joinLeft(
             ['status_attr' => $statusAttribute->getBackendTable()],
             ' status_attr.attribute_id = ' . (int)$statusAttribute->getAttributeId()
             . ' AND status_attr.store_id = ' . $storeId
-            . ' AND status_attr.' . $statusAttribute->getEntityIdField() . '='
+            . ' AND status_attr.' .  $metadata->getLinkField() . '='
             . 'product_table.' . $metadata->getLinkField(),
             []
         );

app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Rows.php

@@ -5,14 +5,14 @@
  */
 namespace Magento\Catalog\Model\Indexer\Product\Flat\Action;
 
+use Magento\Catalog\Model\Indexer\Product\Flat\AbstractAction;
 use Magento\Catalog\Model\Indexer\Product\Flat\FlatTableBuilder;
 use Magento\Catalog\Model\Indexer\Product\Flat\TableBuilder;
 
 /**
  * Class Rows reindex action for mass actions
- *
  */
-class Rows extends \Magento\Catalog\Model\Indexer\Product\Flat\AbstractAction
+class Rows extends AbstractAction
 {
     /**
      * @var Eraser
@@ -67,6 +67,7 @@ public function execute($ids)
             foreach ($idsBatches as $changedIds) {
                 if ($tableExists) {
                     $this->flatItemEraser->removeDeletedProducts($changedIds, $store->getId());
+                    $this->flatItemEraser->removeDisabledProducts($changedIds, $store->getId());
                 }
                 if (!empty($changedIds)) {
                     $this->_reindex($store->getId(), $changedIds);

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AssertAdminProductAttributeByCodeOnProductFormActionGroup.xml

@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AssertAdminProductAttributeByCodeOnProductFormActionGroup">
+        <annotations>
+            <description>Requires the navigation to the Product page. Provided dropdown attribute presents on the page.</description>
+        </annotations>
+        <arguments>
+            <argument name="productAttributeCode" type="string" defaultValue="{{textSwatchProductAttribute.attribute_code}}"/>
+        </arguments>
+
+        <seeElement selector="{{AdminProductAttributesSection.attributeDropdownByCode(productAttributeCode)}}" stepKey="assertAttributeIsPresentOnForm"/>
+    </actionGroup>
+</actionGroups>