ACP2E-2519: The coupon code count does not update in the Time Used column in the Manage Coupon Codes tab if an order is placed with multi-shipping.

Author: Chhandak.Barua

app/code/Magento/SalesRule/Plugin/CouponUsagesIncrementMultishipping.php

@@ -18,10 +18,12 @@
 
 namespace Magento\SalesRule\Plugin;
 
+use Closure;
 use Magento\Framework\Exception\NoSuchEntityException;
-use Magento\Quote\Model\QuoteRepository;
 use Magento\SalesRule\Model\Coupon\Quote\UpdateCouponUsages;
 use Magento\Multishipping\Model\Checkout\Type\Multishipping\PlaceOrderDefault;
+use Throwable;
+use Magento\Quote\Api\CartRepositoryInterface;
 
 /**
  * Increments number of coupon usages before placing order
@@ -32,37 +34,37 @@ class CouponUsagesIncrementMultishipping
     /**
      * @var UpdateCouponUsages
      */
-    private $updateCouponUsages;
+    private UpdateCouponUsages $updateCouponUsages;
 
     /**
-     * @var QuoteRepository
+     * @var CartRepositoryInterface
      */
-    private QuoteRepository $quoteRepository;
+    private CartRepositoryInterface $cartRepositoryInterface;
 
     /**
      * @param UpdateCouponUsages $updateCouponUsages
-     * @param QuoteRepository $quoteRepository
+     * @param CartRepositoryInterface $cartRepositoryInterface
      */
-    public function __construct(UpdateCouponUsages $updateCouponUsages, QuoteRepository $quoteRepository)
+    public function __construct(UpdateCouponUsages $updateCouponUsages, CartRepositoryInterface $cartRepositoryInterface)
     {
         $this->updateCouponUsages = $updateCouponUsages;
-        $this->quoteRepository = $quoteRepository;
+        $this->cartRepositoryInterface = $cartRepositoryInterface;
     }
 
     /**
      * Increments number of coupon usages before placing order
      *
      * @param PlaceOrderDefault $subject
-     * @param \Closure $proceed
+     * @param Closure $proceed
      * @param array $order
-     * @return void
-     * @throws NoSuchEntityException
+     * @return array
+     * @throws NoSuchEntityException|Throwable
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function aroundPlace(PlaceOrderDefault $subject, \Closure $proceed, array $order)
+    public function aroundPlace(PlaceOrderDefault $subject, Closure $proceed, array $order): array
     {
         $quoteId = $order[0]->getQuoteId();
-        $quote = $this->quoteRepository->get($quoteId);
+        $quote = $this->cartRepositoryInterface->get($quoteId);
         /* if coupon code has been canceled then need to notify the customer */
         if (!$quote->getCouponCode() && $quote->dataHasChangedFor('coupon_code')) {
             throw new NoSuchEntityException(__("The coupon code isn't valid. Verify the code and try again."));
@@ -71,7 +73,7 @@ public function aroundPlace(PlaceOrderDefault $subject, \Closure $proceed, array
         $this->updateCouponUsages->execute($quote, true);
         try {
             return $proceed($order);
-        } catch (\Throwable $e) {
+        } catch (Throwable $e) {
             $this->updateCouponUsages->execute($quote, false);
             throw $e;
         }