Merge pull request #437 from magento-performance/cabpi-379-fix-static-tests

CABPI-379: fix failing static-tests

Author: slopukhov

app/code/Magento/AdminAdobeIms/Console/Command/AdminAdobeImsEnableCommand.php

@@ -24,6 +24,7 @@
 
 /**
  * Command to set Admin Adobe IMS Module mode
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class AdminAdobeImsEnableCommand extends Command
 {
@@ -72,7 +73,7 @@ class AdminAdobeImsEnableCommand extends Command
      * @param ImsConnection $imsConnection
      * @param ImsCommandOptionService $imsCommandOptionService
      * @param TypeListInterface $cacheTypeList
-     * @param UpdateTokensService $cleanupTokensService
+     * @param UpdateTokensService $updateTokensService
      */
     public function __construct(
         ImsConfig $imsConfig,

app/code/Magento/AdminAdobeIms/Model/ResourceModel/User.php

@@ -36,4 +36,4 @@ public function loadByEmail(string $email): array
 
         return $result;
     }
-}
+}

app/code/Magento/AdminAdobeIms/Observer/AdminLogoutObserver.php

@@ -33,7 +33,7 @@ public function __construct(
      *
      * @param Observer $observer
      * @return $this
-     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function execute(Observer $observer)
     {

app/code/Magento/AdminAdobeIms/Plugin/AdminTokenPlugin.php

@@ -35,6 +35,7 @@ public function __construct(
      * @param string $password
      * @return string
      * @throws AuthenticationException
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function aroundCreateAdminAccessToken(AdminTokenService $subject, callable $proceed, $username, $password)
     {

app/code/Magento/AdminAdobeIms/Plugin/ResetAttemptForBackendObserverPlugin.php

@@ -28,14 +28,17 @@ public function __construct(ImsConfig $imsConfig)
     }
 
     /**
+     * Reset Login attempts for backend only if AdminAdobeIms is disabled
+     *
      * @param ResetAttemptForBackendObserver $subject
      * @param callable $proceed
      * @param Observer $observer
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function aroundExecute(ResetAttemptForBackendObserver $subject, callable $proceed, Observer $observer)
     {
         if (!$this->imsConfig->enabled()) {
             return $proceed($observer);
         }
     }
-}
+}

app/code/Magento/AdminAdobeIms/Service/UpdateTokensService.php

@@ -40,9 +40,9 @@ public function __construct(RevokedRepositoryInterface $revokedRepo, CollectionF
     /**
      * Token invalidation for the admin users
      *
-     * return @void
+     * @return void
      */
-    public function execute()
+    public function execute(): void
     {
         $adminUsers = $this->adminUserCollection->getItems();
         foreach ($adminUsers as $adminUser) {

app/code/Magento/AdminAdobeIms/Test/Unit/Command/AdminAdobeImsEnableCommandTest.php

@@ -145,7 +145,6 @@ public function testAdminAdobeImsModuleEnableWillClearCacheWhenSuccessful(
             ->with($outputMessage, null)
             ->willReturnSelf();
 
-
         $this->enableCommand->setHelperSet($this->getHelperSet());
         $this->enableCommand->run($inputMock, $outputMock);
     }

app/code/Magento/AdminAdobeIms/registration.php

@@ -1,10 +1,11 @@
 <?php
-
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
 
+declare(strict_types=1);
+
 use Magento\Framework\Component\ComponentRegistrar;
 
 ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Magento_AdminAdobeIms', __DIR__);