ACP2E-3187: Metric in NR might be misleading for background transactions- Follow up of ACP2E-3067

Author: abukatar

app/code/Magento/NewRelicReporting/Model/NewRelicWrapper.php

@@ -5,6 +5,8 @@
  */
 namespace Magento\NewRelicReporting\Model;
 
+use Magento\Framework\App\State;
+use Magento\Framework\App\ObjectManager;
 use Throwable;
 
 /**
@@ -16,6 +18,26 @@ class NewRelicWrapper
 {
     private const NEWRELIC_APPNAME = 'newrelic.appname';
 
+    /**
+     * @var Config
+     */
+    private $config;
+
+    /**
+     * @var State
+     */
+    private $state;
+
+    /**
+     * @param ?Config $config
+     * @param ?State $state
+     */
+    public function __construct(?Config $config = null, ?State $state = null)
+    {
+        $this->config = $config ?? ObjectManager::getInstance()->get(Config::class);
+        $this->state = $state ?? ObjectManager::getInstance()->get(State::class);
+    }
+
     /**
      * Wrapper for 'newrelic_add_custom_parameter' function
      *
@@ -79,7 +101,8 @@ public function setTransactionName(string $transactionName): void
     public function startBackgroundTransaction()
     {
         if ($this->isExtensionInstalled()) {
-            newrelic_start_transaction(ini_get(self::NEWRELIC_APPNAME));
+            $name = $this->getCurrentAppName();
+            newrelic_start_transaction($name);
             newrelic_background_job();
         }
     }
@@ -106,4 +129,21 @@ public function isExtensionInstalled()
     {
         return extension_loaded('newrelic');
     }
+
+    /**
+     * Get current App name for NR transactions
+     *
+     * @return string
+     */
+    public function getCurrentAppName()
+    {
+        if ($this->config->isSeparateApps() &&
+            $this->config->getNewRelicAppName() &&
+            $this->config->isNewRelicEnabled()) {
+            $code = $this->state->getAreaCode();
+            $current = $this->config->getNewRelicAppName();
+            return $current . ';' . $current . '_' . $code;
+        }
+        return ini_get(self::NEWRELIC_APPNAME);
+    }
 }

app/code/Magento/NewRelicReporting/Test/Unit/Model/NewRelicWrapperTest.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace Magento\NewRelicReporting\Test\Unit\Model;
+
+use Magento\NewRelicReporting\Model\NewRelicWrapper;
+use Magento\NewRelicReporting\Model\Config;
+use Magento\Framework\App\State;
+use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\MockObject\MockObject;
+
+class NewRelicWrapperTest extends TestCase
+{
+    /**
+     * @var Config|MockObject
+     */
+    private $config;
+
+    /**
+     * @var State|MockObject
+     */
+    private $state;
+
+    /**
+     * @var NewRelicWrapper
+     */
+    private $newRelicWrapper;
+
+    protected function setUp(): void
+    {
+        $this->config = $this->createMock(Config::class);
+        $this->state = $this->createMock(State::class);
+        $this->newRelicWrapper = new NewRelicWrapper($this->config, $this->state);
+    }
+
+    public function testGetCurrentAppName()
+    {
+        $this->config->expects($this->once())
+            ->method('isSeparateApps')
+            ->willReturn(true);
+        $this->config->expects($this->atLeastOnce())
+            ->method('getNewRelicAppName')
+            ->willReturn('Magento');
+        $this->config->expects($this->once())
+            ->method('isNewRelicEnabled')
+            ->willReturn(true);
+        $this->state->expects($this->once())
+            ->method('getAreaCode')
+            ->willReturn('cron');
+        $this->assertEquals('Magento;Magento_cron', $this->newRelicWrapper->getCurrentAppName());
+    }
+}