ACP2E-924: MSI - Inventory Compensation command is not working properly for partial shipment of the Configurable products

Author: bubasuma

app/code/Magento/Bundle/Test/Fixture/AddProductToCart.php

@@ -45,18 +45,18 @@ public function __construct(
     /**
      * {@inheritdoc}
      * @param array $data Parameters
-     * <pre>
-     *    $data = [
-     *      'cart_id'           => (int) Cart ID. Required.
-     *      'product_id'        => (int) Product ID. Required.
-     *      'selections'        => (array) array of options selections. Required.
-     *      'qty'               => (int) Quantity. Optional. Default: 1.
-     *    ]
-     * </pre>
      * $data['selections'] can be supplied in following formats:
      *      - [["$product1.id$"], ["$product2.id$"]]
      *      - [[{"product_id":"$product1.id$","qty":1}], [{"product_id":"$product2.id$","qty":1}]]
      *      - To skip an option, pass empty array [["$product1.id$"], [], ["$product2.id$"]]
+     * <pre>
+     *    $data = [
+     *      'cart_id'       => (int) Cart ID. Required.
+     *      'product_id'    => (int) Product ID. Required.
+     *      'selections'    => (array) array of options selections. Required.
+     *      'qty'           => (int) Quantity. Optional. Default: 1.
+     *    ]
+     * </pre>
      */
     public function apply(array $data = []): ?DataObject
     {
@@ -71,25 +71,25 @@ public function apply(array $data = []): ?DataObject
         $options->appendSelections($selections, true);
         $optionsList = array_values($options->getItems());
         foreach ($data['selections'] as $index => $selections) {
-           if (!empty($selections)) {
-               $option = $optionsList[$index];
-               foreach ($selections as $item) {
-                   if (is_array($item)) {
-                       $productId = (int) $item['product_id'];
-                       $qty = $item['qty'] ?? 1;
-                   } else {
-                       $productId = (int) $item;
-                       $qty = 1;
-                   }
-                   foreach ($option->getSelections() as $selection) {
-                       if (((int) $selection->getProductId()) === $productId) {
-                           $buyRequest['bundle_option'][$option->getId()][] = $selection->getSelectionId();
-                           $buyRequest['bundle_option_qty'][$option->getId()][$selection->getSelectionId()] = $qty;
-                           break;
-                       }
-                   }
-               }
-           }
+            if (!empty($selections)) {
+                $option = $optionsList[$index];
+                foreach ($selections as $item) {
+                    if (is_array($item)) {
+                        $productId = (int)$item['product_id'];
+                        $qty = $item['qty'] ?? 1;
+                    } else {
+                        $productId = (int)$item;
+                        $qty = 1;
+                    }
+                    foreach ($option->getSelections() as $selection) {
+                        if (((int)$selection->getProductId()) === $productId) {
+                            $buyRequest['bundle_option'][$option->getId()][] = $selection->getSelectionId();
+                            $buyRequest['bundle_option_qty'][$option->getId()][$selection->getSelectionId()] = $qty;
+                            break;
+                        }
+                    }
+                }
+            }
         }
         return parent::apply(
             [

app/code/Magento/ConfigurableProduct/Test/Fixture/AddProductToCart.php

@@ -49,7 +49,7 @@ public function __construct(
      *    $data = [
      *      'cart_id'           => (int) Cart ID. Required.
      *      'product_id'        => (int) Product ID. Required.
-     *      'child_product_id'  => (int) Product ID. Required.
+     *      'child_product_id'  => (int) Child Product ID. Required.
      *      'qty'               => (int) Quantity. Optional. Default: 1.
      *    ]
      * </pre>
@@ -62,8 +62,8 @@ public function apply(array $data = []): ?DataObject
             'super_attribute' => [],
             'qty' => $data['qty'] ?? 1,
         ];
-        foreach ($this->productType->getUsedProductAttributes($configurableProduct) as $attribute) {
-            $buyRequest['super_attribute'][$attribute->getId()] = $childProduct->getData($attribute->getAttributeCode());
+        foreach ($this->productType->getUsedProductAttributes($configurableProduct) as $attr) {
+            $buyRequest['super_attribute'][$attr->getId()] = $childProduct->getData($attr->getAttributeCode());
         }
         return parent::apply(
             [

app/code/Magento/GroupedProduct/Test/Fixture/AddProductToCart.php

@@ -42,10 +42,12 @@ public function __construct(
         $this->productType = $productType;
     }
 
-
     /**
      * {@inheritdoc}
      * @param array $data Parameters
+     * $data['child_products'] can be supplied in following formats:
+     *      - ["$product1.id$", "$product2.id$"]
+     *      - [{"product_id":"$product1.id$","qty":1}, {"product_id":"$product2.id$","qty":1}]
      * <pre>
      *    $data = [
      *      'cart_id'           => (int) Cart ID. Required.
@@ -54,9 +56,6 @@ public function __construct(
      *      'qty'               => (int) Quantity. Optional. Default: 1.
      *    ]
      * </pre>
-     * $data['selections'] can be supplied in following formats:
-     *      - ["$product1.id$", "$product2.id$"]
-     *      - [{"product_id":"$product1.id$","qty":1}, {"product_id":"$product2.id$","qty":1}]
      */
     public function apply(array $data = []): ?DataObject
     {