ACP2E-3432: usage_limit and uses_per_customer not updating in salesrule_coupon Table

Author: bubasuma

app/code/Magento/SalesRule/Model/ResourceModel/Rule.php

@@ -1,6 +1,6 @@
 <?php
 /**
- * Copyright 2024 Adobe
+ * Copyright 2011 Adobe
  * All Rights Reserved.
  */
 

app/code/Magento/SalesRule/Test/Unit/Model/ResourceModel/RuleTest.php

@@ -1,8 +1,9 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2015 Adobe
+ * All Rights Reserved.
  */
+
 declare(strict_types=1);
 
 namespace Magento\SalesRule\Test\Unit\Model\ResourceModel;
@@ -86,6 +87,11 @@ class RuleTest extends TestCase
      */
     private $metadataPoolMock;
 
+    /**
+     * @var \Magento\SalesRule\Model\ResourceModel\Coupon|MockObject
+     */
+    private $resourceCoupon;
+
     protected function setUp(): void
     {
         $this->objectManager = new ObjectManager($this);
@@ -169,6 +175,8 @@ protected function setUp(): void
             ->disableOriginalConstructor()
             ->getMock();
 
+        $this->resourceCoupon = $this->createMock(\Magento\SalesRule\Model\ResourceModel\Coupon::class);
+
         $this->model = $this->objectManager->getObject(
             Rule::class,
             [
@@ -177,7 +185,8 @@ protected function setUp(): void
                 'entityManager' => $this->entityManager,
                 'associatedEntityMapInstance' => $associatedEntitiesMap,
                 'serializer' => $serializerMock,
-                'metadataPool' => $this->metadataPoolMock
+                'metadataPool' => $this->metadataPoolMock,
+                'resourceCoupon' => $this->resourceCoupon
             ]
         );
     }
@@ -245,6 +254,56 @@ public function testSaveStoreLabels()
         $this->model->saveStoreLabels(1, ['test']);
     }
 
+    /**
+     * @dataProvider afterSaveShouldUpdateExistingCouponsDataProvider
+     * @param array $data
+     * @param bool $update
+     * @return void
+     * @throws \PHPUnit\Framework\MockObject\Exception
+     */
+    public function testAfterSaveShouldUpdateExistingCoupons(array $data, bool $update = true): void
+    {
+        /** @var AbstractModel|MockObject $abstractModel */
+        $ruleMock = $this->getMockBuilder(\Magento\SalesRule\Model\Rule::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['getConditions', 'getActions'])
+            ->getMock();
+        $conditions = $this->createMock(\Magento\Rule\Model\Condition\Combine::class);
+        $actions = $this->createMock(\Magento\Rule\Model\Action\Collection::class);
+        $ruleMock->method('getConditions')->willReturn($conditions);
+        $ruleMock->method('getActions')->willReturn($actions);
+        $ruleMock->addData($data);
+        $this->resourceCoupon->expects($update ? $this->once() : $this->never())
+            ->method('updateSpecificCoupons')
+            ->with($ruleMock);
+        $this->model->afterSave($ruleMock);
+    }
+
+    /**
+     * @return array
+     */
+    public static function afterSaveShouldUpdateExistingCouponsDataProvider(): array
+    {
+        return [
+            [
+                ['use_auto_generation' => 0, 'coupon_type' => \Magento\SalesRule\Model\Rule::COUPON_TYPE_NO_COUPON],
+                false
+            ],
+            [
+                ['use_auto_generation' => 0, 'coupon_type' => \Magento\SalesRule\Model\Rule::COUPON_TYPE_SPECIFIC],
+                false
+            ],
+            [
+                ['use_auto_generation' => 1, 'coupon_type' => \Magento\SalesRule\Model\Rule::COUPON_TYPE_SPECIFIC],
+                true
+            ],
+            [
+                ['use_auto_generation' => 0, 'coupon_type' => \Magento\SalesRule\Model\Rule::COUPON_TYPE_AUTO],
+                true
+            ]
+        ];
+    }
+
     /**
      * @return array
      */