ACP2E-1074: [Magento Cloud] - discount_percent on tables sales_order_item not populating (B2B)

glo23503 · glo23503 · commit b30f62431264 · 2022-08-05T01:48:18.000+05:30
diff --git a/app/code/Magento/SalesRule/Model/Rule/Action/Discount/ByPercent.php b/app/code/Magento/SalesRule/Model/Rule/Action/Discount/ByPercent.php
@@ -61,7 +61,7 @@ protected function _calculate($rule, $item, $qty, $rulePercent)
             ($qty * $baseItemOriginalPrice - $item->getBaseDiscountAmount()) * $_rulePct
         );
 
-        if (!$rule->getDiscountQty() || $rule->getDiscountQty() > $qty) {
+        if (!$rule->getDiscountQty() || $rule->getDiscountQty() >= $qty) {
             $discountPercent = min(100, $item->getDiscountPercent() + $rulePercent);
             $item->setDiscountPercent($discountPercent);
         }
diff --git a/app/code/Magento/SalesRule/Test/Unit/Model/Rule/Action/Discount/ByPercentTest.php b/app/code/Magento/SalesRule/Test/Unit/Model/Rule/Action/Discount/ByPercentTest.php
@@ -173,7 +173,7 @@ public function testCalculate(
         )->willReturn(
             $itemData['baseDiscountAmount']
         );
-        if (!$ruleData['discountQty'] || $ruleData['discountQty'] > $qty) {
+        if (!$ruleData['discountQty'] || $ruleData['discountQty'] >= $qty) {
             $item->expects(
                 $this->atLeastOnce()
             )->method(

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ protected function _calculate($rule, $item, $qty, $rulePercent)`
`61`	`61`	`($qty * $baseItemOriginalPrice - $item->getBaseDiscountAmount()) * $_rulePct`
`62`	`62`	`);`
`63`	`63`
`64`		`- if (!$rule->getDiscountQty() \|\| $rule->getDiscountQty() > $qty) {`
	`64`	`+ if (!$rule->getDiscountQty() \|\| $rule->getDiscountQty() >= $qty) {`
`65`	`65`	`$discountPercent = min(100, $item->getDiscountPercent() + $rulePercent);`
`66`	`66`	`$item->setDiscountPercent($discountPercent);`
`67`	`67`	`}`