ACP2E-1133: Add ability to generate multiple instances of a data fixture using an optional "count" parameter

Author: bubasuma

dev/tests/integration/framework/Magento/TestFramework/Fixture/DataFixture.php

@@ -13,14 +13,16 @@
 class DataFixture
 {
     /**
-     * @param string $type
-     * @param array $data
-     * @param string|null $as
+     * @param string $type Fixture class name
+     * @param array $data Data passed on to the fixture.
+     * @param string|null $as Fixture identifier used to retrieve the data returned by the fixture
+     * @param int $count Number of instances to generate
      */
     public function __construct(
         public string $type,
         public array $data = [],
-        public ?string $as = null
+        public ?string $as = null,
+        public int $count = 1
     ) {
     }
 }

dev/tests/integration/framework/Magento/TestFramework/Fixture/Parser/DataFixture.php

@@ -35,7 +35,6 @@ public function __construct(
      */
     public function parse(TestCase $test, string $scope): array
     {
-        $fixtures = [];
         try {
             $reflection = $scope === ParserInterface::SCOPE_CLASS
                 ? new \ReflectionClass($test)
@@ -50,14 +49,21 @@ public function parse(TestCase $test, string $scope): array
             );
         }
 
+        $fixtures = [];
         $attributes = $reflection->getAttributes($this->attributeClass);
         foreach ($attributes as $attribute) {
             $args = $attribute->getArguments();
-            $fixtures[] = [
-                'name' => $args['as'] ?? $args[2] ?? null,
-                'factory' => $args[0],
-                'data' => $args[1] ?? [],
-            ];
+            $alias = $args['as'] ?? $args[2] ?? null;
+            $count = $args['count'] ?? $args[3] ?? 1;
+            $id = $count > 1 ? 1 : '';
+            do {
+                $fixtures[] = [
+                    'name' => $alias !== null ? ($alias.($id++)) : null,
+                    'factory' => $args[0],
+                    'data' => $args[1] ?? []
+                ];
+            } while (--$count > 0);
+
         }
         return $fixtures;
     }

dev/tests/integration/framework/tests/unit/testsuite/Magento/Test/Annotation/DataFixtureTest.php

@@ -484,6 +484,42 @@ public function testVariables(): void
         $this->revertFixtures();
     }
 
+    #[
+        DbIsolation(false),
+        DataFixture('MockFixture1', ['p1' => 'param-value1'], 'fixture1', count: 2),
+        DataFixture('MockFixture2', ['p2' => '$fixture12.attr_1$'], 'fixture2'),
+        DataFixture('MockFixture3', ['p3' => '$fixture2.attr_3$', 'p4' => ['p5' => '$fixture11$']], 'fixture3'),
+    ]
+    public function testCount(): void
+    {
+        $fixture11 = new DataObject(['attr_1' => 'attr-value11', 'attr_2' => 'attr-value21']);
+        $fixture12 = new DataObject(['attr_1' => 'attr-value12', 'attr_2' => 'attr-value22']);
+        $fixture2 = new DataObject(['attr_3' => 1]);
+        $this->fixture1->expects($this->exactly(2))
+            ->method('apply')
+            ->with(['p1' => 'param-value1'])
+            ->willReturnOnConsecutiveCalls($fixture11, $fixture12);
+        $this->fixture2->expects($this->once())
+            ->method('apply')
+            ->with(['p2' => 'attr-value12'])
+            ->willReturn($fixture2);
+        $this->fixture3->expects($this->once())
+            ->method('apply')
+            ->with(['p3' => 1, 'p4' => ['p5' => $fixture11]]);
+        $this->applyFixtures();
+        $this->assertSame($fixture11, $this->fixtureStorage->get('fixture11'));
+        $this->assertSame($fixture12, $this->fixtureStorage->get('fixture12'));
+        $this->assertSame($fixture2, $this->fixtureStorage->get('fixture2'));
+        $this->assertNull($this->fixtureStorage->get('fixture3'));
+        $this->fixture1->expects($this->exactly(2))
+            ->method('revert')
+            ->withConsecutive([$fixture12], [$fixture11]);
+        $this->fixture2->expects($this->once())
+            ->method('revert')
+            ->with($fixture2);
+        $this->revertFixtures();
+    }
+
     /**
      * @throws ReflectionException
      */