ACPT-1191: Fix Quote related issues on Application Server

Author: aa-kashk

app/code/Magento/Config/Model/ResourceModel/Config.php

@@ -24,14 +24,14 @@ class Config extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb implem
     private $pillPut;
 
     /**
+     *
      * Define main table
      * @param PoisonPillPutInterface|null $pillPut
      * @return void
      */
     protected function _construct(
         PoisonPillPutInterface $pillPut = null
-    )
-    {
+    ) {
         $this->_init('core_config_data', 'config_id');
         $this->pillPut = $pillPut ?: \Magento\Framework\App\ObjectManager::getInstance()
             ->get(PoisonPillPutInterface::class);

app/code/Magento/Tax/Model/Calculation.php

@@ -22,6 +22,7 @@
 
 /**
  * Tax Calculation Model
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  * @SuppressWarnings(PHPMD.TooManyFields)
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
@@ -50,7 +51,7 @@ class Calculation extends \Magento\Framework\Model\AbstractModel implements Rese
     /**
      * Identifier constant for unit based calculation
      */
-    const CALC_UNIT_BASE = 'UNIT_BASE_CALCULATION';
+    public const CALC_UNIT_BASE = 'UNIT_BASE_CALCULATION';
 
     /**
      * Identifier constant for row based calculation
@@ -526,11 +527,13 @@ public function getRateRequest(
                     //fallback to default address for registered customer
                     try {
                         $defaultBilling = $this->customerAccountManagement->getDefaultBillingAddress($customerId);
+                        // phpcs:disable Magento2.CodeAnalysis.EmptyBlock.DetectedCatch
                     } catch (NoSuchEntityException $e) {
                     }
 
                     try {
                         $defaultShipping = $this->customerAccountManagement->getDefaultShippingAddress($customerId);
+                        // phpcs:disable Magento2.CodeAnalysis.EmptyBlock.DetectedCatch
                     } catch (NoSuchEntityException $e) {
                     }
 

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetShippingMethodsOnCartTest.php

@@ -386,7 +386,9 @@ private function getQuery(
     public function testSetShippingMethodOnAnEmptyCart()
     {
         $this->expectException(\Exception::class);
-        $this->expectExceptionMessage('The shipping method can\'t be set for an empty cart. Add an item to cart and try again.');
+        $this->expectExceptionMessage(
+            'The shipping method can\'t be set for an empty cart. Add an item to cart and try again.'
+        );
 
         $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
         $carrierCode = 'flatrate';

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetShippingMethodsOnCartTest.php

@@ -318,7 +318,9 @@ public function testSetShippingMethodToCustomerCart()
     public function testSetShippingMethodOnAnEmptyCart()
     {
         $this->expectException(\Exception::class);
-        $this->expectExceptionMessage('The shipping method can\'t be set for an empty cart. Add an item to cart and try again.');
+        $this->expectExceptionMessage(
+            'The shipping method can\'t be set for an empty cart. Add an item to cart and try again.'
+        );
 
         $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
         $carrierCode = 'flatrate';