Rename stock_availability field to is_available and use property promotion

Author: wip44850

app/code/Magento/QuoteGraphQl/Model/CartItem/ProductStock.php

@@ -31,20 +31,14 @@ class ProductStock
      */
     private const PRODUCT_TYPE_BUNDLE = "bundle";
 
-    /**
-     * @var StockStatusRepositoryInterface
-     */
-    private $stockStatusRepository;
-
     /**
      * ProductStock constructor
      *
      * @param StockStatusRepositoryInterface $stockStatusRepository
      */
     public function __construct(
-        StockStatusRepositoryInterface $stockStatusRepository
+        private StockStatusRepositoryInterface $stockStatusRepository
     ) {
-        $this->stockStatusRepository = $stockStatusRepository;
     }
 
     /**

app/code/Magento/QuoteGraphQl/Model/Resolver/CheckProductStockAvailability.php

@@ -30,20 +30,14 @@
  */
 class CheckProductStockAvailability implements ResolverInterface
 {
-    /**
-     * @var ProductStock
-     */
-    private ProductStock $productStock;
-
     /**
      * CheckProductStockAvailability constructor
      *
      * @param ProductStock $productStock
      */
     public function __construct(
-        ProductStock $productStock
+        private ProductStock $productStock
     ) {
-        $this->productStock = $productStock;
     }
 
     /**
@@ -57,6 +51,6 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         /** @var Item $cartItem */
         $cartItem = $value['model'];
 
-        return $this->productStock->isProductAvailable($cartItem) ? "available" : "unavailable";
+        return $this->productStock->isProductAvailable($cartItem) ? true : false;
     }
 }

app/code/Magento/QuoteGraphQl/etc/schema.graphqls

@@ -360,7 +360,7 @@ interface CartItemInterface @typeResolver(class: "Magento\\QuoteGraphQl\\Model\\
     id: String! @deprecated(reason: "Use `uid` instead.")
     uid: ID! @doc(description: "The unique ID for a `CartItemInterface` object.")
     quantity: Float! @doc(description: "The quantity of this item in the cart.")
-    stock_availability: String @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CheckProductStockAvailability") @doc(description: "If qty is more than stock display status as unavailable else available.")
+    is_available: Boolean! @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CheckProductStockAvailability") @doc(description: "If qty is more than stock display status as unavailable else available.")
     prices: CartItemPrices @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartItemPrices") @doc(description: "Contains details about the price of the item, including taxes and discounts.")
     product: ProductInterface! @doc(description: "Details about an item in the cart.")
     errors: [CartItemError!] @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\CartItemErrors") @doc(description: "An array of errors encountered while loading the cart item")

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/StockAvailabilityTest.php

@@ -86,7 +86,7 @@ public function testStockStatusUnavailableSimpleProduct(): void
         $response = $this->graphQlMutation($query);
         $responseDataObject = new DataObject($response);
 
-        self::assertEquals('unavailable', $responseDataObject->getData('cart/items/0/stock_availability'));
+        self::assertEquals(false, $responseDataObject->getData('cart/items/0/is_available'));
     }
 
     #[
@@ -103,8 +103,8 @@ public function testStockStatusUnavailableAddSimpleProduct(): void
         $responseDataObject = new DataObject($response);
 
         self::assertEquals(
-            'unavailable',
-            $responseDataObject->getData('addProductsToCart/cart/items/0/stock_availability')
+            false,
+            $responseDataObject->getData('addProductsToCart/cart/items/0/is_available')
         );
     }
 
@@ -145,8 +145,8 @@ public function testStockStatusUnavailableBundleProduct(): void
         $responseDataObject = new DataObject($response);
 
         self::assertEquals(
-            'unavailable',
-            $responseDataObject->getData('cart/items/0/stock_availability')
+            false,
+            $responseDataObject->getData('cart/items/0/is_available')
         );
     }
 
@@ -200,8 +200,8 @@ public function testStockStatusUnavailableAddBundleProduct(): void
         $responseDataObject = new DataObject($response);
 
         self::assertEquals(
-            'unavailable',
-            $responseDataObject->getData('addProductsToCart/cart/items/0/stock_availability')
+            false,
+            $responseDataObject->getData('addProductsToCart/cart/items/0/is_available')
         );
     }
 
@@ -234,8 +234,8 @@ public function testStockStatusUnavailableConfigurableProduct(): void
         $responseDataObject = new DataObject($response);
 
         self::assertEquals(
-            'unavailable',
-            $responseDataObject->getData('cart/items/0/stock_availability')
+            false,
+            $responseDataObject->getData('cart/items/0/is_available')
         );
     }
 
@@ -267,8 +267,8 @@ public function testStockStatusUnavailableAddConfigurableProduct(): void
         $responseDataObject = new DataObject($response);
 
         self::assertEquals(
-            'unavailable',
-            $responseDataObject->getData('addProductsToCart/cart/items/0/stock_availability')
+            false,
+            $responseDataObject->getData('addProductsToCart/cart/items/0/is_available')
         );
     }
 
@@ -282,7 +282,7 @@ private function getQuery(string $cartId): string
 {
   cart(cart_id:"{$cartId}"){
     items{
-      stock_availability
+      is_available
     }
   }
 }
@@ -304,7 +304,7 @@ private function mutationAddSimpleProduct(string $cartId, string $sku, int $qty
   ) {
     cart {
       items {
-        stock_availability
+        is_available
       }
     }
   }
@@ -333,7 +333,7 @@ private function mutationAddBundleProduct(
   ) {
     cart {
       items {
-        stock_availability
+        is_available
         product {
           sku
         }
@@ -363,7 +363,7 @@ private function mutationAddConfigurableProduct(
   ) {
     cart {
       items {
-        stock_availability
+        is_available
         product {
           sku
         }