AC-15461: Migration New Relic from REST v2 to NerdGraph (GraphQL)

Author: sandesh-as

dev/tests/integration/testsuite/Magento/NewRelicReporting/Console/Command/DeployMarkerCommandTest.php

@@ -21,7 +21,6 @@
 /**
  * Integration test for DeployMarker console command.
  * Covers framework integration (DI, Config, CLI) for both v2_rest and NerdGraph modes.
- * API calls are not executed against real endpoints (fake credentials only).
  *
  * @magentoAppIsolation enabled
  */
@@ -51,8 +50,6 @@ protected function setUp(): void
     {
         $this->objectManager = Bootstrap::getObjectManager();
         $this->mutableScopeConfig = $this->objectManager->get(MutableScopeConfigInterface::class);
-
-        // Focus: Test Magento framework integration (DI, Config, CLI)
         $this->command = $this->objectManager->get(DeployMarker::class);
         $this->commandTester = new CommandTester($this->command);
     }
@@ -107,15 +104,13 @@ public function testCommandWithMinimalArgumentsV2Rest()
             'message' => 'Test deployment message'
         ]);
 
-        // Framework integration: Should handle gracefully (success or graceful failure)
         $this->assertTrue(in_array($exitCode, [0, 1], true), 'Command should exit with 0 (success) or 1 (graceful failure)');
         $output = $this->commandTester->getDisplay();
 
-        // Test: No fatal framework errors
+        // No fatal framework errors
         $this->assertStringNotContainsString('Fatal error', $output);
         $this->assertStringNotContainsString('Call to a member function', $output);
 
-        // Test: Command produces meaningful UX message
         $this->assertMatchesRegularExpression('/(✓|✗)/', $output, 'Output should contain success (✓) or error (✗) indicator');
     }
 
@@ -159,7 +154,6 @@ public function testCommandConfiguration()
      */
     public function testCommandWithAllParametersNerdGraph()
     {
-        // Test: Magento config system integration
         $this->mutableScopeConfig->setValue('newrelicreporting/general/enable', '1');
         $this->mutableScopeConfig->setValue('newrelicreporting/general/api_mode', 'nerdgraph');
         $this->mutableScopeConfig->setValue('newrelicreporting/general/entity_guid', 'fake-guid-for-testing');
@@ -179,11 +173,8 @@ public function testCommandWithAllParametersNerdGraph()
         $this->assertTrue(in_array($exitCode, [0, 1], true), 'Command should exit with 0 (success) or 1 (graceful failure)');
         $output = $this->commandTester->getDisplay();
 
-        // Test: No fatal framework errors
         $this->assertStringNotContainsString('Fatal error', $output);
         $this->assertStringNotContainsString('Call to a member function', $output);
-
-        // Test: Command produces meaningful UX message
         $this->assertMatchesRegularExpression('/(✓|✗)/', $output, 'Output should contain success (✓) or error (✗) indicator');
     }
 
@@ -198,12 +189,10 @@ public function testCommandWithEmptyMessage()
             'message' => ''
         ]);
 
-        // Should process empty message (validation handled by deployment service)
         $this->assertIsInt($exitCode);
         $output = $this->commandTester->getDisplay();
         $this->assertStringNotContainsString('Fatal error', $output);
 
-        // Test: Command produces meaningful UX message even for empty input
         $this->assertMatchesRegularExpression('/(✓|✗)/', $output, 'Output should contain success (✓) or error (✗) indicator');
     }
 

dev/tests/integration/testsuite/Magento/NewRelicReporting/Console/Command/EuEndpointTest.php

@@ -10,6 +10,7 @@
 use Magento\Framework\App\Config\MutableScopeConfigInterface;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\Exception\LocalizedException;
+use Magento\Framework\HTTP\LaminasClient;
 use Magento\Framework\HTTP\LaminasClientFactory;
 use Magento\Framework\ObjectManagerInterface;
 use Magento\Framework\Serialize\SerializerInterface;
@@ -170,13 +171,13 @@ public function testNerdGraphModeSelection()
 
     /**
      * Test Deployments service configuration
+     * @throws \ReflectionException
      */
     public function testDeploymentsServiceConfiguration()
     {
         // Test that Deployments service is properly configured
         $this->assertInstanceOf(Deployments::class, $this->deployments);
 
-        // Test dependency injection
         $reflection = new \ReflectionClass($this->deployments);
         $constructor = $reflection->getConstructor();
         $parameters = $constructor->getParameters();
@@ -199,12 +200,12 @@ public function testDeploymentsServiceConfiguration()
 
     /**
      * Test NerdGraph Client configuration
+     * @throws \ReflectionException
      */
     public function testNerdGraphClientConfiguration()
     {
         $this->assertInstanceOf(Client::class, $this->nerdGraphClient);
 
-        // Test dependency injection
         $reflection = new \ReflectionClass($this->nerdGraphClient);
         $constructor = $reflection->getConstructor();
         $parameters = $constructor->getParameters();
@@ -225,12 +226,12 @@ public function testNerdGraphClientConfiguration()
 
     /**
      * Test DeploymentTracker configuration
+     * @throws \ReflectionException
      */
     public function testDeploymentTrackerConfiguration()
     {
         $this->assertInstanceOf(DeploymentTracker::class, $this->deploymentTracker);
 
-        // Test dependency injection
         $reflection = new \ReflectionClass($this->deploymentTracker);
         $constructor = $reflection->getConstructor();
         $parameters = $constructor->getParameters();
@@ -289,7 +290,7 @@ public function testHttpClientFactoryIntegration()
 
         // Should be able to create HTTP client
         $httpClient = $httpClientFactory->create();
-        $this->assertInstanceOf(\Magento\Framework\HTTP\LaminasClient::class, $httpClient);
+        $this->assertInstanceOf(LaminasClient::class, $httpClient);
     }
 
     /**
@@ -318,36 +319,12 @@ public function testLoggerIntegration()
 
         // Should be able to log without errors
         $logger->info('Test log message from integration test');
-        $this->assertTrue(true); // If we get here, logging worked
-    }
-
-    /**
-     * Test configuration paths are accessible
-     */
-    public function testConfigurationPaths()
-    {
-        $testPaths = [
-            'newrelicreporting/general/enable',
-            'newrelicreporting/general/api_mode',
-            'newrelicreporting/general/entity_guid',
-            'newrelicreporting/general/app_id',
-            'newrelicreporting/general/app_name',
-            'newrelicreporting/general/api',
-            'newrelicreporting/general/nerd_graph_api_url',
-            'newrelicreporting/general/api_url'
-        ];
-
-        $scopeConfig = $this->objectManager->get(ScopeConfigInterface::class);
-
-        foreach ($testPaths as $path) {
-            // Should not throw exception when accessing these paths
-            $value = $scopeConfig->getValue($path);
-            $this->assertTrue(true); // If we get here, path is accessible
-        }
+        $this->assertTrue(true);
     }
 
     /**
      * Test error handling in deployment workflow
+     * @throws LocalizedException
      */
     public function testDeploymentWorkflowErrorHandling()
     {