MC-17868: Break jQuery UI into widgets and make a prototype

- Fix code style for static tests;

Author: adifucan

dev/tests/static/testsuite/Magento/Test/Legacy/ObsoleteCodeTest.php

@@ -184,8 +184,11 @@ public function testJsFiles()
             function ($file) {
                 $content = file_get_contents($file);
                 $this->_testObsoletePropertySkipCalculate($content);
-                if (!strpos($file, 'requirejs-config.js')
-                    && (strpos($file, '/view/frontend/web/') || strpos($file, '/view/base/web/'))
+                if (strpos($file, 'requirejs-config.js') === false
+                    && (
+                        strpos($file, '/view/frontend/web/') !== false
+                        || strpos($file, '/view/base/web/') !== false
+                    )
                 ) {
                     $this->_testJqueryUiLibraryIsNotUsedInJs($content);
                 }
@@ -708,14 +711,16 @@ private function _checkCompletePathOfClass(
         }
         $pathWithConstParts = explode('\\', $pathWithConst);
         $pathInUseNamespace = trim($matchClassString['classPath'], '\\');
-        $pathInUseNamespaceTruncated = trim(trim(
-            preg_replace(
-                '/' . preg_quote($pathWithConstParts[0]) . '$/',
-                '',
-                $pathInUseNamespace
-            ),
-            '\\'
-        ));
+        $pathInUseNamespaceTruncated = trim(
+            trim(
+                preg_replace(
+                    '/' . preg_quote($pathWithConstParts[0]) . '$/',
+                    '',
+                    $pathInUseNamespace
+                ),
+                '\\'
+            )
+        );
         if ($this->_checkClasspathProperDivisionNoConstantPath(
             $pathInUseNamespaceTruncated,
             $pathInUseNamespace,
@@ -963,7 +968,10 @@ private function _testJqueryUiLibraryIsNotUsedInJs($fileContent)
         $this->_assertNotRegexp(
             '/(["\'])jquery\/ui\1/',
             $fileContent,
-            $this->_suggestReplacement(sprintf("Dependency '%s' is redundant.", 'jquery/ui'), 'Use separate jquery ui widget instead of all library.')
+            $this->_suggestReplacement(
+                sprintf("Dependency '%s' is redundant.", 'jquery/ui'),
+                'Use separate jquery ui widget instead of all library.'
+            )
         );
     }
 }

dev/tests/static/testsuite/Magento/Test/Legacy/PhtmlTemplateTest.php

@@ -7,6 +7,9 @@
  */
 namespace Magento\Test\Legacy;
 
+/**
+ * Static test for phtml template files.
+ */
 class PhtmlTemplateTest extends \PHPUnit\Framework\TestCase
 {
     public function testBlockVariableInsteadOfThis()
@@ -19,7 +22,7 @@ public function testBlockVariableInsteadOfThis()
              * @param string $file
              */
             function ($file) {
-                $this->assertNotRegExp(
+                self::assertNotRegExp(
                     '/this->(?!helper)\S*/iS',
                     file_get_contents($file),
                     'Access to members and methods of Block class through $this is ' .
@@ -46,7 +49,7 @@ public function testObsoleteBlockMethods()
              * @param string $file
              */
             function ($file) {
-                $this->assertNotRegexp(
+                self::assertNotRegexp(
                     '/block->_[^_]+\S*\(/iS',
                     file_get_contents($file),
                     'Access to protected and private members of Block class is ' .
@@ -68,7 +71,7 @@ public function testObsoleteJavascriptAttributeType()
              * @param string $file
              */
             function ($file) {
-                $this->assertNotRegexp(
+                self::assertNotRegexp(
                     '/type="text\/javascript"/',
                     file_get_contents($file),
                     'Please do not use "text/javascript" type attribute.'
@@ -82,15 +85,17 @@ public function testJqueryUiLibraryIsNotUsedInTemplates()
     {
         $invoker = new \Magento\Framework\App\Utility\AggregateInvoker($this);
         $invoker(
-        /**
-         * 'jquery/ui' library is not obligatory to use in phtml files.
-         * It's better to use needed jquery ui widget instead.
-         *
-         * @param string $file
-         */
+            /**
+             * 'jquery/ui' library is not obligatory to use in phtml files.
+             * It's better to use needed jquery ui widget instead.
+             *
+             * @param string $file
+             */
             function ($file) {
-                if (strpos($file, '/view/frontend/templates/') || strpos($file, '/view/base/templates/')) {
-                    $this->assertNotRegexp(
+                if (strpos($file, '/view/frontend/templates/') !== false
+                    || strpos($file, '/view/base/templates/') !== false
+                ) {
+                    self::assertNotRegexp(
                         '/(["\'])jquery\/ui\1/',
                         file_get_contents($file),
                         'Please do not use "jquery/ui" library in templates. Use needed jquery ui widget instead.'

lib/internal/Magento/Framework/Data/Form/Element/Editablemultiselect.php

@@ -15,6 +15,9 @@
 
 use Magento\Framework\Escaper;
 
+/**
+ * Form editable multiselect element.
+ */
 class Editablemultiselect extends \Magento\Framework\Data\Form\Element\Multiselect
 {
     /**