ACP2E-2978: Saving product by admin user with different role scope overwrites/deletes existing Related product information in the product

Author: glanujnehra

app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php

@@ -284,7 +284,6 @@ protected function setProductLinks(Product $product)
     {
         $links = $this->getLinkResolver()->getLinks();
 
-        $currentProductLinks = $product->getProductLinks();
         $product->setProductLinks([]);
 
         $product = $this->productLinks->initializeLinks($product, $links);
@@ -301,14 +300,14 @@ protected function setProductLinks(Product $product)
             unset($linkTypes[$productLink->getLinkType()]);
         }
 
-        $readonlyRelatedProducts = false;
-        $readonlyUpSellProducts = false;
+        $isReadOnlyRelatedItems = $isReadOnlyUpSellItems = false;
         foreach ($linkTypes as $linkType => $readonly) {
-            if ($linkType === 'related' && $readonly) {
-                $readonlyRelatedProducts = true;
-            }
-            if ($linkType === 'upsell' && $readonly) {
-                $readonlyUpSellProducts = true;
+            if ($readonly) {
+                if ($linkType === 'related') {
+                    $isReadOnlyRelatedItems = true;
+                } elseif ($linkType === 'upsell') {
+                    $isReadOnlyUpSellItems = true;
+                }
             }
             if (isset($links[$linkType]) && !$readonly) {
                 foreach ((array) $links[$linkType] as $linkData) {
@@ -326,8 +325,8 @@ protected function setProductLinks(Product $product)
                 }
             }
         }
-        if ($readonlyRelatedProducts && $readonlyUpSellProducts && empty($productLinks)) {
-            return $product->setProductLinks($currentProductLinks);
+        if ($isReadOnlyRelatedItems && $isReadOnlyUpSellItems) {
+            $productLinks = [];
         }
 
         return $product->setProductLinks($productLinks);