31870: updated the if condition

Author: rmsundar1

app/code/Magento/ConfigurableProduct/Model/Plugin/ProductRepositorySave.php

@@ -60,9 +60,8 @@ public function beforeSave(
         ProductInterface $product,
         $saveOptions = false
     ): void {
-        if ($product->getTypeId() === Configurable::TYPE_CODE
-            && null !== ($extensionAttributes = $product->getExtensionAttributes())
-        ) {
+        $extensionAttributes = $product->getExtensionAttributes();
+        if ($extensionAttributes !== null && $product->getTypeId() === Configurable::TYPE_CODE) {
             $configurableLinks = (array) $extensionAttributes->getConfigurableProductLinks();
             $configurableOptions = (array) $extensionAttributes->getConfigurableProductOptions();
 

app/code/Magento/ConfigurableProduct/Test/Unit/Model/Plugin/ProductRepositorySaveTest.php

@@ -113,10 +113,10 @@ protected function setUp(): void
      */
     public function testBeforeSaveWhenProductIsSimple(): void
     {
-        $this->product->expects(static::once())
+        $this->product->expects(static::atMost(1))
             ->method('getTypeId')
             ->willReturn('simple');
-        $this->product->expects(static::never())
+        $this->product->expects(static::once())
             ->method('getExtensionAttributes');
 
         $this->assertNull($this->plugin->beforeSave($this->productRepository, $this->product));