fix after a CR

Author: silinmykola

lib/internal/Magento/Framework/App/Test/Unit/ViewTest.php

@@ -166,9 +166,7 @@ public function testLoadLayoutWithDefaultSetup(): void
         $this->_layoutProcessor
             ->method('addHandle')
             ->withConsecutive(['default']);
-        $this->_requestMock->expects($this->any())
-            ->method('getFullActionName')
-            ->willReturn('action_name');
+        $this->_requestMock->method('getFullActionName')->willReturn('action_name');
         $this->_view->loadLayout();
     }
 
@@ -177,9 +175,7 @@ public function testLoadLayoutWithDefaultSetup(): void
      */
     public function testLoadLayoutWhenBlocksNotGenerated(): void
     {
-        $this->_requestMock->expects($this->any())
-            ->method('getFullActionName')
-            ->willReturn('action_name');
+        $this->_requestMock->method('getFullActionName')->willReturn('action_name');
         $this->_view->loadLayout('', false, true);
     }
 
@@ -188,9 +184,7 @@ public function testLoadLayoutWhenBlocksNotGenerated(): void
      */
     public function testLoadLayoutWhenXmlNotGenerated(): void
     {
-        $this->_requestMock->expects($this->any())
-            ->method('getFullActionName')
-            ->willReturn('action_name');
+        $this->_requestMock->method('getFullActionName')->willReturn('action_name');
         $this->_view->loadLayout('', true, false);
     }
 
@@ -271,7 +265,10 @@ public function testGenerateLayoutBlocksWhenFlagIsSet(): void
      */
     public function testRenderLayoutIfActionFlagExist(): void
     {
-        $this->_actionFlagMock->expects($this->once())->method('get')->with('', 'no-renderLayout')->willReturn(true);
+        $this->_actionFlagMock->expects($this->once())
+            ->method('get')
+            ->with('', 'no-renderLayout')
+            ->willReturn(true);
         $this->_eventManagerMock->expects($this->never())->method('dispatch');
         $this->_view->renderLayout();
     }

lib/internal/Magento/Framework/Code/Generator/EntityAbstract.php

@@ -157,8 +157,7 @@ public function getSourceClassNameWithoutNamespace()
      */
     protected function _getFullyQualifiedClassName($className)
     {
-        $className = $className ? ltrim($className, '\\') : '';
-        return $className ? '\\' . $className : '';
+        return $className ? '\\' . ltrim($className, '\\') : '';
     }
 
     /**

lib/internal/Magento/Framework/Mview/Test/Unit/View/ChangelogTest.php

@@ -111,7 +111,6 @@ public function testGetNameWithException()
     {
         $this->expectException('DomainException');
         $this->expectExceptionMessage('View\'s identifier is not set');
-        $this->model->setViewId('');
         $this->model->getName();
     }
 

lib/internal/Magento/Framework/Mview/View/Changelog.php

@@ -265,7 +265,7 @@ public function getVersion()
      */
     public function getName()
     {
-        if (strlen($this->viewId) == 0) {
+        if (!$this->viewId || strlen($this->viewId) == 0) {
             throw new \DomainException(
                 new Phrase("View's identifier is not set")
             );

lib/internal/Magento/Framework/ObjectManager/Config/Config.php

@@ -5,7 +5,6 @@
  */
 namespace Magento\Framework\ObjectManager\Config;
 
-use Magento\Framework\App\ObjectManager;
 use Magento\Framework\ObjectManager\ConfigCacheInterface;
 use Magento\Framework\ObjectManager\DefinitionInterface;
 use Magento\Framework\ObjectManager\RelationsInterface;
@@ -93,7 +92,7 @@ public function __construct(
     ) {
         $this->_relations = $relations ?: new \Magento\Framework\ObjectManager\Relations\Runtime();
         $this->_definitions = $definitions ?: new \Magento\Framework\ObjectManager\Definition\Runtime();
-        $this->serializer = $serializer ?: ObjectManager::getInstance()->get(SerializerInterface::class);
+        $this->serializer = $serializer ?: new \Magento\Framework\Serialize\Serializer\Json();
     }
 
     /**

lib/internal/Magento/Framework/ObjectManager/Test/Unit/Config/ConfigTest.php

@@ -53,17 +53,14 @@ public function testExtendWithCacheMock()
         $definitions = $this->getMockForAbstractClass(DefinitionInterface::class);
         $definitions->expects($this->once())->method('getClasses')->willReturn(['FooType']);
 
-        $serializer = $this->getMockForAbstractClass(SerializerInterface::class);
-        $serializer->expects($this->any())
-            ->method('serialize')
-            ->willReturn('["custom_value"]');
         $cache = $this->getMockForAbstractClass(ConfigCacheInterface::class);
         $cache->expects($this->once())->method('get')->willReturn(false);
 
-        $config = new Config(null, $definitions, $serializer);
         $serializerMock = $this->getMockForAbstractClass(SerializerInterface::class);
-        $serializerMock->expects($this->exactly(2))
-            ->method('serialize');
+        $serializerMock->expects($this->atLeast(2))
+            ->method('serialize')
+            ->willReturn('[[],[],[],[]]');
+        $config = new Config(null, $definitions, $serializerMock);
         $this->objectManagerHelper->setBackwardCompatibleProperty(
             $config,
             'serializer',