AC-14558::Migration form RabbitMQ to Apache ActiveMQ

Author: djadobe16

app/code/Magento/MysqlMq/Model/Driver/Queue.php

@@ -177,7 +177,7 @@ public function count(): int
      *
      * @return void
      */
-    public function subscribeQueue()
+    public function subscribeQueue(): void
     {
         throw new \BadMethodCallException('subscribeQueue is not supported in MySQL MQ driver.');
     }

app/code/Magento/Stomp/etc/di.xml

@@ -65,7 +65,4 @@
             <argument name="instanceName" xsi:type="string">\Magento\Framework\Stomp\Bulk\Queue</argument>
         </arguments>
     </virtualType>
-<!--    <type name="Magento\Framework\MessageQueue\BatchConsumer">-->
-<!--        <plugin name="batch_consumer_plugin" type="Magento\Stomp\Plugin\BatchConsumer" />-->
-<!--    </type>-->
 </config>

dev/tests/integration/_files/Magento/TestModuleAsyncStomp/Model/AsyncTestData.php

@@ -25,15 +25,15 @@ class AsyncTestData
      * @param string $path
      * @return void
      */
-    public function setTextFilePath($path)
+    public function setTextFilePath(string $path): void
     {
         $this->path = $path;
     }
 
     /**
      * @return string
      */
-    public function getTextFilePath()
+    public function getTextFilePath(): string
     {
         return $this->path;
     }
@@ -42,15 +42,15 @@ public function getTextFilePath()
      * @param string $strValue
      * @return void
      */
-    public function setValue($strValue)
+    public function setValue(string $strValue): void
     {
         $this->msgValue = $strValue;
     }
 
     /**
      * @return string
      */
-    public function getValue()
+    public function getValue(): string
     {
         return $this->msgValue;
     }

dev/tests/integration/_files/Magento/TestModuleAsyncStomp/Model/CustomHandler.php

@@ -12,7 +12,7 @@ class CustomHandler
     /**
      * @param AsyncTestData $simpleDataItem
      */
-    public function process($simpleDataItem)
+    public function process(AsyncTestData $simpleDataItem): void
     {
         file_put_contents(
             $simpleDataItem->getTextFilePath(),
@@ -24,7 +24,7 @@ public function process($simpleDataItem)
     /**
      * @param AsyncTestData[] $simpleDataItems
      */
-    public function processArray($simpleDataItems)
+    public function processArray(array $simpleDataItems): void
     {
         foreach ($simpleDataItems as $objItem) {
             file_put_contents(
@@ -38,7 +38,7 @@ public function processArray($simpleDataItems)
     /**
      * @param mixed $simpleDataItems
      */
-    public function processMixed($simpleDataItems)
+    public function processMixed(mixed $simpleDataItems): void
     {
         /** @var AsyncTestData[] $simpleDataItems */
         $simpleDataItems = is_array($simpleDataItems) ? $simpleDataItems : [$simpleDataItems];

dev/tests/integration/_files/Magento/TestModuleAsyncStomp/Model/RequestHandler.php

@@ -12,7 +12,7 @@ class RequestHandler
     /**
      * @param AsyncTestData $simpleDataItem
      */
-    public function process(AsyncTestData $simpleDataItem)
+    public function process(AsyncTestData $simpleDataItem): void
     {
         file_put_contents(
             $simpleDataItem->getTextFilePath(),

dev/tests/integration/framework/Magento/TestFramework/ApplicationStateComparator/_files/state-skip-list.php

@@ -564,7 +564,7 @@
         \Magento\Framework\Stomp\Queue::class => null,
         \Magento\Framework\Stomp\StompClient::class => null,
         \Magento\Framework\MessageQueue\QueueRepository::class => null,
-        'Stomp\StatefulStomp' => null,
+        Stomp\StatefulStomp::class => null,
     ],
     'placeOrder-fromConstructed' => [
         // AMQP message queue objects
@@ -580,6 +580,6 @@
         \Magento\Framework\Stomp\Queue::class => null,
         \Magento\Framework\Stomp\StompClient::class => null,
         \Magento\Framework\MessageQueue\QueueRepository::class => null,
-        'Stomp\StatefulStomp' => null,
+        \Stomp\StatefulStomp::class => null,
     ],
 ];

lib/internal/Magento/Framework/Amqp/Queue.php

@@ -206,7 +206,7 @@ public function push(EnvelopeInterface $envelope)
      *
      * @return void
      */
-    public function subscribeQueue()
+    public function subscribeQueue(): void
     {
         throw new \BadMethodCallException('subscribeQueue is not supported in amqp queue.');
     }

lib/internal/Magento/Framework/MessageQueue/QueueInterface.php

@@ -65,7 +65,7 @@ public function push(EnvelopeInterface $envelope);
      *
      * @return void
      */
-    public function subscribeQueue();
+    public function subscribeQueue(): void;
 
     /**
      * Clear queue

lib/internal/Magento/Framework/Stomp/Queue.php

@@ -258,7 +258,7 @@ private function readMessage(): ?Frame
     /**
      * @inheritdoc
      */
-    public function subscribeQueue()
+    public function subscribeQueue(): void
     {
         $stompClient = $this->getStompConsumerClient();
         $stompClient->subscribeQueue($this->queueName);