PWA-1311: New Relic is not being given useful transaction names for graphql requests

 - remove is_cacheable logging

Author: cspruiell

app/code/Magento/GraphQl/Helper/Query/Logger/LogData.php

@@ -101,10 +101,6 @@ private function gatherQueryInformation(Schema $schema) : array
      */
     private function gatherResponseInformation(HttpResponse $response) : array
     {
-        $responseInformation[LoggerInterface::IS_CACHEABLE] =
-            ($response->getHeader('X-Magento-Tags') && $response->getHeader('X-Magento-Tags') !== '')
-                ? 'true'
-                : 'false';
         $responseInformation[LoggerInterface::X_MAGENTO_CACHE_ID] =
             $response->getHeader('X-Magento-Cache-Id')
                 ? $response->getHeader('X-Magento-Cache_Id')->getFieldValue()

app/code/Magento/GraphQl/Model/Query/Logger/LoggerInterface.php

@@ -21,7 +21,6 @@ interface LoggerInterface
     const HAS_AUTH_HEADER = 'GraphQlHasAuthHeader';
     const HTTP_METHOD = 'GraphQlHttpMethod';
     const HAS_MUTATION = 'GraphQlHasMutation';
-    const IS_CACHEABLE = 'GraphQlIsCacheable';
     const COMPLEXITY = 'GraphQlComplexity';
     const REQUEST_LENGTH = 'GraphQlRequestLength';
     const HTTP_RESPONSE_CODE = 'GraphQlHttpResponseCode';

dev/tests/integration/testsuite/Magento/GraphQl/Helper/Query/Logger/LogDataTest.php

@@ -132,7 +132,6 @@ public function getQueryInformationDataProvider()
                     LoggerInterface::STORE_HEADER => 1,
                     LoggerInterface::CURRENCY_HEADER => 'USD',
                     LoggerInterface::HAS_AUTH_HEADER => 'true',
-                    LoggerInterface::IS_CACHEABLE => 'true',
                     LoggerInterface::REQUEST_LENGTH => 123,
                     LoggerInterface::HAS_MUTATION => 'false',
                     LoggerInterface::NUMBER_OF_OPERATIONS => 1,
@@ -161,7 +160,6 @@ public function getQueryInformationDataProvider()
                     LoggerInterface::STORE_HEADER => '',
                     LoggerInterface::CURRENCY_HEADER => '',
                     LoggerInterface::HAS_AUTH_HEADER => 'false',
-                    LoggerInterface::IS_CACHEABLE => 'false',
                     LoggerInterface::REQUEST_LENGTH => '',
                     LoggerInterface::HAS_MUTATION => 'false',
                     LoggerInterface::NUMBER_OF_OPERATIONS => 1,
@@ -195,7 +193,6 @@ public function getQueryInformationDataProvider()
                     LoggerInterface::STORE_HEADER => '',
                     LoggerInterface::CURRENCY_HEADER => '',
                     LoggerInterface::HAS_AUTH_HEADER => 'false',
-                    LoggerInterface::IS_CACHEABLE => 'true',
                     LoggerInterface::REQUEST_LENGTH => '',
                     LoggerInterface::HAS_MUTATION => 'false',
                     LoggerInterface::NUMBER_OF_OPERATIONS => 0,
@@ -227,7 +224,6 @@ public function getQueryInformationDataProvider()
                     LoggerInterface::STORE_HEADER => '',
                     LoggerInterface::CURRENCY_HEADER => '',
                     LoggerInterface::HAS_AUTH_HEADER => 'false',
-                    LoggerInterface::IS_CACHEABLE => 'true',
                     LoggerInterface::REQUEST_LENGTH => '',
                     LoggerInterface::HTTP_RESPONSE_CODE => 200,
                     LoggerInterface::X_MAGENTO_CACHE_ID => '1234'
@@ -259,7 +255,6 @@ public function getQueryInformationDataProvider()
                     LoggerInterface::STORE_HEADER => '1',
                     LoggerInterface::CURRENCY_HEADER => 'USD',
                     LoggerInterface::HAS_AUTH_HEADER => 'true',
-                    LoggerInterface::IS_CACHEABLE => 'false',
                     LoggerInterface::REQUEST_LENGTH => '123',
                     LoggerInterface::HAS_MUTATION => 'true',
                     LoggerInterface::NUMBER_OF_OPERATIONS => 1,
@@ -285,7 +280,6 @@ public function getQueryInformationDataProvider()
                     LoggerInterface::STORE_HEADER => '',
                     LoggerInterface::CURRENCY_HEADER => '',
                     LoggerInterface::HAS_AUTH_HEADER => 'false',
-                    LoggerInterface::IS_CACHEABLE => 'false',
                     LoggerInterface::REQUEST_LENGTH => '',
                     LoggerInterface::HAS_MUTATION => 'true',
                     LoggerInterface::NUMBER_OF_OPERATIONS => 1,
@@ -330,7 +324,6 @@ public function getQueryInformationDataProvider()
                     LoggerInterface::STORE_HEADER => '1',
                     LoggerInterface::CURRENCY_HEADER => 'USD',
                     LoggerInterface::HAS_AUTH_HEADER => 'true',
-                    LoggerInterface::IS_CACHEABLE => 'true',
                     LoggerInterface::REQUEST_LENGTH => '123',
                     LoggerInterface::HAS_MUTATION => 'false',
                     LoggerInterface::NUMBER_OF_OPERATIONS => 2,