ACP2E-1784: fix static and unit tests' errors

Author: alzota

app/code/Magento/Wishlist/Helper/Data.php

@@ -13,6 +13,7 @@
 use Magento\Framework\App\ObjectManager;
 use Magento\Framework\DataObject;
 use Magento\Framework\Escaper;
+use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Wishlist\Controller\WishlistProviderInterface;
 use Magento\Wishlist\Model\Item;
@@ -643,11 +644,12 @@ public function isDisplayQty()
     /**
      * Retrieve URL to item Product
      *
-     * @param  \Magento\Wishlist\Model\Item|\Magento\Catalog\Model\Product $item
-     * @param  array $additional
+     * @param Item|Product $item
      * @return string
+     * @throws NoSuchEntityException
+     * @throws LocalizedException
      */
-    public function getProductUrl($item, $additional = [])
+    public function getProductUrl($item): string
     {
         if ($item instanceof \Magento\Catalog\Model\Product) {
             $product = $item;
@@ -669,6 +671,8 @@ public function getProductUrl($item, $additional = [])
     }
 
     /**
+     * Generate query params from product options
+     *
      * @param Item|Product $item
      * @return array
      * @throws NoSuchEntityException

app/code/Magento/Wishlist/Test/Unit/Helper/DataTest.php

@@ -13,6 +13,7 @@
 use Magento\Framework\App\Helper\Context;
 use Magento\Framework\App\RequestInterface;
 use Magento\Framework\Data\Helper\PostHelper;
+use Magento\Framework\DataObject;
 use Magento\Framework\Registry;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Framework\Url\EncoderInterface;
@@ -186,11 +187,27 @@ public function testGetConfigureUrl()
     {
         $url = 'http://magento2ce/wishlist/index/configure/id/4/product_id/30/qty/1000';
 
+        $buyRequest = $this->getMockBuilder(DataObject::class)
+            ->addMethods(['getSuperAttribute', 'getQty'])
+            ->disableOriginalConstructor()
+            ->getMock();
+        $buyRequest->expects($this->once())
+            ->method('getSuperAttribute')
+            ->willReturn(['100' => '10']);
+        $buyRequest->expects($this->exactly(2))
+            ->method('getQty')
+            ->willReturn('1000');
+
         /** @var WishlistItem|MockObject $wishlistItem */
         $wishlistItem = $this->getMockBuilder(WishlistItem::class)
             ->addMethods(['getWishlistItemId', 'getProductId', 'getQty'])
+            ->onlyMethods(['getBuyRequest'])
             ->disableOriginalConstructor()
             ->getMock();
+        $wishlistItem
+            ->expects($this->once())
+            ->method('getBuyRequest')
+            ->willReturn($buyRequest);
         $wishlistItem
             ->expects($this->once())
             ->method('getWishlistItemId')
@@ -209,7 +226,7 @@ public function testGetConfigureUrl()
             ->with('wishlist/index/configure', ['id' => 4, 'product_id' => 30, 'qty' => 1000])
             ->willReturn($url);
 
-        $this->assertEquals($url, $this->model->getConfigureUrl($wishlistItem));
+        $this->assertEquals($url . '#100=10', $this->model->getConfigureUrl($wishlistItem));
     }
 
     public function testGetWishlist()