PWA-1311: New Relic is not being given useful transaction names for graphql requests

 - update handling query parse errors

Author: cspruiell

app/code/Magento/GraphQl/Helper/Query/Logger/LogData.php

@@ -40,10 +40,13 @@ public function getLogData(
     ) : array {
         $logData = [];
         $logData = array_merge($logData, $this->gatherRequestInformation($request));
-        if ($schema) {
-            $logData = array_merge($logData, $this->gatherQueryInformation($schema));
+        $complexity = $this->getFieldCount($data['query'] ?? '');
+        if ($complexity !== -1) {
+            $logData[LoggerInterface::COMPLEXITY] = $complexity;
+            if ($schema) {
+                $logData = array_merge($logData, $this->gatherQueryInformation($schema));
+            }
         }
-        $logData[LoggerInterface::COMPLEXITY] = $this->getFieldCount($data['query'] ?? '');
         if ($response) {
             $logData = array_merge($logData, $this->gatherResponseInformation($response));
         }
@@ -129,8 +132,8 @@ private function getFieldCount(string $query): int
                 );
                 return $totalFieldCount;
             }
-        } catch (SyntaxError $syntaxError) {
         } catch (\Exception $exception) {
+            return -1;
         }
         return 0;
     }

dev/tests/integration/testsuite/Magento/GraphQl/Helper/Query/Logger/LogDataTest.php

@@ -204,6 +204,32 @@ public function getQueryInformationDataProvider()
                     LoggerInterface::HTTP_RESPONSE_CODE => 200
                 ]
             ],
+            [ // bad query
+                'query' => <<<QUERY
+ {
+    xyz()
+    {
+        dfsfa
+            sku
+        }
+    }
+ }
+QUERY,
+                'headers' => [
+                    'response' => [
+                        'X-Magento-Tags' => 'FPC'
+                    ]
+                ],
+                'expectedResult' => [
+                    LoggerInterface::HTTP_METHOD => 'POST',
+                    LoggerInterface::STORE_HEADER => '',
+                    LoggerInterface::CURRENCY_HEADER => '',
+                    LoggerInterface::HAS_AUTH_HEADER => 'false',
+                    LoggerInterface::IS_CACHEABLE => 'true',
+                    LoggerInterface::REQUEST_LENGTH => '',
+                    LoggerInterface::HTTP_RESPONSE_CODE => 200
+                ]
+            ],
             [ // mutation with all headers
                 'query' => <<<QUERY
 mutation {