LYNX-412: Fix post code not being removed in estimateTotals

Author: svera

app/code/Magento/QuoteGraphQl/Model/Resolver/EstimateTotals.php

@@ -18,6 +18,7 @@
 use Magento\Quote\Api\CartRepositoryInterface;
 use Magento\Quote\Api\Data\AddressInterface;
 use Magento\Quote\Model\MaskedQuoteIdToQuoteIdInterface;
+use Magento\Quote\Model\Quote\Address;
 use Magento\Quote\Model\Quote\AddressFactory;
 
 /**
@@ -69,7 +70,8 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
             throw new GraphQlInputException(__('Required parameter "country_code" is missing'));
         }
 
-        $this->totalsInformationManagement->calculate($cartId, $this->getTotalsInformation($args['input']));
+        $data = $this->getTotalsInformation($args['input']);
+        $this->totalsInformationManagement->calculate($cartId, $data);
 
         return [
             'cart' => [
@@ -106,14 +108,14 @@ private function getTotalsInformation(array $input): TotalsInformationInterface
      */
     private function getAddress(array $data): AddressInterface
     {
-        $data = [
-            AddressInterface::KEY_COUNTRY_ID => $data['country_code'],
-            AddressInterface::KEY_REGION => $data['region'][AddressInterface::KEY_REGION] ?? null,
-            AddressInterface::KEY_REGION_ID => $data['region'][AddressInterface::KEY_REGION_ID] ?? null,
-            AddressInterface::KEY_REGION_CODE => $data['region'][AddressInterface::KEY_REGION_CODE] ?? null,
-            AddressInterface::KEY_POSTCODE => $data[AddressInterface::KEY_POSTCODE] ?? null,
-        ];
+        /** @var Address $address */
+        $address = $this->addressFactory->create();
+        $address->setCountryId($data['country_code']);
+        $address->setRegion($data['region'][AddressInterface::KEY_REGION] ?? null);
+        $address->setRegionId($data['region'][AddressInterface::KEY_REGION_ID] ?? null);
+        $address->setRegionCode($data['region'][AddressInterface::KEY_REGION_CODE] ?? null);
+        $address->setPostcode($data[AddressInterface::KEY_POSTCODE] ?? null);
 
-        return $this->addressFactory->create(['data' => array_filter($data)]);
+        return $address;
     }
 }

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/EstimateTotalsTest.php

@@ -117,6 +117,117 @@ public function testEstimateTotals(string $countryCode, string $shipping, array
         );
     }
 
+    /**
+     * @return void
+     * @throws LocalizedException
+     */
+    #[
+        DataFixture(
+            ProductTaxClass::class,
+            as: 'product_tax_class'
+        ),
+        DataFixture(
+            TaxRateFixture::class,
+            [
+                'tax_country_id' => 'ES',
+                'tax_postcode' => '08005',
+            ],
+            'rate'
+        ),
+        DataFixture(
+            TaxRuleFixture::class,
+            [
+                'customer_tax_class_ids' => [3],
+                'product_tax_class_ids' => ['$product_tax_class.classId$'],
+                'tax_rate_ids' => ['$rate.id$']
+            ],
+            'rule'
+        ),
+        DataFixture(
+            ProductFixture::class,
+            [
+                'custom_attributes' => [
+                    'tax_class_id' => '$product_tax_class.classId$'
+                ],
+            ],
+            'product'
+        ),
+        DataFixture(GuestCart::class, ['currency' => 'USD'], 'cart'),
+        DataFixture(QuoteIdMask::class, ['cart_id' => '$cart.id$'], 'quoteIdMask'),
+        DataFixture(AddProductToCart::class, [
+            'cart_id' => '$cart.id$',
+            'product_id' => '$product.id$',
+            'qty' => 1
+        ])
+    ]
+    public function testEstimateTotalsCleanPostCode(): void
+    {
+        $maskedQuoteId = DataFixtureStorageManager::getStorage()->get('quoteIdMask')->getMaskedId();
+
+        $query = <<<QUERY
+        mutation {
+  estimateTotals(input: {
+    cart_id: "{$maskedQuoteId}",
+    address: {
+      country_code: ES
+      postcode: "%s"
+    },
+    shipping_method: {
+      carrier_code: "flatrate",
+      method_code: "flatrate"
+    }
+  }) {
+    cart {
+      prices {
+        applied_taxes {
+          amount {
+            value
+            currency
+          }
+        }
+      }
+    }
+  }
+}
+QUERY;
+        $response = $this->graphQlMutation(sprintf($query, '08005'));
+
+        self::assertEquals(
+            [
+                'estimateTotals' => [
+                    'cart' => [
+                        'prices' => [
+                            'applied_taxes' => [
+                                [
+                                    'amount' => [
+                                        'value' => 1,
+                                        'currency' => 'USD'
+                                    ]
+                                ]
+                            ]
+                        ]
+                    ]
+                ]
+            ],
+            $response
+        );
+
+        $response = $this->graphQlMutation(sprintf($query, ''));
+
+        self::assertEquals(
+            [
+                'estimateTotals' => [
+                    'cart' => [
+                        'prices' => [
+                            'applied_taxes' => []
+                        ]
+                    ]
+                ]
+            ],
+            $response
+        );
+    }
+
     public function estimationsProvider(): array
     {
         return [