39236: Fixed Static Test Failures and added Unit Test case for LocalizedToNormalized

Author: engcom-Dash

app/code/Magento/Checkout/Test/Unit/Model/SidebarTest.php

@@ -140,19 +140,25 @@ public function testRemoveQuoteItem()
         $this->assertEquals($this->sidebar, $this->sidebar->removeQuoteItem($itemId));
     }
 
-    public function testUpdateQuoteItem()
+    /**
+     * @param string $locale
+     * @param int|string $itemId
+     * @param int|string|float $expectedItemQty
+     * @param int|string|float $itemQty
+     *
+     * @dataProvider dataProviderUpdateQuoteItem
+     */
+    public function testUpdateQuoteItem($locale, $itemId, $expectedItemQty ,$itemQty)
     {
-        $itemId = 1;
-        $itemQty = 2;
-
         $this->resolverMock->expects($this->once())
             ->method('getLocale')
-            ->willReturn('en');
+            ->willReturn($locale);
 
         $this->cartMock->expects($this->once())
             ->method('updateItems')
-            ->with([$itemId => ['qty' => $itemQty]])
+            ->with([$itemId => ['qty' => $expectedItemQty]])
             ->willReturnSelf();
+
         $this->cartMock->expects($this->once())
             ->method('save')
             ->willReturnSelf();
@@ -178,4 +184,18 @@ public function testUpdateQuoteItemWithZeroQty()
 
         $this->assertEquals($this->sidebar, $this->sidebar->updateQuoteItem($itemId, $itemQty));
     }
+
+    /**
+     * @return array
+     */
+    public static function dataProviderUpdateQuoteItem()
+    {
+        return [
+            //locale, itemId, expectedItemQty, ItemQty
+            [ 'en_US', 1, 2, 2],
+            [ 'en_US', 1, 0.5, 0.5],
+            [ 'en_US', 1,"0.5","0.5"],
+            [ 'nl_NL', 1,"0.5","0,5"]
+        ];
+    }
 }

lib/internal/Magento/Framework/Filter/LocalizedToNormalized.php

@@ -70,7 +70,9 @@ public function filter($value)
         if (is_numeric($value)) {
             $numberParse = new NumberParse(
                 $this->_options['locale'],
-                empty($this->_options['decimal_style']) ? NumberFormatter::PATTERN_DECIMAL : $this->_options['decimal_style']
+                empty($this->_options['decimal_style'])
+                ? NumberFormatter::PATTERN_DECIMAL
+                : $this->_options['decimal_style']
             );
             return (string)$numberParse->filter($value);
         } elseif ($this->_options['date_format'] === null && strpos($value, ':') !== false) {
@@ -198,7 +200,6 @@ private function parseDate($date)
             }
             ++$cnt;
         }
-
         return $result;
     }
 }

lib/internal/Magento/Framework/Filter/Test/Unit/LocalizedToNormalizedTest.php

@@ -0,0 +1,75 @@
+<?php
+/**
+ * Copyright 2025 Adobe
+ * All Rights Reserved.
+ */
+declare(strict_types=1);
+
+namespace Magento\Framework\Filter\Test\Unit;
+
+use Magento\Framework\Filter\LocalizedToNormalized;
+use PHPUnit\Framework\TestCase;
+use NumberFormatter;
+
+class LocalizedToNormalizedTest extends TestCase
+{
+
+    /**
+     * @param string $value
+     * @param array $options
+     * @param string|array $expectedValues
+     * 
+     * @dataProvider localizedToNormalizedDataProvider
+     */
+    public function testLocalizedToNormalized($value, $options, $expectedValue)
+    {
+        $filter = new LocalizedToNormalized($options);
+        $this->assertEquals($expectedValue, $filter->filter($value));
+    }
+
+    /**
+     * @return array
+     */
+    public static function localizedToNormalizedDataProvider()
+    {
+        
+        return [
+            '1' => [
+                "0.5",
+                [
+                    'locale' => 'nl',
+                    'date_format' => null,
+                    'precision' => null,
+                    'decimal_style' => NumberFormatter::PATTERN_DECIMAL
+                ],
+                "0.5"
+            ],
+            '2' => [
+                "0.5",
+                [
+                    'locale' => 'en',
+                    'date_format' => null,
+                    'precision' => null,
+                    'decimal_style' => ' '
+                ],
+                "0.5"
+            ],
+            '3' => [
+                '2014-03-30',
+                [
+                    'locale' => 'en',
+                    'date_format' => 'Y-M-d',
+                    'precision' => null,
+                    'decimal_style' => ''
+                ],
+                [
+                    "date_format" => "Y-M-d",
+                    "locale" => "en",
+                    "year" => "2014",
+                    "month" => "03",
+                    "day" => "30",
+                ]
+            ]
+        ];
+    }
+}