Added Unit Test cases for both Validated value & value

engcom-Dash · engcom-Dash · commit 922951b3175f · 2025-03-18T11:59:50.000+05:30
diff --git a/app/code/Magento/Rule/Model/Condition/AbstractCondition.php b/app/code/Magento/Rule/Model/Condition/AbstractCondition.php
@@ -885,7 +885,7 @@ public function validateAttribute($validatedValue)
     protected function _compareValues($validatedValue, $value, $strict = true)
     {
         if ($strict && is_numeric($validatedValue) && is_numeric($value)) {
-            if (preg_match('/^0\d+$/', $validatedValue)) {
+            if (preg_match('/^0\d+$/', $validatedValue) || preg_match('/^0\d+$/', $value)) {
                 return $validatedValue === $value;
             }
             return $validatedValue == $value;
diff --git a/app/code/Magento/Rule/Test/Unit/Model/Condition/AbstractConditionTest.php b/app/code/Magento/Rule/Test/Unit/Model/Condition/AbstractConditionTest.php
@@ -65,6 +65,9 @@ public static function validateAttributeDataProvider()
             [null, '==', 0, false],
             [null, '==', 0.00, false],
 
+            ['0123', '===', '123', false],
+            ['123', '===', '0123', false],
+
             [1, '!=', 1, false],
             [0, '!=', 1, true],
             ['0', '!=', 1, true],

Original file line number	Diff line number	Diff line change
`@@ -885,7 +885,7 @@ public function validateAttribute($validatedValue)`
`885`	`885`	`protected function _compareValues($validatedValue, $value, $strict = true)`
`886`	`886`	`{`
`887`	`887`	`if ($strict && is_numeric($validatedValue) && is_numeric($value)) {`
`888`		`- if (preg_match('/^0\d+$/', $validatedValue)) {`
	`888`	`+ if (preg_match('/^0\d+$/', $validatedValue) \|\| preg_match('/^0\d+$/', $value)) {`
`889`	`889`	`return $validatedValue === $value;`
`890`	`890`	`}`
`891`	`891`	`return $validatedValue == $value;`