ACPT-1052: Some Luma Storefront Scenarios Are Broken

 - fix  failed tests

Author: andimov

app/code/Magento/Catalog/Model/CategoryRepository.php

@@ -234,7 +234,8 @@ protected function validateCategory(Category $category)
      *
      * @return ExtensibleDataObjectConverter
      *
-     * @deprecated 101.0.0 @see we don't recommend this approach anymore
+     * @deprecated 101.0.0
+     * @see we don't recommend this approach anymore
      */
     private function getExtensibleDataObjectConverter()
     {

app/code/Magento/Catalog/Model/ResourceModel/Attribute/WebsiteAttributesSynchronizer.php

@@ -186,7 +186,7 @@ private function markSynchronized()
      * @param string $tableName
      * @return void
      */
-    private function synchronizeTable($tableName)
+    private function synchronizeTable(string $tableName): void
     {
         foreach ($this->fetchAttributeValues($tableName) as $attributeValueItems) {
             $this->processAttributeValues($attributeValueItems, $tableName);
@@ -359,7 +359,7 @@ private function getAttributeValueKey($entityId, $attributeId, $websiteId)
     }
 
     /**
-     * generate insertions for attribute value
+     * Generate insertions for attribute value
      *
      * @param array $attributeValue
      * @param string $tableName

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/Websites/Collection.php

@@ -141,6 +141,6 @@ private function fetch() : array
     public function _resetState(): void
     {
         $this->productIds = [];
-        $this->website = [];
+        $this->websites = [];
     }
 }

app/code/Magento/CatalogUrlRewrite/Model/Category/ChildrenCategoriesProvider.php

@@ -32,6 +32,8 @@ public function getChildren(Category $category, $recursive = false)
     }
 
     /**
+     * Retrieve category children ids
+     *
      * @param \Magento\Catalog\Model\Category $category
      * @param boolean $recursive
      * @return int[]

app/code/Magento/CatalogUrlRewrite/Model/Map/DataCategoryUsedInProductsHashMap.php

@@ -41,8 +41,7 @@ public function __construct(
     }
 
     /**
-     * Returns an array of product ids for all DataProductHashMap list,
-     * that occur in other categories not part of DataCategoryHashMap list
+     * Returns product ids for all DataProductHashMap list from other categories not part of DataCategoryHashMap list
      *
      * @param int $categoryId
      * @return array

app/code/Magento/Customer/Helper/Address.php

@@ -18,7 +18,6 @@
  * Customer address helper
  *
  * @api
- * phpcs:disable Generic.CodeAnalysis.EmptyStatement
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @since 100.0.2
  */
@@ -27,7 +26,8 @@ class Address extends \Magento\Framework\App\Helper\AbstractHelper implements Re
     /**
      * VAT Validation parameters XML paths
      */
-    public const XML_PATH_VIV_DISABLE_AUTO_ASSIGN_DEFAULT = 'customer/create_account/viv_disable_auto_group_assign_default';
+    public const XML_PATH_VIV_DISABLE_AUTO_ASSIGN_DEFAULT =
+        'customer/create_account/viv_disable_auto_group_assign_default';
 
     public const XML_PATH_VIV_ON_EACH_TRANSACTION = 'customer/create_account/viv_on_each_transaction';
 
@@ -126,6 +126,7 @@ public function __construct(
     /**
      * Addresses url
      *
+     * phpcs:ignore Generic.CodeAnalysis.EmptyStatement.DetectedFunction
      * @return void
      */
     public function getBookUrl()
@@ -135,6 +136,7 @@ public function getBookUrl()
     /**
      * Retrieve edit url.
      *
+     * phpcs:ignore Generic.CodeAnalysis.EmptyStatement.DetectedFunction
      * @return void
      */
     public function getEditUrl()
@@ -144,6 +146,7 @@ public function getEditUrl()
     /**
      * Retrieve delete url.
      *
+     * phpcs:ignore Generic.CodeAnalysis.EmptyStatement.DetectedFunction
      * @return void
      */
     public function getDeleteUrl()
@@ -153,6 +156,7 @@ public function getDeleteUrl()
     /**
      * Retrieve create url.
      *
+     * phpcs:ignore Generic.CodeAnalysis.EmptyStatement
      * @return void
      */
     public function getCreateUrl()
@@ -163,7 +167,7 @@ public function getCreateUrl()
      * Retrieve block renderer.
      *
      * @param string $renderer
-     * @return \Magento\Framework\View\Element\BlockInterface
+     * @return BlockInterface
      */
     public function getRenderer($renderer)
     {

app/code/Magento/Customer/Model/Address/AbstractAddress.php

@@ -32,6 +32,7 @@
  * @method string getPostcode()
  * @method bool getShouldIgnoreValidation()
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
  *
  * @api
  * @since 100.0.2

app/code/Magento/Eav/Model/Entity/Attribute/Source/Table.php

@@ -97,7 +97,8 @@ public function getAllOptions($withEmpty = true, $defaultValues = false)
      * Get StoreManager dependency
      *
      * @return StoreManagerInterface
-     * @deprecated 100.1.6 @see we don't recommend this approach anymore
+     * @deprecated 100.1.6
+     * @see we don't recommend this approach anymore
      */
     private function getStoreManager()
     {

app/code/Magento/Tax/Model/TaxCalculation.php

@@ -287,6 +287,7 @@ protected function processItem(
      * @param TaxDetailsItemInterface[] $children
      * @param int $quantity
      * @return TaxDetailsItemInterface
+     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
      */
     protected function calculateParent($children, $quantity)
     {

dev/tests/api-functional/framework/Magento/TestFramework/Annotation/ApiConfigFixture.php

@@ -19,6 +19,7 @@
 
 /**
  * @inheritDoc
+ * @SuppressWarnings(PHPMD.NPathComplexity)
  */
 class ApiConfigFixture extends ConfigFixture
 {