ECP-530: Static test to detect external project dependencies

paliarush · paliarush · commit 90e2924b753c · 2020-04-15T17:06:26.000-05:00
diff --git a/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/Dependency/DbRuleTest.php b/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/Dependency/DbRuleTest.php
@@ -37,7 +37,7 @@ public function getDependencyInfoDataProvider()
                 'any',
                 '/app/some/path/Setup/some-file.php',
                 '$install->getTableName("unknown_table")',
-                [['module' => 'Unknown', 'source' => 'unknown_table']]
+                [['modules' => ['Unknown'], 'source' => 'unknown_table']]
             ],
             [
                 'SomeModule',
@@ -51,7 +51,7 @@ public function getDependencyInfoDataProvider()
                 '$install->getTableName("some_table")',
                 [
                     [
-                        'module' => 'SomeModule',
+                        'modules' => ['SomeModule'],
                         'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_HARD,
                         'source' => 'some_table',
                     ]
diff --git a/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/Dependency/DiRuleTest.php b/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/Dependency/DiRuleTest.php
@@ -48,32 +48,32 @@ public function getDependencyInfoDataProvider()
                 $this->getFileContent('di_external_dependency.xml'),
                 [
                     [
-                        'module' => 'Magento\ExternalModule3',
+                        'modules' => ['Magento\ExternalModule3'],
                         'type' => RuleInterface::TYPE_SOFT,
                         'source' => 'Magento\ExternalModule3\Some\Another\Class'
                     ],
                     [
-                        'module' => 'Magento\ExternalModule5',
+                        'modules' => ['Magento\ExternalModule5'],
                         'type' => RuleInterface::TYPE_SOFT,
                         'source' => 'Magento\ExternalModule5\Some\Another\Class'
                     ],
                     [
-                        'module' => 'Magento\ExternalModule6',
+                        'modules' => ['Magento\ExternalModule6'],
                         'type' => RuleInterface::TYPE_SOFT,
                         'source' => 'Magento\ExternalModule6\Some\Plugin\Class'
                     ],
                     [
-                        'module' => 'Magento\ExternalModule1',
+                        'modules' => ['Magento\ExternalModule1'],
                         'type' => RuleInterface::TYPE_HARD,
                         'source' => 'Magento\ExternalModule1\Some\Argument1'
                     ],
                     [
-                        'module' => 'Magento\ExternalModule2',
+                        'modules' => ['Magento\ExternalModule2'],
                         'type' => RuleInterface::TYPE_HARD,
                         'source' => 'Magento\ExternalModule2\Some\Argument2'
                     ],
                     [
-                        'module' => 'Magento\ExternalModule4',
+                        'modules' => ['Magento\ExternalModule4'],
                         'type' => RuleInterface::TYPE_HARD,
                         'source' => 'Magento\ExternalModule4\Some\Argument3'
                     ]
@@ -84,12 +84,12 @@ public function getDependencyInfoDataProvider()
                 $this->getFileContent('di_virtual_dependency.xml'),
                 [
                     [
-                        'module' => 'Magento\AnotherModule',
+                        'modules' => ['Magento\AnotherModule'],
                         'type' => RuleInterface::TYPE_HARD,
                         'source' => 'Magento\AnotherModule\Some\Class1',
                     ],
                     [
-                        'module' => 'Magento\AnotherModule',
+                        'modules' => ['Magento\AnotherModule'],
                         'type' => RuleInterface::TYPE_HARD,
                         'source' => 'Magento\AnotherModule\Some\Class2',
                     ]
diff --git a/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/Dependency/LayoutRuleTest.php b/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/Dependency/LayoutRuleTest.php
@@ -32,7 +32,7 @@ public function getDependencyInfoDataProvider()
                 '<element module="Magento\AnotherModule"/>',
                 [
                     [
-                        'module' => 'Magento\AnotherModule',
+                        'modules' => ['Magento\AnotherModule'],
                         'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,
                         'source' => '<element module="Magento\AnotherModule"/>',
                     ]
@@ -43,7 +43,7 @@ public function getDependencyInfoDataProvider()
                 '<block class="Magento\AnotherModule\Several\Chunks"/>',
                 [
                     [
-                        'module' => 'Magento\AnotherModule',
+                        'modules' => ['Magento\AnotherModule'],
                         'type' => \Magento\Test\Integrity\DependencyTest::TYPE_HARD,
                         'source' => '<block class="Magento\AnotherModule\Several\Chunks"/>',
                     ]
@@ -56,7 +56,7 @@ public function getDependencyInfoDataProvider()
                 </any>',
                 [
                     [
-                        'module' => 'Magento\AnotherModule',
+                        'modules' => ['Magento\AnotherModule'],
                         'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,
                         'source' => '<block template="Magento_AnotherModule::template/path.phtml"/>',
                     ]
@@ -67,7 +67,7 @@ public function getDependencyInfoDataProvider()
                 '<block>Magento\AnotherModule\Several\Chunks</block>',
                 [
                     [
-                        'module' => 'Magento\AnotherModule',
+                        'modules' => ['Magento\AnotherModule'],
                         'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,
                         'source' => '<block>Magento\AnotherModule\Several\Chunks</block>',
                     ]
@@ -78,7 +78,7 @@ public function getDependencyInfoDataProvider()
                 '<template>Magento_AnotherModule::template/path.phtml</template>',
                 [
                     [
-                        'module' => 'Magento\AnotherModule',
+                        'modules' => ['Magento\AnotherModule'],
                         'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,
                         'source' => '<template>Magento_AnotherModule::template/path.phtml</template>',
                     ]
@@ -89,7 +89,7 @@ public function getDependencyInfoDataProvider()
                 '<file>Magento_AnotherModule::file/path.txt</file>',
                 [
                     [
-                        'module' => 'Magento\AnotherModule',
+                        'modules' => ['Magento\AnotherModule'],
                         'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,
                         'source' => '<file>Magento_AnotherModule::file/path.txt</file>',
                     ]
@@ -100,7 +100,7 @@ public function getDependencyInfoDataProvider()
                 '<any helper="Magento\AnotherModule\Several\Chunks::text"/>',
                 [
                     [
-                        'module' => 'Magento\AnotherModule',
+                        'modules' => ['Magento\AnotherModule'],
                         'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,
                         'source' => '<any helper="Magento\AnotherModule\Several\Chunks::text"/>',
                     ]
@@ -120,7 +120,7 @@ public function testUpdatesRouterGetDependencyInfo($contents, $type)
         $model = new LayoutRule(['router_name' => ['Magento\RouterModule']], [], []);
         $this->assertEquals([], $model->getDependencyInfo('Magento\RouterModule', 'layout', 'any', $contents));
         $this->assertEquals(
-            [['module' => 'Magento\RouterModule', 'type' => $type, 'source' => 'router_name_action']],
+            [['modules' => ['Magento\RouterModule'], 'type' => $type, 'source' => 'router_name_action']],
             $model->getDependencyInfo('Magento\AnotherModule', 'layout', 'any', $contents)
         );
     }
@@ -148,11 +148,11 @@ public function testLayoutGetDependencyInfo($contents, $type, $isHandle)
             $model->getDependencyInfo('Magento\DefaultHandleModule', 'layout', 'any', $contents)
         );
         $this->assertEquals(
-            [['module' => 'Magento\DefaultHandleModule', 'type' => $type, 'source' => 'singlechunk']],
+            [['modules' => ['Magento\DefaultHandleModule'], 'type' => $type, 'source' => 'singlechunk']],
             $model->getDependencyInfo('any', 'layout', 'any', $contents)
         );
         $this->assertEquals(
-            [['module' => 'Magento\AnyHandleModule', 'type' => $type, 'source' => 'any_handle_name']],
+            [['modules' => ['Magento\AnyHandleModule'], 'type' => $type, 'source' => 'any_handle_name']],
             $model->getDependencyInfo('any', 'layout', 'path/frontend/file.txt', $contents)
         );
         // test several modules
@@ -166,7 +166,7 @@ public function testLayoutGetDependencyInfo($contents, $type, $isHandle)
         ];
         $model = $isHandle ? new LayoutRule([], [], $data) : new LayoutRule([], $data, []);
         $this->assertEquals(
-            [['module' => 'Magento\Theme', 'type' => $type, 'source' => 'any_handle_name']],
+            [['modules' => ['Magento\Theme'], 'type' => $type, 'source' => 'any_handle_name']],
             $model->getDependencyInfo('any', 'layout', 'path/frontend/file.txt', $contents)
         );
         $this->assertEquals(
diff --git a/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/Dependency/PhpRuleTest.php b/dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/Dependency/PhpRuleTest.php
@@ -89,7 +89,7 @@ public function getDependencyInfoDataProvider()
                 'something extends \Magento\SomeModule\Any\ClassName {',
                 [
                     [
-                        'module' => 'Magento\SomeModule',
+                        'modules' => ['Magento\SomeModule'],
                         'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_HARD,
                         'source' => 'Magento\SomeModule\Any\ClassName',
                     ]
@@ -105,7 +105,7 @@ public function getDependencyInfoDataProvider()
                 '$this->getViewFileUrl("Magento_SomeModule::js/order-by-sku-failure.js")',
                 [
                     [
-                        'module' => 'Magento\SomeModule',
+                        'modules' => ['Magento\SomeModule'],
                         'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_HARD,
                         'source' => 'Magento_SomeModule',
                     ]
@@ -121,7 +121,7 @@ public function getDependencyInfoDataProvider()
                 '$this->helper("Magento\SomeModule\Any\ClassName")',
                 [
                     [
-                        'module' => 'Magento\SomeModule',
+                        'modules' => ['Magento\SomeModule'],
                         'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_HARD,
                         'source' => 'Magento\SomeModule\Any\ClassName',
                     ]
@@ -136,7 +136,7 @@ public function getDependencyInfoDataProvider()
                 '$this->getLayout()->getBlock(\'block.name\');',
                 [
                     [
-                        'module' => 'Magento\SomeModule',
+                        'modules' => ['Magento\SomeModule'],
                         'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_HARD,
                         'source' => 'getBlock(\'block.name\')',
                     ]
@@ -157,7 +157,7 @@ public function getDependencyInfoDataProvider()
                 'Magento\Module2\Subject',
                 [
                     [
-                        'module' => 'Magento\Module2',
+                        'modules' => ['Magento\Module2'],
                         'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_SOFT,
                         'source' => 'Magento\Module2\Subject',
                     ]
@@ -168,7 +168,7 @@ public function getDependencyInfoDataProvider()
                 'Magento\Module2\NotSubject',
                 [
                     [
-                        'module' => 'Magento\Module2',
+                        'modules' => ['Magento\Module2'],
                         'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_SOFT,
                         'source' => 'Magento\Module2\NotSubject',
                     ]
@@ -179,7 +179,7 @@ public function getDependencyInfoDataProvider()
                 'Magento\OtherModule\NotSubject',
                 [
                     [
-                        'module' => 'Magento\OtherModule',
+                        'modules' => ['Magento\OtherModule'],
                         'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_HARD,
                         'source' => 'Magento\OtherModule\NotSubject',
                     ]
@@ -222,7 +222,7 @@ public function getDependencyInfoDataCaseGetUrlDataProvider()
                 '$this->getUrl("cms/index/index")',
                 [
                     [
-                        'module' => 'Magento\Cms',
+                        'modules' => ['Magento\Cms'],
                         'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_HARD,
                         'source' => 'getUrl("cms/index/index"',
                     ]
@@ -295,7 +295,7 @@ public function getDefaultModelDependencyDataProvider()
                 '$this->getLayout()->getBlock(\'block.name\');',
                 [
                     [
-                        'module' => 'Magento\SomeModule',
+                        'modules' => ['Magento\SomeModule'],
                         'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_HARD,
                         'source' => 'getBlock(\'block.name\')',
                     ]

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function getDependencyInfoDataProvider()`
`37`	`37`	`'any',`
`38`	`38`	`'/app/some/path/Setup/some-file.php',`
`39`	`39`	`'$install->getTableName("unknown_table")',`
`40`		`- [['module' => 'Unknown', 'source' => 'unknown_table']]`
	`40`	`+ [['modules' => ['Unknown'], 'source' => 'unknown_table']]`
`41`	`41`	`],`
`42`	`42`	`[`
`43`	`43`	`'SomeModule',`
`@@ -51,7 +51,7 @@ public function getDependencyInfoDataProvider()`
`51`	`51`	`'$install->getTableName("some_table")',`
`52`	`52`	`[`
`53`	`53`	`[`
`54`		`- 'module' => 'SomeModule',`
	`54`	`+ 'modules' => ['SomeModule'],`
`55`	`55`	`'type' => \Magento\TestFramework\Dependency\RuleInterface::TYPE_HARD,`
`56`	`56`	`'source' => 'some_table',`
`57`	`57`	`]`
Original file line number	Diff line number	Diff line change
`@@ -48,32 +48,32 @@ public function getDependencyInfoDataProvider()`
`48`	`48`	`$this->getFileContent('di_external_dependency.xml'),`
`49`	`49`	`[`
`50`	`50`	`[`
`51`		`- 'module' => 'Magento\ExternalModule3',`
	`51`	`+ 'modules' => ['Magento\ExternalModule3'],`
`52`	`52`	`'type' => RuleInterface::TYPE_SOFT,`
`53`	`53`	`'source' => 'Magento\ExternalModule3\Some\Another\Class'`
`54`	`54`	`],`
`55`	`55`	`[`
`56`		`- 'module' => 'Magento\ExternalModule5',`
	`56`	`+ 'modules' => ['Magento\ExternalModule5'],`
`57`	`57`	`'type' => RuleInterface::TYPE_SOFT,`
`58`	`58`	`'source' => 'Magento\ExternalModule5\Some\Another\Class'`
`59`	`59`	`],`
`60`	`60`	`[`
`61`		`- 'module' => 'Magento\ExternalModule6',`
	`61`	`+ 'modules' => ['Magento\ExternalModule6'],`
`62`	`62`	`'type' => RuleInterface::TYPE_SOFT,`
`63`	`63`	`'source' => 'Magento\ExternalModule6\Some\Plugin\Class'`
`64`	`64`	`],`
`65`	`65`	`[`
`66`		`- 'module' => 'Magento\ExternalModule1',`
	`66`	`+ 'modules' => ['Magento\ExternalModule1'],`
`67`	`67`	`'type' => RuleInterface::TYPE_HARD,`
`68`	`68`	`'source' => 'Magento\ExternalModule1\Some\Argument1'`
`69`	`69`	`],`
`70`	`70`	`[`
`71`		`- 'module' => 'Magento\ExternalModule2',`
	`71`	`+ 'modules' => ['Magento\ExternalModule2'],`
`72`	`72`	`'type' => RuleInterface::TYPE_HARD,`
`73`	`73`	`'source' => 'Magento\ExternalModule2\Some\Argument2'`
`74`	`74`	`],`
`75`	`75`	`[`
`76`		`- 'module' => 'Magento\ExternalModule4',`
	`76`	`+ 'modules' => ['Magento\ExternalModule4'],`
`77`	`77`	`'type' => RuleInterface::TYPE_HARD,`
`78`	`78`	`'source' => 'Magento\ExternalModule4\Some\Argument3'`
`79`	`79`	`]`
`@@ -84,12 +84,12 @@ public function getDependencyInfoDataProvider()`
`84`	`84`	`$this->getFileContent('di_virtual_dependency.xml'),`
`85`	`85`	`[`
`86`	`86`	`[`
`87`		`- 'module' => 'Magento\AnotherModule',`
	`87`	`+ 'modules' => ['Magento\AnotherModule'],`
`88`	`88`	`'type' => RuleInterface::TYPE_HARD,`
`89`	`89`	`'source' => 'Magento\AnotherModule\Some\Class1',`
`90`	`90`	`],`
`91`	`91`	`[`
`92`		`- 'module' => 'Magento\AnotherModule',`
	`92`	`+ 'modules' => ['Magento\AnotherModule'],`
`93`	`93`	`'type' => RuleInterface::TYPE_HARD,`
`94`	`94`	`'source' => 'Magento\AnotherModule\Some\Class2',`
`95`	`95`	`]`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public function getDependencyInfoDataProvider()`
`32`	`32`	`'<element module="Magento\AnotherModule"/>',`
`33`	`33`	`[`
`34`	`34`	`[`
`35`		`- 'module' => 'Magento\AnotherModule',`
	`35`	`+ 'modules' => ['Magento\AnotherModule'],`
`36`	`36`	`'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,`
`37`	`37`	`'source' => '<element module="Magento\AnotherModule"/>',`
`38`	`38`	`]`
`@@ -43,7 +43,7 @@ public function getDependencyInfoDataProvider()`
`43`	`43`	`'<block class="Magento\AnotherModule\Several\Chunks"/>',`
`44`	`44`	`[`
`45`	`45`	`[`
`46`		`- 'module' => 'Magento\AnotherModule',`
	`46`	`+ 'modules' => ['Magento\AnotherModule'],`
`47`	`47`	`'type' => \Magento\Test\Integrity\DependencyTest::TYPE_HARD,`
`48`	`48`	`'source' => '<block class="Magento\AnotherModule\Several\Chunks"/>',`
`49`	`49`	`]`
`@@ -56,7 +56,7 @@ public function getDependencyInfoDataProvider()`
`56`	`56`	`</any>',`
`57`	`57`	`[`
`58`	`58`	`[`
`59`		`- 'module' => 'Magento\AnotherModule',`
	`59`	`+ 'modules' => ['Magento\AnotherModule'],`
`60`	`60`	`'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,`
`61`	`61`	`'source' => '<block template="Magento_AnotherModule::template/path.phtml"/>',`
`62`	`62`	`]`
`@@ -67,7 +67,7 @@ public function getDependencyInfoDataProvider()`
`67`	`67`	`'<block>Magento\AnotherModule\Several\Chunks</block>',`
`68`	`68`	`[`
`69`	`69`	`[`
`70`		`- 'module' => 'Magento\AnotherModule',`
	`70`	`+ 'modules' => ['Magento\AnotherModule'],`
`71`	`71`	`'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,`
`72`	`72`	`'source' => '<block>Magento\AnotherModule\Several\Chunks</block>',`
`73`	`73`	`]`
`@@ -78,7 +78,7 @@ public function getDependencyInfoDataProvider()`
`78`	`78`	`'<template>Magento_AnotherModule::template/path.phtml</template>',`
`79`	`79`	`[`
`80`	`80`	`[`
`81`		`- 'module' => 'Magento\AnotherModule',`
	`81`	`+ 'modules' => ['Magento\AnotherModule'],`
`82`	`82`	`'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,`
`83`	`83`	`'source' => '<template>Magento_AnotherModule::template/path.phtml</template>',`
`84`	`84`	`]`
`@@ -89,7 +89,7 @@ public function getDependencyInfoDataProvider()`
`89`	`89`	`'<file>Magento_AnotherModule::file/path.txt</file>',`
`90`	`90`	`[`
`91`	`91`	`[`
`92`		`- 'module' => 'Magento\AnotherModule',`
	`92`	`+ 'modules' => ['Magento\AnotherModule'],`
`93`	`93`	`'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,`
`94`	`94`	`'source' => '<file>Magento_AnotherModule::file/path.txt</file>',`
`95`	`95`	`]`
`@@ -100,7 +100,7 @@ public function getDependencyInfoDataProvider()`
`100`	`100`	`'<any helper="Magento\AnotherModule\Several\Chunks::text"/>',`
`101`	`101`	`[`
`102`	`102`	`[`
`103`		`- 'module' => 'Magento\AnotherModule',`
	`103`	`+ 'modules' => ['Magento\AnotherModule'],`
`104`	`104`	`'type' => \Magento\Test\Integrity\DependencyTest::TYPE_SOFT,`
`105`	`105`	`'source' => '<any helper="Magento\AnotherModule\Several\Chunks::text"/>',`
`106`	`106`	`]`
`@@ -120,7 +120,7 @@ public function testUpdatesRouterGetDependencyInfo($contents, $type)`
`120`	`120`	`$model = new LayoutRule(['router_name' => ['Magento\RouterModule']], [], []);`
`121`	`121`	`$this->assertEquals([], $model->getDependencyInfo('Magento\RouterModule', 'layout', 'any', $contents));`
`122`	`122`	`$this->assertEquals(`
`123`		`- [['module' => 'Magento\RouterModule', 'type' => $type, 'source' => 'router_name_action']],`
	`123`	`+ [['modules' => ['Magento\RouterModule'], 'type' => $type, 'source' => 'router_name_action']],`
`124`	`124`	`$model->getDependencyInfo('Magento\AnotherModule', 'layout', 'any', $contents)`
`125`	`125`	`);`
`126`	`126`	`}`
`@@ -148,11 +148,11 @@ public function testLayoutGetDependencyInfo($contents, $type, $isHandle)`
`148`	`148`	`$model->getDependencyInfo('Magento\DefaultHandleModule', 'layout', 'any', $contents)`
`149`	`149`	`);`
`150`	`150`	`$this->assertEquals(`
`151`		`- [['module' => 'Magento\DefaultHandleModule', 'type' => $type, 'source' => 'singlechunk']],`
	`151`	`+ [['modules' => ['Magento\DefaultHandleModule'], 'type' => $type, 'source' => 'singlechunk']],`
`152`	`152`	`$model->getDependencyInfo('any', 'layout', 'any', $contents)`
`153`	`153`	`);`
`154`	`154`	`$this->assertEquals(`
`155`		`- [['module' => 'Magento\AnyHandleModule', 'type' => $type, 'source' => 'any_handle_name']],`
	`155`	`+ [['modules' => ['Magento\AnyHandleModule'], 'type' => $type, 'source' => 'any_handle_name']],`
`156`	`156`	`$model->getDependencyInfo('any', 'layout', 'path/frontend/file.txt', $contents)`
`157`	`157`	`);`
`158`	`158`	`// test several modules`
`@@ -166,7 +166,7 @@ public function testLayoutGetDependencyInfo($contents, $type, $isHandle)`
`166`	`166`	`];`
`167`	`167`	`$model = $isHandle ? new LayoutRule([], [], $data) : new LayoutRule([], $data, []);`
`168`	`168`	`$this->assertEquals(`
`169`		`- [['module' => 'Magento\Theme', 'type' => $type, 'source' => 'any_handle_name']],`
	`169`	`+ [['modules' => ['Magento\Theme'], 'type' => $type, 'source' => 'any_handle_name']],`
`170`	`170`	`$model->getDependencyInfo('any', 'layout', 'path/frontend/file.txt', $contents)`
`171`	`171`	`);`
`172`	`172`	`$this->assertEquals(`