ACPT-1413

Removed getProcessConnectionName from lib/internal/Magento/Framework/App/ResourceConnection.php
We cannot have separate connections in this class based on the process id.  The reason is that because some objects have references to the connection object before the fork, and therefore the child would be accessing a different data connection in some classes,  which could break the expected transaction functionality.  In other words, the getProcessConnectionName functionality did not work in cases where objects used by child process had a member variable to the parent process's connection (Mysql Adapter).

We added avoidReusingParentProcessConnection() in Mysql adapter to avoid using the parent's connection.

Author: JacobBrownAustin

lib/internal/Magento/Framework/App/ResourceConnection.php

@@ -128,7 +128,7 @@ public function closeConnection($resourceName = self::DEFAULT_CONNECTION)
             }
             $this->connections = [];
         } else {
-            $processConnectionName = $this->getProcessConnectionName($this->config->getConnectionName($resourceName));
+            $processConnectionName = $this->config->getConnectionName($resourceName);
             if (isset($this->connections[$processConnectionName])) {
                 if ($this->connections[$processConnectionName] !== null) {
                     $this->connections[$processConnectionName]->closeConnection();
@@ -147,9 +147,8 @@ public function closeConnection($resourceName = self::DEFAULT_CONNECTION)
      */
     public function getConnectionByName($connectionName)
     {
-        $processConnectionName = $this->getProcessConnectionName($connectionName);
-        if (isset($this->connections[$processConnectionName])) {
-            return $this->connections[$processConnectionName];
+        if (isset($this->connections[$connectionName])) {
+            return $this->connections[$connectionName];
         }
 
         $connectionConfig = $this->deploymentConfig->get(
@@ -162,26 +161,10 @@ public function getConnectionByName($connectionName)
             throw new \DomainException('Connection "' . $connectionName . '" is not defined');
         }
 
-        $this->connections[$processConnectionName] = $connection;
+        $this->connections[$connectionName] = $connection;
         return $connection;
     }
 
-    /**
-     * Get conneciton name for process.
-     *
-     * @param string $connectionName
-     * @return string
-     */
-    private function getProcessConnectionName($connectionName)
-    {
-        // Note: We cannot have separate connections in this class based ond the process id.
-        // The reason is because some objects have references to the connection object before the fork,
-        // and therefore the child would be accessing a different data connection in some classes,  which could break
-        // the expected transaction functionality.
-        // We added avoidReusingParentProcessConnection() in Mysql adapter to avoid using the parent's connection.
-        return $connectionName;
-    }
-
     /**
      * Get resource table name, validated by db adapter.
      *