Fixed static test failures

engcom-Echo · engcom-Echo · commit 865f770f1ebd · 2024-06-20T07:17:25.000+05:30
diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Refunded.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Refunded.php
@@ -21,7 +21,7 @@ class Refunded extends \Magento\Backend\Block\Widget\Grid\Container
     protected $_template = 'Magento_Reports::report/grid/container.phtml';
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     protected function _construct()
     {
diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Sales.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Sales.php
@@ -21,7 +21,7 @@ class Sales extends \Magento\Backend\Block\Widget\Grid\Container
     protected $_template = 'Magento_Reports::report/grid/container.phtml';
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     protected function _construct()
     {
diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Shipping.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Shipping.php
@@ -21,7 +21,7 @@ class Shipping extends \Magento\Backend\Block\Widget\Grid\Container
     protected $_template = 'Magento_Reports::report/grid/container.phtml';
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     protected function _construct()
     {
diff --git a/app/code/Magento/Reports/Block/Adminhtml/Sales/Tax.php b/app/code/Magento/Reports/Block/Adminhtml/Sales/Tax.php
@@ -21,7 +21,7 @@ class Tax extends \Magento\Backend\Block\Widget\Grid\Container
     protected $_template = 'Magento_Reports::report/grid/container.phtml';
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     protected function _construct()
     {
diff --git a/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Abandoned.php b/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Abandoned.php
@@ -11,6 +11,8 @@
 class Abandoned extends \Magento\Backend\Block\Widget\Grid\Container
 {
     /**
+     * Initialize
+     *
      * @return void
      */
     protected function _construct()
diff --git a/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Customer.php b/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Customer.php
@@ -11,6 +11,8 @@
 class Customer extends \Magento\Backend\Block\Widget\Grid\Container
 {
     /**
+     * Initialize
+     *
      * @return void
      */
     protected function _construct()
diff --git a/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Customer/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Customer/Grid.php
@@ -34,6 +34,8 @@ public function __construct(
     }
 
     /**
+     * Initialize
+     *
      * @return void
      */
     protected function _construct()
@@ -43,6 +45,8 @@ protected function _construct()
     }
 
     /**
+     * Prepare collection
+     *
      * @return \Magento\Backend\Block\Widget\Grid
      */
     protected function _prepareCollection()
@@ -59,6 +63,8 @@ protected function _prepareCollection()
     }
 
     /**
+     * After load collection
+     *
      * @return \Magento\Backend\Block\Widget\Grid|void
      */
     protected function _afterLoadCollection()
@@ -67,6 +73,8 @@ protected function _afterLoadCollection()
     }
 
     /**
+     * Prepare columns
+     *
      * @return \Magento\Backend\Block\Widget\Grid\Extended
      */
     protected function _prepareColumns()
diff --git a/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Product.php b/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Product.php
@@ -11,6 +11,8 @@
 class Product extends \Magento\Backend\Block\Widget\Grid\Container
 {
     /**
+     * Initialize
+     *
      * @return void
      */
     protected function _construct()
diff --git a/app/code/Magento/Reports/Block/Adminhtml/Wishlist.php b/app/code/Magento/Reports/Block/Adminhtml/Wishlist.php
@@ -10,6 +10,7 @@
  * Adminhtml wishlist report page content block
  *
  * @deprecated 100.3.3
+ * @see Nothing
  */
 class Wishlist extends \Magento\Backend\Block\Template
 {
diff --git a/app/code/Magento/Reports/Block/Adminhtml/Wishlist/Grid.php b/app/code/Magento/Reports/Block/Adminhtml/Wishlist/Grid.php
@@ -16,6 +16,8 @@ class Grid extends \Magento\Backend\Block\Widget\Grid\Extended
     protected $_productsFactory;
 
     /**
+     * Initialize
+     *
      * @param \Magento\Backend\Block\Template\Context $context
      * @param \Magento\Backend\Helper\Data $backendHelper
      * @param \Magento\Reports\Model\ResourceModel\Wishlist\Product\CollectionFactory $productsFactory
@@ -32,6 +34,8 @@ public function __construct(
     }
 
     /**
+     * Initialize
+     *
      * @return void
      */
     protected function _construct()
@@ -43,6 +47,8 @@ protected function _construct()
     }
 
     /**
+     * Prepare collection
+     *
      * @return $this
      */
     protected function _prepareCollection()
@@ -61,6 +67,8 @@ protected function _prepareCollection()
     }
 
     /**
+     * Prepare Columns
+     *
      * @return \Magento\Backend\Block\Widget\Grid\Extended
      */
     protected function _prepareColumns()
diff --git a/app/code/Magento/Reports/Block/Product/AbstractProduct.php b/app/code/Magento/Reports/Block/Product/AbstractProduct.php
@@ -35,6 +35,8 @@ abstract class AbstractProduct extends \Magento\Catalog\Block\Product\AbstractPr
     protected $_indexFactory;
 
     /**
+     * Initialize
+     *
      * @param \Magento\Catalog\Block\Product\Context $context
      * @param \Magento\Catalog\Model\Product\Visibility $productVisibility
      * @param \Magento\Reports\Model\Product\Index\Factory $indexFactory
@@ -80,6 +82,7 @@ protected function _getProductsToSkip()
 
     /**
      * Public method for retrieve Product Index model
+     *
      * @throws \Magento\Framework\Exception\LocalizedException
      * @return \Magento\Reports\Model\Product\Index\AbstractIndex
      */
diff --git a/app/code/Magento/Reports/Block/Product/Compared.php b/app/code/Magento/Reports/Block/Product/Compared.php
@@ -10,13 +10,14 @@
  * Reports Recently Compared Products Block
  *
  * @deprecated 100.2.0
+ * @see nothing
  */
 class Compared extends \Magento\Reports\Block\Product\AbstractProduct
 {
     /**
      * Config path for compared products count
      */
-    const XML_PATH_RECENTLY_COMPARED_COUNT = 'catalog/recently_products/compared_count';
+    public const XML_PATH_RECENTLY_COMPARED_COUNT = 'catalog/recently_products/compared_count';
 
     /**
      * Compared Product Index type
@@ -42,8 +43,7 @@ public function getPageSize()
     }
 
     /**
-     * Prepare to html
-     * Check has compared products
+     * Prepare to html Check has compared products
      *
      * @return string
      */
diff --git a/app/code/Magento/Reports/Block/Product/Viewed.php b/app/code/Magento/Reports/Block/Product/Viewed.php
@@ -12,13 +12,14 @@
  * Reports Recently Viewed Products Block
  *
  * @deprecated 100.2.0
+ * @see nothing
  */
 class Viewed extends AbstractProduct implements IdentityInterface
 {
     /**
      * Config path to recently viewed product count
      */
-    const XML_PATH_RECENTLY_VIEWED_COUNT = 'catalog/recently_products/viewed_count';
+    public const XML_PATH_RECENTLY_VIEWED_COUNT = 'catalog/recently_products/viewed_count';
 
     /**
      * Viewed Product Index type
diff --git a/app/code/Magento/Reports/Block/Product/Widget/Viewed/Item.php b/app/code/Magento/Reports/Block/Product/Widget/Viewed/Item.php
@@ -9,6 +9,7 @@
  * Reports Recently Viewed Products Widget
  *
  * @deprecated 100.3.3
+ * @see nothing
  */
 class Item extends \Magento\Catalog\Block\Product\AbstractProduct implements \Magento\Widget\Block\BlockInterface
 {
diff --git a/app/code/Magento/Reports/Controller/Adminhtml/Index.php b/app/code/Magento/Reports/Controller/Adminhtml/Index.php
@@ -10,6 +10,7 @@
 namespace Magento\Reports\Controller\Adminhtml;
 
 /**
+ * phpcs:disable Magento2.Classes.AbstractApi
  * @api
  * @since 100.0.2
  */
@@ -20,7 +21,7 @@ abstract class Index extends \Magento\Backend\App\Action
      *
      * @see _isAllowed()
      */
-    const ADMIN_RESOURCE = 'Magento_Reports::report';
+    public const ADMIN_RESOURCE = 'Magento_Reports::report';
 
     /**
      * @var \Magento\Framework\App\Response\Http\FileFactory
diff --git a/app/code/Magento/Reports/Controller/Adminhtml/Report/Customer.php b/app/code/Magento/Reports/Controller/Adminhtml/Report/Customer.php
@@ -10,6 +10,7 @@
 namespace Magento\Reports\Controller\Adminhtml\Report;
 
 /**
+ * phpcs:disable Magento2.Classes.AbstractApi
  * @api
  * @since 100.0.2
  */
@@ -57,6 +58,7 @@ public function _initAction()
      */
     protected function _isAllowed()
     {
+        // phpcs:disable
         switch ($this->getRequest()->getActionName()) {
             case 'accounts':
                 return $this->_authorization->isAllowed('Magento_Reports::accounts');
diff --git a/app/code/Magento/Reports/Controller/Adminhtml/Report/Product.php b/app/code/Magento/Reports/Controller/Adminhtml/Report/Product.php
@@ -10,6 +10,7 @@
 namespace Magento\Reports\Controller\Adminhtml\Report;
 
 /**
+ * phpcs:disable Magento2.Classes.AbstractApi
  * @api
  * @since 100.0.2
  */
diff --git a/app/code/Magento/Reports/Controller/Adminhtml/Report/Review.php b/app/code/Magento/Reports/Controller/Adminhtml/Report/Review.php
@@ -10,6 +10,7 @@
 namespace Magento\Reports\Controller\Adminhtml\Report;
 
 /**
+ * phpcs:disable Magento2.Classes.AbstractApi
  * @api
  * @since 100.0.2
  */
@@ -52,6 +53,7 @@ public function _initAction()
      */
     protected function _isAllowed()
     {
+        // phpcs:disable
         switch ($this->getRequest()->getActionName()) {
             case 'customer':
                 return $this->_authorization->isAllowed('Magento_Reports::review_customer');
diff --git a/app/code/Magento/Reports/Controller/Adminhtml/Report/Sales.php b/app/code/Magento/Reports/Controller/Adminhtml/Report/Sales.php
@@ -11,6 +11,7 @@
 
 /**
  * @SuppressWarnings(PHPMD.NumberOfChildren)
+ * phpcs:disable Magento2.Classes.AbstractApi
  * @api
  * @since 100.0.2
  */
@@ -35,6 +36,7 @@ public function _initAction()
      */
     protected function _isAllowed()
     {
+        // phpcs:disable
         switch ($this->getRequest()->getActionName()) {
             case 'sales':
                 return $this->_authorization->isAllowed('Magento_Reports::salesroot_sales');
diff --git a/app/code/Magento/Reports/Controller/Adminhtml/Report/Shopcart.php b/app/code/Magento/Reports/Controller/Adminhtml/Report/Shopcart.php
@@ -23,7 +23,7 @@ abstract class Shopcart extends \Magento\Backend\App\Action
     /**
      * Authorization of a shop cart report
      */
-    const ADMIN_RESOURCE = 'Magento_Reports::shopcart';
+    public const ADMIN_RESOURCE = 'Magento_Reports::shopcart';
     /**
      * @var \Magento\Framework\App\Response\Http\FileFactory
      */
diff --git a/app/code/Magento/Reports/Model/Event.php b/app/code/Magento/Reports/Model/Event.php
@@ -26,17 +26,17 @@
  */
 class Event extends \Magento\Framework\Model\AbstractModel
 {
-    const EVENT_PRODUCT_VIEW = 1;
+    public const EVENT_PRODUCT_VIEW = 1;
 
-    const EVENT_PRODUCT_SEND = 2;
+    public const EVENT_PRODUCT_SEND = 2;
 
-    const EVENT_PRODUCT_COMPARE = 3;
+    public const EVENT_PRODUCT_COMPARE = 3;
 
-    const EVENT_PRODUCT_TO_CART = 4;
+    public const EVENT_PRODUCT_TO_CART = 4;
 
-    const EVENT_PRODUCT_TO_WISHLIST = 5;
+    public const EVENT_PRODUCT_TO_WISHLIST = 5;
 
-    const EVENT_WISHLIST_SHARE = 6;
+    public const EVENT_WISHLIST_SHARE = 6;
 
     /**
      * @var \Magento\Framework\Stdlib\DateTime\DateTimeFactory
diff --git a/app/code/Magento/Reports/Model/Flag.php b/app/code/Magento/Reports/Model/Flag.php
@@ -13,26 +13,26 @@
  */
 class Flag extends \Magento\Framework\Flag
 {
-    const REPORT_ORDER_FLAG_CODE = 'report_order_aggregated';
+    public const REPORT_ORDER_FLAG_CODE = 'report_order_aggregated';
 
-    const REPORT_TAX_FLAG_CODE = 'report_tax_aggregated';
+    public const REPORT_TAX_FLAG_CODE = 'report_tax_aggregated';
 
-    const REPORT_SHIPPING_FLAG_CODE = 'report_shipping_aggregated';
+    public const REPORT_SHIPPING_FLAG_CODE = 'report_shipping_aggregated';
 
-    const REPORT_INVOICE_FLAG_CODE = 'report_invoiced_aggregated';
+    public const REPORT_INVOICE_FLAG_CODE = 'report_invoiced_aggregated';
 
-    const REPORT_REFUNDED_FLAG_CODE = 'report_refunded_aggregated';
+    public const REPORT_REFUNDED_FLAG_CODE = 'report_refunded_aggregated';
 
-    const REPORT_COUPONS_FLAG_CODE = 'report_coupons_aggregated';
+    public const REPORT_COUPONS_FLAG_CODE = 'report_coupons_aggregated';
 
-    const REPORT_BESTSELLERS_FLAG_CODE = 'report_bestsellers_aggregated';
+    public const REPORT_BESTSELLERS_FLAG_CODE = 'report_bestsellers_aggregated';
 
-    const REPORT_PRODUCT_VIEWED_FLAG_CODE = 'report_product_viewed_aggregated';
+    public const REPORT_PRODUCT_VIEWED_FLAG_CODE = 'report_product_viewed_aggregated';
 
     /**
      * Setter for flag code
-     * @codeCoverageIgnore
      *
+     * @codeCoverageIgnore
      * @param string $code
      * @return $this
      */
diff --git a/app/code/Magento/Reports/Model/Product/Index/Compared.php b/app/code/Magento/Reports/Model/Product/Index/Compared.php
@@ -16,6 +16,7 @@
  * @method string getAddedAt()
  * @method \Magento\Reports\Model\Product\Index\Compared setAddedAt(string $value)
  *
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  * @api
  * @since 100.0.2
  */
diff --git a/app/code/Magento/Reports/Model/Product/Index/Viewed.php b/app/code/Magento/Reports/Model/Product/Index/Viewed.php
@@ -16,6 +16,7 @@
  * @method string getAddedAt()
  * @method \Magento\Reports\Model\Product\Index\Viewed setAddedAt(string $value)
  *
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  * @api
  * @since 100.0.2
  */

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class Refunded extends \Magento\Backend\Block\Widget\Grid\Container`
`21`	`21`	`protected $_template = 'Magento_Reports::report/grid/container.phtml';`
`22`	`22`
`23`	`23`	`/**`
`24`		`- * {@inheritdoc}`
	`24`	`+ * @inheritdoc`
`25`	`25`	`*/`
`26`	`26`	`protected function _construct()`
`27`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class Sales extends \Magento\Backend\Block\Widget\Grid\Container`
`21`	`21`	`protected $_template = 'Magento_Reports::report/grid/container.phtml';`
`22`	`22`
`23`	`23`	`/**`
`24`		`- * {@inheritdoc}`
	`24`	`+ * @inheritdoc`
`25`	`25`	`*/`
`26`	`26`	`protected function _construct()`
`27`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class Shipping extends \Magento\Backend\Block\Widget\Grid\Container`
`21`	`21`	`protected $_template = 'Magento_Reports::report/grid/container.phtml';`
`22`	`22`
`23`	`23`	`/**`
`24`		`- * {@inheritdoc}`
	`24`	`+ * @inheritdoc`
`25`	`25`	`*/`
`26`	`26`	`protected function _construct()`
`27`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class Tax extends \Magento\Backend\Block\Widget\Grid\Container`
`21`	`21`	`protected $_template = 'Magento_Reports::report/grid/container.phtml';`
`22`	`22`
`23`	`23`	`/**`
`24`		`- * {@inheritdoc}`
	`24`	`+ * @inheritdoc`
`25`	`25`	`*/`
`26`	`26`	`protected function _construct()`
`27`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@`
`11`	`11`	`class Abandoned extends \Magento\Backend\Block\Widget\Grid\Container`
`12`	`12`	`{`
`13`	`13`	`/**`
	`14`	`+ * Initialize`
	`15`	`+ *`
`14`	`16`	`* @return void`
`15`	`17`	`*/`
`16`	`18`	`protected function _construct()`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`* Adminhtml wishlist report page content block`
`11`	`11`	`*`
`12`	`12`	`* @deprecated 100.3.3`
	`13`	`+ * @see Nothing`
`13`	`14`	`*/`
`14`	`15`	`class Wishlist extends \Magento\Backend\Block\Template`
`15`	`16`	`{`