AC-7562::2.4.6-alpha2-Composer Integration Test Failures(Broken)

glo82145 · glo82145 · commit 85ff1ab6ee26 · 2023-01-05T18:17:05.000+05:30
diff --git a/app/code/Magento/CheckoutAgreements/Test/Unit/Model/CheckoutAgreementsRepositoryTest.php b/app/code/Magento/CheckoutAgreements/Test/Unit/Model/CheckoutAgreementsRepositoryTest.php
@@ -1,3 +1,4 @@
+
 <?php
 /**
  * Copyright © Magento, Inc. All rights reserved.
diff --git a/app/code/Magento/GiftMessage/Test/Unit/Model/CartRepositoryTest.php b/app/code/Magento/GiftMessage/Test/Unit/Model/CartRepositoryTest.php
@@ -1,4 +1,4 @@
-<?php
+    <?php
 /**
  *
  * Copyright © Magento, Inc. All rights reserved.
diff --git a/app/code/Magento/Paypal/Test/Unit/Controller/ExpressTest.php b/app/code/Magento/Paypal/Test/Unit/Controller/ExpressTest.php
@@ -32,7 +32,8 @@ abstract class ExpressTest extends TestCase
     /** @var Express */
     protected $model;
 
-    protected $name = '';
+ /** @var string */
+  protected $name = '';
 
     /** @var Session|MockObject */
     protected $customerSession;
diff --git a/app/code/Magento/Tax/Test/Unit/Model/Sales/Total/Quote/TaxTest.php b/app/code/Magento/Tax/Test/Unit/Model/Sales/Total/Quote/TaxTest.php
@@ -48,7 +48,7 @@
  */
 class TaxTest extends TestCase
 {
-    const TAX = 0.2;
+    public const TAX = 0.2;
 
     /**
      * Tests the specific method
diff --git a/dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/CartRepositoryTest.php b/dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/CartRepositoryTest.php
@@ -9,9 +9,9 @@
 
 class CartRepositoryTest extends WebapiAbstract
 {
-    const SERVICE_VERSION = 'V1';
-    const SERVICE_NAME = 'giftMessageCartRepositoryV1';
-    const RESOURCE_PATH = '/V1/carts/';
+    public const SERVICE_VERSION = 'V1';
+    public const SERVICE_NAME = 'giftMessageCartRepositoryV1';
+    public const RESOURCE_PATH = '/V1/carts/';
 
     /**
      * @var \Magento\TestFramework\ObjectManager
diff --git a/dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/GuestCartRepositoryTest.php b/dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/GuestCartRepositoryTest.php
@@ -9,9 +9,9 @@
 
 class GuestCartRepositoryTest extends WebapiAbstract
 {
-    const SERVICE_VERSION = 'V1';
-    const SERVICE_NAME = 'giftMessageGuestCartRepositoryV1';
-    const RESOURCE_PATH = '/V1/guest-carts/';
+    public const SERVICE_VERSION = 'V1';
+    public const SERVICE_NAME = 'giftMessageGuestCartRepositoryV1';
+    public const RESOURCE_PATH = '/V1/guest-carts/';
 
     /**
      * @var \Magento\TestFramework\ObjectManager
diff --git a/dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/ItemRepositoryTest.php b/dev/tests/api-functional/testsuite/Magento/GiftMessage/Api/ItemRepositoryTest.php
@@ -9,9 +9,9 @@
 
 class ItemRepositoryTest extends WebapiAbstract
 {
-    const SERVICE_VERSION = 'V1';
-    const SERVICE_NAME = 'giftMessageItemRepositoryV1';
-    const RESOURCE_PATH = '/V1/carts/';
+    public const SERVICE_VERSION = 'V1';
+    public const SERVICE_NAME = 'giftMessageItemRepositoryV1';
+    public const RESOURCE_PATH = '/V1/carts/';
 
     /**
      * @var \Magento\TestFramework\ObjectManager
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetCartTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetCartTest.php
@@ -131,7 +131,8 @@ public function testGetCartIfCartIdIsEmpty()
     public function testGetCartIfCartIdIsMissed()
     {
         $this->expectException(\Exception::class);
-        $this->expectExceptionMessage('Field "cart" argument "cart_id" of type "String!" is required but not provided.');
+        $message = 'Field "cart" argument "cart_id" of type "String!" is required but not provided.';
+        $this->expectExceptionMessage($message);
 
         $query = <<<QUERY
 {
@@ -201,7 +202,8 @@ public function testGetCartWithNotDefaultStore()
     public function testGetCartWithWrongStore()
     {
         $this->expectException(\Exception::class);
-        $this->expectExceptionMessage('The account sign-in was incorrect or your account is disabled temporarily. Please wait and try again later.');
+        $message = 'The account sign-in was incorrect or your account is disabled       temporarily. Please wait and try again later.';
+        $this->expectExceptionMessage($message);
 
         $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_order_1');
         $query = $this->getQuery($maskedQuoteId);
diff --git a/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/ShipOrderTest.php b/dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/ShipOrderTest.php
@@ -19,8 +19,8 @@
  */
 class ShipOrderTest extends \Magento\TestFramework\TestCase\WebapiAbstract
 {
-    const SERVICE_READ_NAME = 'salesShipOrderV1';
-    const SERVICE_VERSION = 'V1';
+    public const SERVICE_READ_NAME = 'salesShipOrderV1';
+    public const SERVICE_VERSION = 'V1';
 
     /**
      * @var ObjectManagerInterface
diff --git a/dev/tests/static/testsuite/Magento/Test/Integrity/Layout/BlocksTest.php b/dev/tests/static/testsuite/Magento/Test/Integrity/Layout/BlocksTest.php
@@ -1,7 +1,5 @@
 <?php
 /**
- * Test layout declaration and usage of block elements
- *
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
diff --git a/lib/internal/Magento/Framework/App/Utility/AggregateInvoker.php b/lib/internal/Magento/Framework/App/Utility/AggregateInvoker.php
@@ -37,6 +37,7 @@ public function __construct($testCase, array $options = [])
 
     /**
      * Collect all failed assertions and fail test in case such list is not empty.
+     * 
      * Incomplete and skipped test results are aggregated as well.
      *
      * @param callable $callback
@@ -71,6 +72,8 @@ public function __invoke(callable $callback, array $dataSource)
     }
 
     /**
+     * prepare Message
+     * 
      * @param \Exception $exception
      * @param string $dataSetName
      * @param mixed $dataSet

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+`
`1`	`2`	`<?php`
`2`	`3`	`/**`
`3`	`4`	`* Copyright © Magento, Inc. All rights reserved.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<?php`
	`1`	`+ <?php`
`2`	`2`	`/**`
`3`	`3`	`*`
`4`	`4`	`* Copyright © Magento, Inc. All rights reserved.`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@`
`48`	`48`	`*/`
`49`	`49`	`class TaxTest extends TestCase`
`50`	`50`	`{`
`51`		`- const TAX = 0.2;`
	`51`	`+ public const TAX = 0.2;`
`52`	`52`
`53`	`53`	`/**`
`54`	`54`	`* Tests the specific method`
Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,8 @@ public function testGetCartIfCartIdIsEmpty()`
`131`	`131`	`public function testGetCartIfCartIdIsMissed()`
`132`	`132`	`{`
`133`	`133`	`$this->expectException(\Exception::class);`
`134`		`- $this->expectExceptionMessage('Field "cart" argument "cart_id" of type "String!" is required but not provided.');`
	`134`	`+ $message = 'Field "cart" argument "cart_id" of type "String!" is required but not provided.';`
	`135`	`+ $this->expectExceptionMessage($message);`
`135`	`136`
`136`	`137`	`$query = <<<QUERY`
`137`	`138`	`{`
`@@ -201,7 +202,8 @@ public function testGetCartWithNotDefaultStore()`
`201`	`202`	`public function testGetCartWithWrongStore()`
`202`	`203`	`{`
`203`	`204`	`$this->expectException(\Exception::class);`
`204`		`- $this->expectExceptionMessage('The account sign-in was incorrect or your account is disabled temporarily. Please wait and try again later.');`
	`205`	`+ $message = 'The account sign-in was incorrect or your account is disabled temporarily. Please wait and try again later.';`
	`206`	`+ $this->expectExceptionMessage($message);`
`205`	`207`
`206`	`208`	`$maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_order_1');`
`207`	`209`	`$query = $this->getQuery($maskedQuoteId);`