LYNX-955: [AC-2.4.9] GraphQL API Customer ID value Deprecation Removal (#375)

* LYNX-955: [AC-2.4.9] GraphQL API Customer ID value Deprecation Removal

* Test cases added

* Tests fixed

* Test cases updated

* LYNX-955 feedbacks fixed

* LYNX-955 Review feedback fixed

* LYNX-955 review feedback fixed

* Static tests fixed

Author: cod40403

app/code/Magento/CustomerGraphQl/Model/Customer/ExtractCustomerData.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2017 Adobe
+ * All Rights Reserved.
  */
 declare(strict_types=1);
 
@@ -12,6 +12,7 @@
 use Magento\Customer\Api\Data\CustomerInterface;
 use Magento\EavGraphQl\Model\GetAttributeValueComposite;
 use Magento\Framework\Exception\LocalizedException;
+use Magento\Framework\GraphQl\Query\Uid;
 use Magento\Framework\Webapi\ServiceOutputProcessor;
 
 /**
@@ -20,25 +21,17 @@
 class ExtractCustomerData
 {
     /**
-     * @var ServiceOutputProcessor
-     */
-    private $serviceOutputProcessor;
-
-    /**
-     * @var GetAttributeValueComposite
-     */
-    private GetAttributeValueComposite $getAttributeValueComposite;
-
-    /**
+     * ExtractCustomerData Constructor.
+     *
      * @param ServiceOutputProcessor $serviceOutputProcessor
      * @param GetAttributeValueComposite $getAttributeValueComposite
+     * @param Uid $idEncoder
      */
     public function __construct(
-        ServiceOutputProcessor $serviceOutputProcessor,
-        GetAttributeValueComposite $getAttributeValueComposite
+        private readonly ServiceOutputProcessor     $serviceOutputProcessor,
+        private readonly GetAttributeValueComposite $getAttributeValueComposite,
+        private readonly Uid                        $idEncoder
     ) {
-        $this->serviceOutputProcessor = $serviceOutputProcessor;
-        $this->getAttributeValueComposite = $getAttributeValueComposite;
     }
 
     /**
@@ -57,6 +50,7 @@ private function curateAddressData(array $arrayAddress): array
                 $arrayAddress[$key]['default_billing'] = false;
             }
         }
+
         return $arrayAddress;
     }
 
@@ -98,14 +92,15 @@ function (array $customAttribute) {
         }
         //Fields are deprecated and should not be exposed on storefront.
         $customerData['group_id'] = null;
-        $customerData['id'] = null;
-
         $customerData['model'] = $customer;
 
         //'dob' is deprecated, 'date_of_birth' is used instead.
         if (!empty($customerData['dob'])) {
             $customerData['date_of_birth'] = $customerData['dob'];
         }
+
+        $customerData['id'] = $this->idEncoder->encode((string) $customerData['id']);
+
         return $customerData;
     }
 }

app/code/Magento/CustomerGraphQl/etc/schema.graphqls

@@ -147,7 +147,7 @@ type Customer @doc(description: "Defines the customer name, addresses, and other
     dob: String @doc(description: "The customer's date of birth.") @deprecated(reason: "Use `date_of_birth` instead.")
     date_of_birth: String @doc(description: "The customer's date of birth.")
     taxvat: String @doc(description: "The customer's Value-added tax (VAT) number (for corporate customers).")
-    id: Int @doc(description: "The ID assigned to the customer.") @deprecated(reason: "`id` is not needed as part of `Customer`, because on the server side, it can be identified based on the customer token used for authentication. There is no need to know customer ID on the client side.")
+    id: ID! @doc(description: "The unique ID assigned to the customer.")
     is_subscribed: Boolean @doc(description: "Indicates whether the customer is subscribed to the company's newsletter.") @resolver(class: "\\Magento\\NewsletterGraphQl\\Model\\Resolver\\IsSubscribed")
     addresses: [CustomerAddress] @doc(description: "An array containing the customer's shipping and billing addresses.") @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\CustomerAddresses")
     addressesV2(