[Magento Community Engineering] Community Contributions - 2.4-develop

 - merged latest code from mainline branch

Author: magento-engcom-team

app/code/Magento/MediaGalleryUi/view/adminhtml/web/template/image/image-details.html

@@ -33,7 +33,7 @@ <h3 translate="'Details'"></h3>
                         <each args="{ data: value, as: 'item'}">
                           <div class="value">
                             <a attr="href: $parents[1].getFilterUrl(item.link)"
-                               text="$parents[1].getUsedInText(item)"></a></br>
+                               text="$parents[1].getUsedInText(item)"></a><br/>
                           </div>
                         </each>
                       </if>

app/code/Magento/Ui/view/base/web/js/modal/modal.js

@@ -24,7 +24,7 @@ define([
      * Detect browser transition end event.
      * @return {String|undefined} - transition event.
      */
-    var transitionEvent =  (function () {
+    var transitionEvent = (function () {
         var transition,
             elementStyle = document.createElement('div').style,
             transitions = {
@@ -39,7 +39,39 @@ define([
                 return transitions[transition];
             }
         }
-    })();
+    })(),
+
+    /**
+     * Implementation of zIndex used from jQuery UI
+     * @param {Element} elem
+     * @private
+     */
+    getZIndex = function (elem) {
+        var position, zIndex;
+
+        /* eslint-disable max-depth */
+        while (elem.length && elem[ 0 ] !== document) {
+            // Ignore z-index if position is set to a value where z-index is ignored by the browser
+            // This makes behavior of this function consistent across browsers
+            // WebKit always returns auto if the element is positioned
+            position = elem.css('position');
+
+            if (position === 'absolute' || position === 'relative' || position === 'fixed') {
+                // IE returns 0 when zIndex is not specified
+                // other browsers return a string
+                // we ignore the case of nested elements with an explicit value of 0
+                zIndex = parseInt(elem.css('zIndex'), 10);
+
+                if (!isNaN(zIndex) && zIndex !== 0) {
+                    return zIndex;
+                }
+            }
+            elem = elem.parent();
+        }
+
+        return 0;
+        /* eslint-enable max-depth */
+    };
 
     /**
      * Modal Window Widget
@@ -341,18 +373,17 @@ define([
          * Set z-index and margin for modal and overlay.
          */
         _setActive: function () {
-            var zIndex = this.modal.zIndex(),
+            var zIndex = getZIndex(this.modal),
                 baseIndex = zIndex + this._getVisibleCount();
 
             if (this.modal.data('active')) {
                 return;
             }
-
             this.modal.data('active', true);
 
-            this.overlay.zIndex(++baseIndex);
-            this.prevOverlayIndex = this.overlay.zIndex();
-            this.modal.zIndex(this.overlay.zIndex() + 1);
+            this.overlay.css('z-index', ++baseIndex);
+            this.prevOverlayIndex = baseIndex;
+            this.modal.css('z-index', baseIndex + 1);
 
             if (this._getVisibleSlideCount()) {
                 this.modal.css('marginLeft', this.options.modalLeftMargin * this._getVisibleSlideCount());
@@ -367,7 +398,7 @@ define([
             this.modal.data('active', false);
 
             if (this.overlay) {
-                this.overlay.zIndex(this.prevOverlayIndex - 1);
+                this.overlay.css('z-index', this.prevOverlayIndex - 1);
             }
         },
 

dev/tests/static/framework/Magento/TestFramework/CodingStandard/Tool/CodeSniffer.php

@@ -99,6 +99,7 @@ public function run(array $whiteList)
         $settings['standards'] = [$this->rulesetDir];
         $settings['extensions'] = $this->extensions;
         $settings['reports']['full'] = $this->reportFile;
+        $settings['reportWidth'] = 120;
         $this->wrapper->setSettings($settings);
 
         // phpcs:ignore Magento2.Functions.DiscouragedFunction

dev/tests/static/framework/tests/unit/testsuite/Magento/TestFramework/CodingStandard/Tool/CodeSnifferTest.php

@@ -28,7 +28,7 @@ class CodeSnifferTest extends \PHPUnit\Framework\TestCase
     const RULE_SET = 'some/ruleset/directory';
 
     /**
-     * Report file
+     * Report file path
      */
     const REPORT_FILE = 'some/report/file.xml';
 
@@ -52,6 +52,7 @@ public function testRun()
             'standards' => [self::RULE_SET],
             'extensions' => $extensions,
             'reports' => ['full' => self::REPORT_FILE],
+            'reportWidth' => 120
         ];
 
         $this->_tool->setExtensions($extensions);

dev/tests/static/testsuite/Magento/Test/Html/LiveCodeTest.php

@@ -6,6 +6,7 @@
 
 namespace Magento\Test\Html;
 
+use Magento\Framework\App\Utility\Files;
 use Magento\TestFramework\CodingStandard\Tool\CodeSniffer;
 use Magento\Test\Php\LiveCodeTest as PHPCodeTest;
 use Magento\TestFramework\CodingStandard\Tool\CodeSniffer\Wrapper;
@@ -46,12 +47,33 @@ public function testCodeStyle(): void
         $reportFile = self::$reportDir . '/html_report.txt';
         $codeSniffer = new CodeSniffer('Magento', $reportFile, new Wrapper());
         $codeSniffer->setExtensions([self::FILE_EXTENSION]);
-        $result = $codeSniffer->run(PHPCodeTest::getWhitelist([self::FILE_EXTENSION], __DIR__, __DIR__));
+        $fileList =  $this->isFullScan() ? array_column(Files::init()->getStaticHtmlFiles(), '0')
+            : PHPCodeTest::getWhitelist([self::FILE_EXTENSION], __DIR__, __DIR__);
+        $result = $codeSniffer->run($fileList);
         $report = file_exists($reportFile) ? file_get_contents($reportFile) : '';
         $this->assertEquals(
             0,
             $result,
             "PHP Code Sniffer detected {$result} violation(s): " . PHP_EOL . $report
         );
     }
+
+    /**
+     * Returns whether a full scan was requested.
+     *
+     * This can be set in the `phpunit.xml` used to run these test cases, by setting the constant
+     * `TESTCODESTYLE_IS_FULL_SCAN` to `1`, e.g.:
+     * ```xml
+     * <php>
+     *     <!-- TESTCODESTYLE_IS_FULL_SCAN - specify if full scan should be performed for test code style test -->
+     *     <const name="TESTCODESTYLE_IS_FULL_SCAN" value="0"/>
+     * </php>
+     * ```
+     *
+     * @return bool
+     */
+    private function isFullScan(): bool
+    {
+        return defined('TESTCODESTYLE_IS_FULL_SCAN') && TESTCODESTYLE_IS_FULL_SCAN === '1';
+    }
 }