B2B-2037: [AWS S3] [Integration Tests]: Investigate Test Failures in MediaGallerySynchronization & MediaGallerySynchronizationMetadata modules

Author: oshmyheliuk

app/code/Magento/MediaGalleryMetadata/Model/AddIptcMetadata.php

@@ -52,6 +52,8 @@ class AddIptcMetadata
      * @param DriverInterface $driver
      * @param ReadFile $fileReader
      * @param Filesystem|null $filesystem
+     * @param IptcEmbed|null $iptcEmbed
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function __construct(
         FileInterfaceFactory $fileFactory,

app/code/Magento/MediaGalleryMetadata/Model/Gif/ReadFile.php

@@ -330,6 +330,8 @@ private function readBlock($resource): string
     }
 
     /**
+     * Returns current driver for media dircetory
+     *
      * @return DriverInterface
      * @throws FileSystemException
      */

app/code/Magento/MediaGalleryMetadata/Model/Gif/WriteFile.php

@@ -86,6 +86,8 @@ private function writeSegments($resource, array $segments): void
     }
 
     /**
+     * Returns current driver for media dircetory
+     *
      * @return DriverInterface
      * @throws FileSystemException
      */

app/code/Magento/MediaGalleryMetadata/Model/IptcEmbed.php

@@ -17,6 +17,8 @@ class IptcEmbed
     /**
      * Returns result of iptcembed function
      *
+     * @param string $iptcData
+     * @param string $filePath
      * @throws LocalizedException if iptcembed function is not enabled
      */
     public function get(string $iptcData, string $filePath)

app/code/Magento/MediaGalleryMetadata/Model/Jpeg/ReadFile.php

@@ -219,6 +219,8 @@ private function read($resource, int $length): string
     }
 
     /**
+     * Returns current driver for media dircetory
+     *
      * @return DriverInterface
      * @throws FileSystemException
      */

app/code/Magento/MediaGalleryMetadata/Model/Jpeg/Segment/ReadExif.php

@@ -37,6 +37,7 @@ class ReadExif implements ReadMetadataInterface
 
     /**
      * @param MetadataInterfaceFactory $metadataFactory
+     * @param ExifReader|null $exifReader
      */
     public function __construct(
         MetadataInterfaceFactory $metadataFactory,

app/code/Magento/MediaGalleryMetadata/Model/Jpeg/WriteFile.php

@@ -51,7 +51,7 @@ class WriteFile implements WriteFileInterface
     public function __construct(
         DriverInterface $driver,
         SegmentNames $segmentNames,
-        Filesystem $filesystem
+        Filesystem $filesystem = null
     ) {
         $this->segmentNames = $segmentNames;
         $this->filesystem = $filesystem ?? ObjectManager::getInstance()->get(Filesystem::class);
@@ -102,6 +102,8 @@ private function writeSegments($resource, array $segments): void
     }
 
     /**
+     * Returns current driver for media dircetory
+     *
      * @return DriverInterface
      * @throws FileSystemException
      */

app/code/Magento/MediaGalleryMetadata/Model/Png/ReadFile.php

@@ -136,8 +136,9 @@ private function read($resource, int $length): string
         return $data;
     }
 
-
     /**
+     * Returns current driver for media dircetory
+     *
      * @return DriverInterface
      * @throws FileSystemException
      */

app/code/Magento/MediaGalleryMetadata/Model/Png/WriteFile.php

@@ -49,7 +49,7 @@ class WriteFile implements WriteFileInterface
     public function __construct(
         DriverInterface $driver,
         SegmentNames $segmentNames,
-        Filesystem $filesystem
+        Filesystem $filesystem = null
     ) {
         $this->segmentNames = $segmentNames;
         $this->filesystem = $filesystem ?? ObjectManager::getInstance()->get(Filesystem::class);
@@ -88,6 +88,8 @@ private function writeSegments($resource, array $segments): void
     }
 
     /**
+     * Returns current driver for media dircetory
+     *
      * @return DriverInterface
      * @throws FileSystemException
      */

app/code/Magento/MediaGalleryMetadata/Test/Integration/Model/Png/Segment/XmpTest.php

@@ -34,11 +34,6 @@ class XmpTest extends TestCase
      */
     private $xmpReader;
 
-    /**
-     * @var DriverInterface
-     */
-    private $driver;
-
     /**
      * @var ReadFile
      */