Skip to content

Commit 7b5597b

Browse files
CABPI-410: fixed CR comments
1 parent cccb609 commit 7b5597b

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

app/code/Magento/AdminAdobeIms/Test/Mftf/ActionGroup/AdminCreateUserWithoutPasswordActionGroup.xml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,30 @@
2121
<!--Open New Admin User Page. -->
2222
<amOnPage url="{{AdminNewUserPage.url}}" stepKey="navigateToNewAdminUser"/>
2323
<waitForPageLoad stepKey="waitForNewAdminUserPage"/>
24+
2425
<!-- Fill admin user data. -->
2526
<fillField selector="{{AdminCreateUserSection.usernameTextField}}" userInput="{{user.username}}" stepKey="enterAdminUserName"/>
2627
<fillField selector="{{AdminCreateUserSection.firstNameTextField}}" userInput="{{user.firstName}}" stepKey="enterAdminFirstName"/>
2728
<fillField selector="{{AdminCreateUserSection.lastNameTextField}}" userInput="{{user.lastName}}" stepKey="enterAdminLastName"/>
2829
<fillField selector="{{AdminCreateUserSection.emailTextField}}" userInput="{{user.username}}@magento.com" stepKey="enterAdminEmail"/>
30+
2931
<!-- Verify Current Admin User Identity via Adobe IMS. -->
3032
<click selector="{{AdminCreateUserSection.confirmIdentity}}" stepKey="clickConfirmIdentity"/>
31-
<wait time="10" stepKey="waitNewTabToLoad"/>
32-
<!-- Switch to the New tab. -->
33+
34+
<!-- Switch to Admin IMS Window. -->
3335
<switchToNextTab stepKey="switchToNextTab"/>
36+
<waitForElementVisible selector="{{AdminAdobeImsSignInSection.password}}" stepKey="waitForAdobeImsForm"/>
3437
<fillField selector="{{AdminCreateUserSection.password}}" userInput="{{password}}" stepKey="fillPassword"/>
3538
<click selector="{{AdminAdobeImsSignInSection.AdobeImsPasswordContinueButton}}" stepKey="clickPasswordContinue"/>
36-
<wait time="10" stepKey="waitTabToDisappear"/>
37-
<!-- Switch to the previous tab. -->
39+
<waitForElementNotVisible selector="{{AdminAdobeImsSignInSection.password}}" time="30" stepKey="waitForAdobeImsFormToDisappear"/>
40+
41+
<!-- Switch to Adobe Commerce Window. -->
3842
<switchToPreviousTab userInput="1" stepKey="switchPreviousTab"/>
43+
3944
<!-- Select Admin User Role. -->
4045
<click selector="{{AdminCreateUserSection.userRoleTab}}" stepKey="clickUserRole"/>
4146
<click selector="{{AdminStoreSection.createdRoleInUserPage(role.name)}}" stepKey="chooseRole"/>
47+
4248
<!-- Save admin user. -->
4349
<click selector="{{AdminCreateUserSection.saveButton}}" stepKey="clickSaveUser"/>
4450
<waitForPageLoad stepKey="waitForSaveTheUser"/>

app/code/Magento/AdminAdobeIms/Test/Mftf/Test/AdminCreateNewAdminUserWithAdobeImsTest.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515
<description value="Create a new admin user when AdminAdobeImsModule is enabled"/>
1616
<severity value="CRITICAL"/>
1717
<group value="admin_ims"/>
18-
<skip>
19-
<issueId value="AC-3153">Skipped</issueId>
20-
</skip>
2118
<testCaseId value="CABPI-227"/>
2219
</annotations>
2320
<before>

0 commit comments

Comments
 (0)