code review fixes

Author: karyna-t

app/code/Magento/Catalog/Helper/Image.php

@@ -776,8 +776,8 @@ protected function getImageFile()
      */
     protected function parseSize($string)
     {
-        $size = $string ? explode('x', strtolower($string)) : [''];
-        if (count($size) == 2) {
+        $size = $string !== null ? explode('x', strtolower($string)) : [];
+        if (count($size) === 2) {
             return ['width' => $size[0] > 0 ? $size[0] : null, 'height' => $size[1] > 0 ? $size[1] : null];
         }
         return false;

app/code/Magento/Catalog/Model/Category.php

@@ -846,7 +846,7 @@ public function getPathIds()
     {
         $ids = $this->getData('path_ids');
         if ($ids === null) {
-            $ids = $this->getPath() ? explode('/', $this->getPath()) : [''];
+            $ids = $this->getPath() ? explode('/', $this->getPath()) : [];
             $this->setData('path_ids', $ids);
         }
         return $ids;
@@ -860,7 +860,7 @@ public function getPathIds()
     public function getLevel()
     {
         if (!$this->hasLevel()) {
-            return $this->getPath() ? (count(explode('/', $this->getPath())) - 1) : 0;
+            return $this->getPath() ? count(explode('/', $this->getPath())) - 1 : 0;
         }
         return $this->getData(self::KEY_LEVEL);
     }

app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/DataProvider.php

@@ -574,7 +574,7 @@ private function getAttributeValue($attributeId, $valueIds, $storeId)
         if (false !== $value) {
             $optionValue = $this->getAttributeOptionValue($attributeId, $valueIds, $storeId);
             if (null === $optionValue) {
-                $value = ($value !== null) ? $this->filterAttributeValue($value) : '';
+                $value = $value !== null ? $this->filterAttributeValue($value) : '';
             } else {
                 $value = implode($this->separator, array_filter([$value, $optionValue]));
             }
@@ -594,7 +594,7 @@ private function getAttributeValue($attributeId, $valueIds, $storeId)
     private function getAttributeOptionValue($attributeId, $valueIds, $storeId)
     {
         $optionKey = $attributeId . '-' . $storeId;
-        $attributeValueIds = ($valueIds !== null) ? explode(',', $valueIds) : [''];
+        $attributeValueIds = $valueIds !== null ? explode(',', $valueIds) : [];
         $attributeOptionValue = '';
         if (!array_key_exists($optionKey, $this->attributeOptions)
         ) {
@@ -608,7 +608,7 @@ private function getAttributeOptionValue($attributeId, $valueIds, $storeId)
                 $this->attributeOptions[$optionKey] = array_column($options, 'label', 'value');
                 $this->attributeOptions[$optionKey] = array_map(
                     function ($value) {
-                        return ($value !== null) ? $this->filterAttributeValue($value) : '';
+                        return $value !== null ? $this->filterAttributeValue($value) : '';
                     },
                     $this->attributeOptions[$optionKey]
                 );

app/code/Magento/Quote/Model/Quote/Address.php

@@ -1453,7 +1453,7 @@ public function setCountryId($countryId)
     public function getStreet()
     {
         $street = $this->getData(self::KEY_STREET);
-        if (!$street) {
+        if ($street === null) {
             return [''];
         }
         return is_array($street) ? $street : explode("\n", $street);

app/code/Magento/Tax/Model/ResourceModel/Calculation.php

@@ -229,7 +229,7 @@ protected function _createSearchPostCodeTemplates($postcode, $exactPostcode = nu
     {
         // as needed, reduce the postcode to the correct length
         $len = $this->_taxData->getPostCodeSubStringLength();
-        $postcode = ($postcode !== null) ? substr($postcode, 0, $len) : '';
+        $postcode = $postcode !== null ? substr($postcode, 0, $len) : '';
 
         // begin creating the search template array
         $strArr = [$postcode, $postcode . '*'];

lib/internal/Magento/Framework/Filter/Translit.php

@@ -531,7 +531,7 @@ protected function getConvertTable()
      */
     public function filter($string)
     {
-        $string = ($string !== null) ? strtr($string, $this->getConvertTable()) : '';
+        $string = $string !== null ? strtr($string, $this->getConvertTable()) : '';
         return '"libiconv"' == ICONV_IMPL ? iconv(
             \Magento\Framework\Stdlib\StringUtils::ICONV_CHARSET,
             'ascii//ignore//translit',

lib/internal/Magento/Framework/Stdlib/StringUtils.php

@@ -160,7 +160,7 @@ public function strlen($string)
      */
     public function cleanString($string)
     {
-        return ($string !== null) ? mb_convert_encoding($string, self::ICONV_CHARSET) : '';
+        return $string !== null ? mb_convert_encoding($string, self::ICONV_CHARSET) : '';
     }
 
     /**